Fix: Wrong phong renderer mesh transform

Author: brenocq

src/atta/graphics/apis/openGL/openGLAPI.cpp

@@ -68,9 +68,11 @@ void OpenGLAPI::startUp() {
         nullptr);
 #endif // ATTA_DEBUG_BUILD
 
-    // Enable cubemap seamless if supported
+    // Enable cubemap seamless if supported (desktop OpenGL only, not available in WebGL/GLES)
+#ifndef ATTA_OS_WEB
     if (_apiVersion >= 320)
         glEnable(GL_TEXTURE_CUBE_MAP_SEAMLESS);
+#endif
 
     glEnable(GL_DEPTH_TEST);
 }

src/atta/graphics/apis/openGL/shader.cpp

@@ -33,7 +33,8 @@ std::string Shader::generateApiCode(ShaderType type, std::string iCode) {
         apiCode = "#version 330 core\n";
     } else if (openGLVersion >= 300) {
         apiCode = "#version 300 es\n"
-                  "precision mediump float;\n";
+                  "precision highp float;\n"
+                  "precision highp int;\n";
     } else {
         LOG_ERROR("gfx::gl::Shader", "Compiling shaders for OpenGL version [w]$0[] is not supported", openGLVersion);
         return "";
@@ -71,6 +72,11 @@ std::string Shader::generateApiCode(ShaderType type, std::string iCode) {
         // Move to the next match
         start = match.suffix().first;
     }
+
+    // Strip f/F suffix from float literals for GLSL ES (e.g. 1.0f -> 1.0)
+    if (openGLVersion < 330)
+        apiCode = std::regex_replace(apiCode, std::regex(R"((\d+\.\d*)[fF]\b)"), "$1");
+
     // LOG_DEBUG("gfx::gl::Shader", "Generated API code for shader [g]$1[]\n[w]$0[]", apiCode, _file.string());
 
     return apiCode;

src/atta/graphics/renderers/phongRenderer.cpp

@@ -110,6 +110,8 @@ void PhongRenderer::render(std::shared_ptr<Camera> camera) {
                             int i = numPointLights++;
                             _geometryPipeline->setVec3(("uPointLights[" + std::to_string(i) + "].position").c_str(), position);
                             _geometryPipeline->setVec3(("uPointLights[" + std::to_string(i) + "].intensity").c_str(), pl->intensity);
+                        } else if (pl) {
+                            LOG_WARN("gfx::PhongRenderer", "Maximum number of point lights reached, 10 lights");
                         }
                         if (dl) {
                             hasDirectionalLight = true;
@@ -118,8 +120,6 @@ void PhongRenderer::render(std::shared_ptr<Camera> camera) {
                             _geometryPipeline->setVec3("uDirectionalLight.direction", direction);
                             _geometryPipeline->setVec3("uDirectionalLight.intensity", dl->intensity);
                         }
-                        if (numPointLights++ == 10)
-                            LOG_WARN("gfx::PhongRenderer", "Maximum number of point lights reached, 10 lights");
                     }
                 }
                 _geometryPipeline->setInt("uNumPointLights", numPointLights);

src/atta/graphics/shader.cpp

@@ -175,7 +175,7 @@ std::string Shader::generateICode(ShaderType type, std::string aslCode) {
             for (size_t i = 0; i < _vertexLayout.getElements().size(); i++) {
                 BufferLayout::Element element = _vertexLayout.getElements()[i];
                 std::string typeStr = BufferLayout::Element::typeToString(element.type);
-                input += "in " + typeStr + " " + element.name + ";\n";
+                input += "layout(location = " + std::to_string(i) + ") in " + typeStr + " " + element.name + ";\n";
                 params += element.name;
                 if (i != _vertexLayout.getElements().size() - 1)
                     params += ", ";