Use Darwin's libicucore.A.dylib.#66
Open
geoff-nixon wants to merge 1 commit into
Open
Conversation
Owner
|
I'm definitely down to use the bundled ICU in OSX, but I think we should try and come up with a solution that works across different versions. The versions (and therefore the headers) that ship with each version of OSX are different. Not sure how best to handle that without shipping a bunch of versions of the headers :\ |
Author
|
This is a set I's selected and cut down to only those needed here. I've tested this single set works identically 10.7 - 10.9+. |
|
It might be simpler to just fix the merge conflicts in #20 instead... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Brian,
Thanks for the update! Obviously, 0.7.0 effectively closes #55.
Unfortunately, is still only half the issue on Darwin. The other half is that the system ICU works just fine, buts just missing the requisite headers. I believe this should do the trick?