Skip to content

fix(nix): update npmDepsHash after package-lock.json change#934

Closed
brianmay with Copilot wants to merge 4 commits into
mainfrom
copilot/fix-failing-github-actions-job-tests
Closed

fix(nix): update npmDepsHash after package-lock.json change#934
brianmay with Copilot wants to merge 4 commits into
mainfrom
copilot/fix-failing-github-actions-job-tests

Conversation

Copilot AI commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

The CI tests job was failing due to a hash mismatch in the penguin_memories_assets-npm-deps Nix fixed-output derivation — the npm dependencies changed but the expected hash in flake.nix was not updated.

Change

  • Updated npmDepsHash in flake.nix to match the actual hash of the current package-lock.json:
# before
npmDepsHash = "sha256-Vyh93JxQpqmC1kCCuaoAEy8IlbckfmZ7CdQlQfbqisM=";

# after
npmDepsHash = "sha256-vXzOx7pSlV1QMQrRM77Jit1kVu6eQREAxU+ZWYxx3bQ=";

Copilot AI changed the title [WIP] Fix failing GitHub Actions job tests fix(nix): update npmDepsHash after package-lock.json change Jul 1, 2026
Copilot AI requested a review from brianmay July 1, 2026 22:51
The Nix build uses Elixir 1.20.2 whose type checker reports :oidcc as
"not loaded" for type inference. This causes:
1. Warnings for undefined Oidcc.Plug.* functions (promoted to errors by
   warnings_as_errors: true)
2. A hard type-checker error for the struct pattern %Token{id: %Token.Id{...}}

Fix by:
- Adding no_warn_undefined in mix.exs for oidcc/oidcc_plug Erlang apps and
  the specific Elixir modules that are flagged as undefined
- Replacing the struct pattern match with a generic map pattern
  %{id: %{claims: id_claims}} which is equivalent at runtime and avoids
  the type checker's struct verification"
The mixFodDeps hash in flake.nix was stale (from before the oidcc migration),
causing the Nix build to fetch old mix dependencies (still using plugoid).
Update to the correct hash that matches the new mix.lock with oidcc/oidcc_plug.

Also revert the incorrect no_warn_undefined workaround in mix.exs and the
weakened struct pattern in auth_controller.ex added in the previous session.
@brianmay

brianmay commented Jul 1, 2026

Copy link
Copy Markdown
Owner

Changes made outside this PR.

@brianmay brianmay closed this Jul 1, 2026
@brianmay brianmay deleted the copilot/fix-failing-github-actions-job-tests branch July 1, 2026 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants