Skip to content

Commit 4508b00

Browse files
elardus-erasmusbriansmith
authored andcommitted
CI: Give up debug builds and add beta builds in test jobs.
The `coverage` job already tests debug mode on Rust Nightly. We were still missing `beta` coverage, so add it. Also document this.
1 parent 2b1689f commit 4508b00

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

.github/workflows/ci.yml

+8-3
Original file line numberDiff line numberDiff line change
@@ -160,16 +160,19 @@ jobs:
160160
- x86_64-unknown-linux-gnu
161161

162162
mode:
163-
- # debug
163+
# XXX: `coverage` jobs build in debug mode.
164+
# - # debug
164165
- --release
165166

166167
rust_channel:
167168
- stable
168169
# Keep in sync with Cargo.toml and similar `rust_channel` sections.
169170
- 1.61.0 # MSRV
170-
# TODO: Move these to a daily/pre-release job.
171+
# Early warning for changes in the Rust toolchain that are about to
172+
# break builds on Rust Stable.
173+
- beta
174+
# XXX: `coverage` jobs run on Nightly.
171175
# - nightly
172-
# - beta
173176

174177
include:
175178
- target: aarch64-apple-darwin
@@ -539,10 +542,12 @@ jobs:
539542
- x86_64-unknown-linux-musl # Has assembly
540543

541544
mode:
545+
# This is the main coverage we have for debug mode builds.
542546
- # debug
543547

544548
# Coverage collection is Nightly-only
545549
rust_channel:
550+
# This is the main coverage we have for building with Rust Nightly.
546551
- nightly
547552

548553
# TODO: targets

0 commit comments

Comments
 (0)