Skip to content

Commit 9656352

Browse files
elardus-erasmusbriansmith
authored andcommitted
CI: Give up debug builds and add beta builds in test jobs.
The `coverage` job already tests debug mode on Rust Nightly. We were still missing `beta` coverage, so add it. Also document this.
1 parent 2b1689f commit 9656352

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

.github/workflows/ci.yml

+7-3
Original file line numberDiff line numberDiff line change
@@ -160,16 +160,18 @@ jobs:
160160
- x86_64-unknown-linux-gnu
161161

162162
mode:
163-
- # debug
163+
# `coverage` jobs build in debug mode, so only build in release mode here.
164164
- --release
165165

166166
rust_channel:
167167
- stable
168168
# Keep in sync with Cargo.toml and similar `rust_channel` sections.
169169
- 1.61.0 # MSRV
170-
# TODO: Move these to a daily/pre-release job.
170+
# Early warning for changes in the Rust toolchain that are about to
171+
# break builds on Rust Stable.
172+
- beta
173+
# XXX: `coverage` jobs run on Nightly.
171174
# - nightly
172-
# - beta
173175

174176
include:
175177
- target: aarch64-apple-darwin
@@ -539,10 +541,12 @@ jobs:
539541
- x86_64-unknown-linux-musl # Has assembly
540542

541543
mode:
544+
# This is the main coverage we have for debug mode builds.
542545
- # debug
543546

544547
# Coverage collection is Nightly-only
545548
rust_channel:
549+
# This is the main coverage we have for building with Rust Nightly.
546550
- nightly
547551

548552
# TODO: targets

0 commit comments

Comments
 (0)