Skip to content

Commit 250b6fa

Browse files
leogdionclaude
andcommitted
Address PR #26 review comments
- Update sersoft-gmbh/swift-coverage-action to v5, codecov-action to v6 - Comment out wasmtime-version in Ubuntu build - Use contains-code-coverage output from swift-build to gate coverage steps - Remove unused db identifier exclusion from swiftlint config - Delete Scripts/generate.sh Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent c8a7c81 commit 250b6fa

3 files changed

Lines changed: 13 additions & 13 deletions

File tree

.github/workflows/AviaryInsights.yml

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -86,23 +86,24 @@ jobs:
8686
type: wasm-embedded
8787
steps:
8888
- uses: actions/checkout@v4
89-
- uses: brightdigit/swift-build@v1
89+
- id: build
90+
uses: brightdigit/swift-build@v1
9091
with:
9192
type: ${{ matrix.type }}
92-
wasmtime-version: "40.0.2"
93+
# wasmtime-version: "40.0.2"
9394
wasm-swift-flags: >-
9495
-Xcc -D_WASI_EMULATED_SIGNAL
9596
-Xcc -D_WASI_EMULATED_MMAN
9697
-Xlinker -lwasi-emulated-signal
9798
-Xlinker -lwasi-emulated-mman
9899
- name: Process Coverage
99-
if: ${{ matrix.type == '' }}
100-
uses: sersoft-gmbh/swift-coverage-action@v4
100+
if: ${{ steps.build.outputs.contains-code-coverage == 'true' }}
101+
uses: sersoft-gmbh/swift-coverage-action@v5
101102
with:
102103
fail-on-empty-output: true
103104
- name: Upload coverage reports to Codecov
104-
if: ${{ matrix.type == '' }}
105-
uses: codecov/codecov-action@v4
105+
if: ${{ steps.build.outputs.contains-code-coverage == 'true' }}
106+
uses: codecov/codecov-action@v6
106107
with:
107108
token: ${{ secrets.CODECOV_TOKEN }}
108109
flags: spm,${{ matrix.os }},${{ matrix.swift.version }}
@@ -196,7 +197,8 @@ jobs:
196197

197198
steps:
198199
- uses: actions/checkout@v4
199-
- name: Build and Test
200+
- id: build
201+
name: Build and Test
200202
uses: brightdigit/swift-build@v1
201203
with:
202204
type: ${{ matrix.type }}
@@ -206,14 +208,16 @@ jobs:
206208
download-platform: ${{ matrix.download-platform }}
207209
scheme: ${{ env.PACKAGE_NAME }}
208210
- name: Process Coverage
209-
uses: sersoft-gmbh/swift-coverage-action@v4
211+
if: ${{ steps.build.outputs.contains-code-coverage == 'true' }}
212+
uses: sersoft-gmbh/swift-coverage-action@v5
210213
with:
211214
fail-on-empty-output: true
212215
search-paths: |
213216
./.build
214217
/Users/runner/work/_temp/DerivedData
215218
- name: Upload Coverage
216-
uses: codecov/codecov-action@v4
219+
if: ${{ steps.build.outputs.contains-code-coverage == 'true' }}
220+
uses: codecov/codecov-action@v6
217221
with:
218222
token: ${{ secrets.CODECOV_TOKEN }}
219223
flags: ${{ matrix.type && format('{0}{1}', matrix.type, matrix.osVersion) || 'spm' }}

.swiftlint.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@ closure_body_length:
113113
identifier_name:
114114
excluded:
115115
- id
116-
- db
117116
- no
118117
excluded:
119118
- DerivedData

Scripts/generate.sh

Lines changed: 0 additions & 3 deletions
This file was deleted.

0 commit comments

Comments
 (0)