Skip to content

Commit 95b6048

Browse files
committed
ci(SundialKit): rename App Store Connect key secret to *_BASE64
Both Fastlane lanes already pass is_key_content_base64: true, but the secret name APP_STORE_CONNECT_API_KEY_KEY was ambiguous about its encoding. Rename to APP_STORE_CONNECT_API_KEY_KEY_BASE64 in the workflow env blocks and Fastfile ENV reads so the contract is explicit and a new, freshly base64-encoded secret can be added without colliding with the old value. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 9abde5b commit 95b6048

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

.github/workflows/sundial-demo.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ jobs:
150150
FASTLANE_KEYCHAIN_PASSWORD: ${{ steps.keychain.outputs.password }}
151151
APP_STORE_CONNECT_API_KEY_KEY_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_KEY_ID }}
152152
APP_STORE_CONNECT_API_KEY_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_ISSUER_ID }}
153-
APP_STORE_CONNECT_API_KEY_KEY: ${{ secrets.APP_STORE_CONNECT_API_KEY_KEY }}
153+
APP_STORE_CONNECT_API_KEY_KEY_BASE64: ${{ secrets.APP_STORE_CONNECT_API_KEY_KEY_BASE64 }}
154154
DEVELOPMENT_TEAM: ${{ secrets.DEVELOPMENT_TEAM }}
155155

156156
- name: Upload Pulse IPA
@@ -205,7 +205,7 @@ jobs:
205205
env:
206206
APP_STORE_CONNECT_API_KEY_KEY_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_KEY_ID }}
207207
APP_STORE_CONNECT_API_KEY_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_ISSUER_ID }}
208-
APP_STORE_CONNECT_API_KEY_KEY: ${{ secrets.APP_STORE_CONNECT_API_KEY_KEY }}
208+
APP_STORE_CONNECT_API_KEY_KEY_BASE64: ${{ secrets.APP_STORE_CONNECT_API_KEY_KEY_BASE64 }}
209209

210210
- name: Increment build number and commit
211211
if: success()

Examples/Sundial/Fastlane/Fastfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ platform :ios do
3535
api_key = app_store_connect_api_key(
3636
key_id: ENV['APP_STORE_CONNECT_API_KEY_KEY_ID'],
3737
issuer_id: ENV['APP_STORE_CONNECT_API_KEY_ISSUER_ID'],
38-
key_content: ENV['APP_STORE_CONNECT_API_KEY_KEY'],
38+
key_content: ENV['APP_STORE_CONNECT_API_KEY_KEY_BASE64'],
3939
is_key_content_base64: true
4040
)
4141

@@ -113,7 +113,7 @@ platform :ios do
113113
api_key = app_store_connect_api_key(
114114
key_id: ENV['APP_STORE_CONNECT_API_KEY_KEY_ID'],
115115
issuer_id: ENV['APP_STORE_CONNECT_API_KEY_ISSUER_ID'],
116-
key_content: ENV['APP_STORE_CONNECT_API_KEY_KEY'],
116+
key_content: ENV['APP_STORE_CONNECT_API_KEY_KEY_BASE64'],
117117
is_key_content_base64: true
118118
)
119119

0 commit comments

Comments
 (0)