Fixing TestFlight Deployment (#65)

* fix(ci): add build processing validation and revert to build 2

- Revert build number to 2 (was incorrectly bumped without successful upload)
- Remove skip_waiting_for_build_processing to wait for Apple's validation
- Add wait_processing_timeout_duration: 1800 (30 min) for each app
- Add 90-minute timeout for deploy job to accommodate processing wait
- This will reveal any validation errors that caused build 2 to disappear

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* ci: temporarily add fix branch to deploy condition

* chore: bump build number to 3 [skip ci]

* fix(demo): use build settings for version numbers in Info.plist files

Replaces hardcoded CFBundleVersion and CFBundleShortVersionString values
with $(CURRENT_PROJECT_VERSION) and $(MARKETING_VERSION) respectively.
This allows CI to properly increment build numbers for TestFlight uploads.

Also resets build number to 2 since App Store Connect only has build 1.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* chore: bump build number to 3 [skip ci]

* fix(ci): remove temporary branch and gitignore generated plists [skip ci]

- Remove fix/build-2-upload-validation from deploy condition
- Add *.plist to gitignore for xcodegen-generated files
- Remove tracked Info.plist files (now auto-generated)
- Reset build number to 2

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Author: 3 people

.github/workflows/sundial-demo.yml

@@ -184,6 +184,7 @@ jobs:
     name: Deploy to TestFlight
     runs-on: macos-26
     needs: [archive-demo]
+    timeout-minutes: 90
     if: |
       (github.ref == 'refs/heads/v2.0.0' || github.ref == 'refs/heads/main') &&
       !contains(github.event.head_commit.message, '[skip ci]')

Examples/Sundial/.gitignore

@@ -4,3 +4,6 @@ Fastlane/report.xml
 Fastlane/test_output/
 Fastlane/.env*
 !Fastlane/.env.sample
+
+# XcodeGen generated
+*.plist

Examples/Sundial/Fastlane/Fastfile

@@ -43,7 +43,7 @@ platform :ios do
       upload_to_testflight(
         api_key: api_key,
         ipa: options[:pulse_ipa],
-        skip_waiting_for_build_processing: true
+        wait_processing_timeout_duration: 1800
       )
     end
 
@@ -52,7 +52,7 @@ platform :ios do
       upload_to_testflight(
         api_key: api_key,
         ipa: options[:flow_ipa],
-        skip_waiting_for_build_processing: true
+        wait_processing_timeout_duration: 1800
       )
     end
   end

Examples/Sundial/Resources/iOS/Info.plist

@@ -19,7 +19,7 @@ configFiles:
 settings:
   base:
     MARKETING_VERSION: "1.0.0"
-    CURRENT_PROJECT_VERSION: "3"
+    CURRENT_PROJECT_VERSION: "2"
     SWIFT_VERSION: "6.1"
     ENABLE_USER_SCRIPT_SANDBOXING: NO
 
@@ -52,6 +52,8 @@ targets:
     info:
       path: Resources/iOS/Info.plist
       properties:
+        CFBundleShortVersionString: $(MARKETING_VERSION)
+        CFBundleVersion: $(CURRENT_PROJECT_VERSION)
         UIApplicationSceneManifest:
           UIApplicationSupportsMultipleScenes: true
         LSRequiresIPhoneOS: true
@@ -108,6 +110,8 @@ targets:
     info:
       path: Resources/watchOS/Info-Combine.plist
       properties:
+        CFBundleShortVersionString: $(MARKETING_VERSION)
+        CFBundleVersion: $(CURRENT_PROJECT_VERSION)
         WKApplication: true
         WKCompanionAppBundleIdentifier: com.brightdigit.sundial.combine.ios
         UISupportedInterfaceOrientations:
@@ -157,6 +161,8 @@ targets:
     info:
       path: Resources/iOS/Info.plist
       properties:
+        CFBundleShortVersionString: $(MARKETING_VERSION)
+        CFBundleVersion: $(CURRENT_PROJECT_VERSION)
         UIApplicationSceneManifest:
           UIApplicationSupportsMultipleScenes: true
         LSRequiresIPhoneOS: true
@@ -213,6 +219,8 @@ targets:
     info:
       path: Resources/watchOS/Info-Stream.plist
       properties:
+        CFBundleShortVersionString: $(MARKETING_VERSION)
+        CFBundleVersion: $(CURRENT_PROJECT_VERSION)
         WKApplication: true
         WKCompanionAppBundleIdentifier: com.brightdigit.sundial.stream.ios
         UISupportedInterfaceOrientations: