Skip to content

Commit 254055f

Browse files
authored
Workaround for checkboxes without task (mod-playerbots#2116)
# Pull Request Describe what this change does and why it is needed... --- ## Design Philosophy We prioritize **stability, performance, and predictability** over behavioral realism. Complex player-mimicking logic is intentionally limited due to its negative impact on scalability, maintainability, and long-term robustness. Excessive processing overhead can lead to server hiccups, increased CPU usage, and degraded performance for all participants. Because every action and decision tree is executed **per bot and per trigger**, even small increases in logic complexity can scale poorly and negatively affect both players and world (random) bots. Bots are not expected to behave perfectly, and perfect simulation of human decision-making is not a project goal. Increased behavioral realism often introduces disproportionate cost, reduced predictability, and significantly higher maintenance overhead. Every additional branch of logic increases long-term responsibility. All decision paths must be tested, validated, and maintained continuously as the system evolves. If advanced or AI-intensive behavior is introduced, the **default configuration must remain the lightweight decision model**. More complex behavior should only be available as an **explicit opt-in option**, clearly documented as having a measurable performance cost. Principles: - **Stability before intelligence** A stable system is always preferred over a smarter one. - **Performance is a shared resource** Any increase in bot cost affects all players and all bots. - **Simple logic scales better than smart logic** Predictable behavior under load is more valuable than perfect decisions. - **Complexity must justify itself** If a feature cannot clearly explain its cost, it should not exist. - **Defaults must be cheap** Expensive behavior must always be optional and clearly communicated. - **Bots should look reasonable, not perfect** The goal is believable behavior, not human simulation. Before submitting, confirm that this change aligns with those principles. --- ## Feature Evaluation Please answer the following: - Describe the **minimum logic** required to achieve the intended behavior? - Describe the **cheapest implementation** that produces an acceptable result? - Describe the **runtime cost** when this logic executes across many bots? --- ## How to Test the Changes - Step-by-step instructions to test the change - Any required setup (e.g. multiple players, bots, specific configuration) - Expected behavior and how to verify it ## Complexity & Impact Does this change add new decision branches? ``` [ ] No [ ] Yes (**explain below**) ``` Does this change increase per-bot or per-tick processing? ``` [ ] No [ ] Yes (**describe and justify impact**) ``` Could this logic scale poorly under load? ``` [ ] No [ ] Yes (**explain why**) ``` --- ## Defaults & Configuration Does this change modify default bot behavior? ``` [ ] No [ ] Yes (**explain why**) ``` If this introduces more advanced or AI-heavy logic: ``` [ ] Lightweight mode remains the default [ ] More complex behavior is optional and thereby configurable ``` --- ## AI Assistance Was AI assistance (e.g. ChatGPT or similar tools) used while working on this change? ``` [ ] No [ ] Yes (**explain below**) ``` If yes, please specify: - AI tool or model used (e.g. ChatGPT, GPT-4, Claude, etc.) - Purpose of usage (e.g. brainstorming, refactoring, documentation, code generation) - Which parts of the change were influenced or generated - Whether the result was manually reviewed and adapted AI assistance is allowed, but all submitted code must be fully understood, reviewed, and owned by the contributor. Any AI-influenced changes must be verified against existing CORE and PB logic. We expect contributors to be honest about what they do and do not understand. --- ## Final Checklist - [ ] Stability is not compromised - [ ] Performance impact is understood, tested, and acceptable - [ ] Added logic complexity is justified and explained - [ ] Documentation updated if needed --- ## Notes for Reviewers Anything that significantly improves realism at the cost of stability or performance should be carefully discussed before merging.
1 parent 31765c7 commit 254055f

1 file changed

Lines changed: 16 additions & 28 deletions

File tree

PULL_REQUEST_TEMPLATE.md

Lines changed: 16 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -67,46 +67,34 @@ Please answer the following:
6767
## Complexity & Impact
6868

6969
Does this change add new decision branches?
70-
```
71-
[ ] No
72-
[ ] Yes (**explain below**)
73-
```
70+
- - [ ] No
71+
- - [ ] Yes (**explain below**)
7472

7573
Does this change increase per-bot or per-tick processing?
76-
```
77-
[ ] No
78-
[ ] Yes (**describe and justify impact**)
79-
```
74+
- - [ ] No
75+
- - [ ] Yes (**describe and justify impact**)
8076

8177
Could this logic scale poorly under load?
82-
```
83-
[ ] No
84-
[ ] Yes (**explain why**)
85-
```
78+
- - [ ] No
79+
- - [ ] Yes (**explain why**)
8680
---
8781

8882
## Defaults & Configuration
8983

9084
Does this change modify default bot behavior?
91-
```
92-
[ ] No
93-
[ ] Yes (**explain why**)
94-
```
85+
- - [ ] No
86+
- - [ ] Yes (**explain why**)
9587

9688
If this introduces more advanced or AI-heavy logic:
97-
```
98-
[ ] Lightweight mode remains the default
99-
[ ] More complex behavior is optional and thereby configurable
100-
```
89+
- - [ ] Lightweight mode remains the default
90+
- - [ ] More complex behavior is optional and thereby configurable
10191
---
10292

10393
## AI Assistance
10494

10595
Was AI assistance (e.g. ChatGPT or similar tools) used while working on this change?
106-
```
107-
[ ] No
108-
[ ] Yes (**explain below**)
109-
```
96+
- - [ ] No
97+
- - [ ] Yes (**explain below**)
11098

11199
If yes, please specify:
112100

@@ -123,10 +111,10 @@ about what they do and do not understand.
123111

124112
## Final Checklist
125113

126-
- [ ] Stability is not compromised
127-
- [ ] Performance impact is understood, tested, and acceptable
128-
- [ ] Added logic complexity is justified and explained
129-
- [ ] Documentation updated if needed
114+
- - [ ] Stability is not compromised
115+
- - [ ] Performance impact is understood, tested, and acceptable
116+
- - [ ] Added logic complexity is justified and explained
117+
- - [ ] Documentation updated if needed
130118

131119
---
132120

0 commit comments

Comments
 (0)