Merge pull request mod-playerbots#2191 from mod-playerbots/test-staging

Test staging to master

Author: kadeshar

.github/workflows/check_pr_source.yml

@@ -2,6 +2,7 @@ name: Enforce test-staging → master
 
 on:
   pull_request:
+    types: [opened, synchronize, reopened, edited]
     branches:
       - master
       - test-staging

PULL_REQUEST_TEMPLATE.md

@@ -1,124 +1,103 @@
-# Pull Request
+<!--
+Thank you for contributing to mod-playerbots, please make sure that you...
+1. Submit your PR to the test-staging branch, not master.
+2. Read the guidelines below before submitting.
+3. Don't delete parts of this template.
 
-Describe what this change does and why it is needed...
+DESIGN PHILOSOPHY: We prioritize STABILITY, PERFORMANCE, AND PREDICTABILITY over behavioral realism.
 
----
+Every action and decision executes PER BOT AND PER TRIGGER. Small increases in logic complexity scale
+poorly across thousands of bots and negatively affect all. We prioritize a stable system over a smarter
+one. Bots don't need to behave perfectly; believable behavior is the goal, not human simulation.
+Default behavior must be cheap in processing; expensive behavior must be opt-in.
 
-## Design Philosophy
+Before submitting, make sure your changes aligns with these principles.
+-->
 
-We prioritize **stability, performance, and predictability** over behavioral realism.  
-Complex player-mimicking logic is intentionally limited due to its negative impact on scalability, maintainability, and
-long-term robustness.
+## Pull Request Description
+<!-- Describe what this change does and why it is needed -->
 
-Excessive processing overhead can lead to server hiccups, increased CPU usage, and degraded performance for all
-participants. Because every action and
-decision tree is executed **per bot and per trigger**, even small increases in logic complexity can scale poorly and
-negatively affect both players and
-world (random) bots. Bots are not expected to behave perfectly, and perfect simulation of human decision-making is not a
-project goal. Increased behavioral
-realism often introduces disproportionate cost, reduced predictability, and significantly higher maintenance overhead.
 
-Every additional branch of logic increases long-term responsibility. All decision paths must be tested, validated, and
-maintained continuously as the system evolves.
-If advanced or AI-intensive behavior is introduced, the **default configuration must remain the lightweight decision
-model**. More complex behavior should only be
-available as an **explicit opt-in option**, clearly documented as having a measurable performance cost.
 
-Principles:
-
-- **Stability before intelligence**  
-  A stable system is always preferred over a smarter one.
-
-- **Performance is a shared resource**  
-  Any increase in bot cost affects all players and all bots.
-
-- **Simple logic scales better than smart logic**  
-  Predictable behavior under load is more valuable than perfect decisions.
-
-- **Complexity must justify itself**  
-  If a feature cannot clearly explain its cost, it should not exist.
+## Feature Evaluation
+<!--
+If your PR is very minimal (comment typo, wrong ID reference, etc), and it is very obvious it will not have
+any impact on performance, you may skip these question. If necessary, a maintainer may ask you for them later.
+-->
 
-- **Defaults must be cheap**  
-  Expensive behavior must always be optional and clearly communicated.
+<!-- Please answer the following: -->
+- Describe the **minimum logic** required to achieve the intended behavior.
+- Describe the **processing cost** when this logic executes across many bots.
 
-- **Bots should look reasonable, not perfect**  
-  The goal is believable behavior, not human simulation.
 
-Before submitting, confirm that this change aligns with those principles.
 
----
+## How to Test the Changes
+<!--
+- Step-by-step instructions to test the change.
+- Any required setup (e.g. multiple players, number of bots, specific configuration).
+- Expected behavior and how to verify it.
+-->
 
-## Feature Evaluation
 
-Please answer the following:
 
-- Describe the **minimum logic** required to achieve the intended behavior?
-- Describe the **cheapest implementation** that produces an acceptable result?
-- Describe the **runtime cost** when this logic executes across many bots?
+## Impact Assessment
+<!-- As a generic test, before and after measure of pmon (playerbot pmon tick) can help you here. -->
+- Does this change increase per-bot/per-tick processing or risk scaling poorly with thousands of bots?
+    - [ ] No, not at all
+    - [ ] Minimal impact (**explain below**)
+    - [ ] Moderate impact (**explain below**)
 
----
 
-## How to Test the Changes
 
-- Step-by-step instructions to test the change
-- Any required setup (e.g. multiple players, bots, specific configuration)
-- Expected behavior and how to verify it
+- Does this change modify default bot behavior?
+    - [ ] No
+    - [ ] Yes (**explain why**)
 
-## Complexity & Impact
 
-Does this change add new decision branches?
-- - [ ] No
-- - [ ] Yes (**explain below**)
 
-Does this change increase per-bot or per-tick processing?
-- - [ ] No
-- - [ ] Yes (**describe and justify impact**)
+- Does this change add new decision branches or increase maintenance complexity?
+    - [ ] No
+    - [ ] Yes (**explain below**)
 
-Could this logic scale poorly under load?
-- - [ ] No
-- - [ ] Yes (**explain why**)
----
 
-## Defaults & Configuration
 
-Does this change modify default bot behavior?
-- - [ ] No
-- - [ ] Yes (**explain why**)
+## Messages to Translate
+<!--
+Bot messages have to be translatable, but you don't need to do the translations here. You only need to make sure
+the message is in a translatable format, and list in the table the message_key and the default English message.
+Search for GetBotTextOrDefault in the codebase for examples.
+-->
+Does this change add bot messages to translate?
+- [ ] No
+- [ ] Yes (**list messages in the table**)
 
-If this introduces more advanced or AI-heavy logic:
-- - [ ] Lightweight mode remains the default
-- - [ ] More complex behavior is optional and thereby configurable
----
+| Message key  | Default message |
+| --------------- | ------------------ |
+|			 |			      |
+|			 |			      |
 
 ## AI Assistance
-
-Was AI assistance (e.g. ChatGPT or similar tools) used while working on this change?
-- - [ ] No
-- - [ ] Yes (**explain below**)
-
+<!--
+AI assistance is allowed, but all submitted code must be fully understood, reviewed, and owned by the contributor.
+We expect contributors to be honest about what they do and do not understand.
+-->
+Was AI assistance used while working on this change?
+- [ ] No
+- [ ] Yes (**explain below**)
+<!--
 If yes, please specify:
+- Purpose of usage (e.g. brainstorming, refactoring, documentation, code generation).
+- Which parts of the change were influenced or generated, and whether it was thoroughly reviewed.
+-->
 
-- AI tool or model used (e.g. ChatGPT, GPT-4, Claude, etc.)
-- Purpose of usage (e.g. brainstorming, refactoring, documentation, code generation)
-- Which parts of the change were influenced or generated
-- Whether the result was manually reviewed and adapted
 
-AI assistance is allowed, but all submitted code must be fully understood, reviewed, and owned by the contributor.
-Any AI-influenced changes must be verified against existing CORE and PB logic. We expect contributors to be honest
-about what they do and do not understand.
-
----
 
 ## Final Checklist
 
-- - [ ] Stability is not compromised
-- - [ ] Performance impact is understood, tested, and acceptable
-- - [ ] Added logic complexity is justified and explained
-- - [ ] Documentation updated if needed
-
----
+- [ ] Stability is not compromised.
+- [ ] Performance impact is understood, tested, and acceptable.
+- [ ] Added logic complexity is justified and explained.
+- [ ] Documentation updated if needed (Conf comments, WiKi commands).
 
 ## Notes for Reviewers
-
-Anything that significantly improves realism at the cost of stability or performance should be carefully discussed
-before merging.
+<!-- Anything else that's helpful to review or test your pull request. -->

conf/playerbots.conf.dist

@@ -566,7 +566,10 @@ AiPlayerbot.AutoGearScoreLimit = 0
 # Default: food, taxi, and raid are enabled
 AiPlayerbot.BotCheats = "food,taxi,raid"
 
-# Attunement quests (comma-separated list of quest IDs)
+# List of attunement quests (comma-separated list of quest IDs) that are automatically completed for all bots.  
+# While mod-playerbots does not restore removed attunement requirements, although other mods, such as mod-individual-progression, may do so.
+# This is meant to exclude bots from such requirements.
+# 
 # Default:
 # Caverns of Time - Part 1
 # - 10279, To The Master's Lair
@@ -592,7 +595,17 @@ AiPlayerbot.BotCheats = "food,taxi,raid"
 #
 # Serpentshrine Cavern
 # - 10901, The Cudgel of Kar'desh
-AiPlayerbot.AttunementQuests = 10279,10277,10282,10283,10284,10285,10296,10297,10298,11481,11482,11488,11490,11492,10901
+#
+# The Eye
+# - 10888, Trial of the Naaru: Magtheridon
+#
+# Mount Hyjal
+# - 10445, The Vials of Eternity
+#
+# Black Temple
+# - 10985, A Distraction for Akama
+#
+AiPlayerbot.AttunementQuests = 10279,10277,10282,10283,10284,10285,10296,10297,10298,11481,11482,11488,11490,11492,10901,10888,10445,10985
 
 #
 #
@@ -796,6 +809,10 @@ AiPlayerbot.LimitGearExpansion = 1
 # Set between 0 (0%) and 1 (100%)
 AiPlayerbot.RandomGearLoweringChance = 0
 
+# Unobtainable or unusable items (comma-separated list of item IDs)
+# Default: Chilton Wand (12468), Totem of the Earthen Ring (46978)
+AiPlayerbot.UnobtainableItems = 12468,46978
+
 # Randombots check player's gearscore level and deny the group invitation if it's too low
 # Default: 0 (disabled)
 AiPlayerbot.GearScoreCheck = 0
@@ -2213,4 +2230,4 @@ AiPlayerbot.SummonAtInnkeepersEnabled = 1
 # 30% more damage, 40% damage reduction (tank bots), increased all resistances, reduced threat for non tank bots, increased threat for tank bots.
 # Buffs will be applied on PP, Sindragosa and Lich King
 
-AiPlayerbot.EnableICCBuffs = 1
+AiPlayerbot.EnableICCBuffs = 1

data/sql/playerbots/updates/2026_02_13_00_ai_playerbot_texts.sql

@@ -0,0 +1 @@
+UPDATE `ai_playerbot_texts` SET `text_loc3`='%s, du hörst den triefenden Sarkasmus in meinem text nicht' WHERE `id`=1353;

src/Ai/Base/Actions/ChatShortcutActions.cpp

@@ -237,6 +237,20 @@ bool MaxDpsChatShortcutAction::Execute(Event /*event*/)
     return true;
 }
 
+bool NaxxChatShortcutAction::Execute(Event /*event*/)
+{
+    Player* master = GetMaster();
+    if (!master)
+        return false;
+
+    botAI->Reset();
+    botAI->ChangeStrategy("+naxx", BOT_STATE_NON_COMBAT);
+    botAI->ChangeStrategy("+naxx", BOT_STATE_COMBAT);
+    botAI->TellMasterNoFacing("Add Naxx Strategies!");
+    // bot->Say("Add Naxx Strategies!", LANG_UNIVERSAL);
+    return true;
+}
+
 bool BwlChatShortcutAction::Execute(Event /*event*/)
 {
     Player* master = GetMaster();

src/Ai/Base/Actions/ChatShortcutActions.h

@@ -85,6 +85,13 @@ class MaxDpsChatShortcutAction : public Action
     bool Execute(Event event) override;
 };
 
+class NaxxChatShortcutAction : public Action
+{
+public:
+    NaxxChatShortcutAction(PlayerbotAI* ai) : Action(ai, "naxx chat shortcut") {}
+    virtual bool Execute(Event event);
+};
+
 class BwlChatShortcutAction : public Action
 {
 public:

src/Ai/Base/Actions/MovementActions.cpp

@@ -854,14 +854,19 @@ float MovementAction::GetFollowAngle()
     if (!group)
         return 0.0f;
 
+    // Prevent bots with orphaned raid groups from dividing by 0, which freezes the server.
+    uint32 memberCount = group->GetMembersCount();
+    if (memberCount <= 1)
+        return 0.0f;
+
     uint32 index = 1;
     for (GroupReference* ref = group->GetFirstMember(); ref; ref = ref->next())
     {
         if (ref->GetSource() == master)
             continue;
 
         if (ref->GetSource() == bot)
-            return 2 * M_PI / (group->GetMembersCount() - 1) * index;
+            return 2 * M_PI / (memberCount - 1) * index;
 
         ++index;
     }

src/Ai/Base/ChatActionContext.h

@@ -187,6 +187,7 @@ class ChatActionContext : public NamedObjectContext<Action>
         creators["guild leave"] = &ChatActionContext::guild_leave;
         creators["rtsc"] = &ChatActionContext::rtsc;
         creators["bwl chat shortcut"] = &ChatActionContext::bwl_chat_shortcut;
+        creators["naxx chat shortcut"] = &ChatActionContext::naxx_chat_shortcut;
         creators["tell estimated dps"] = &ChatActionContext::tell_estimated_dps;
         creators["join"] = &ChatActionContext::join;
         creators["lfg"] = &ChatActionContext::lfg;
@@ -298,6 +299,7 @@ class ChatActionContext : public NamedObjectContext<Action>
     static Action* guild_remove(PlayerbotAI* botAI) { return new GuildRemoveAction(botAI); }
     static Action* guild_leave(PlayerbotAI* botAI) { return new GuildLeaveAction(botAI); }
     static Action* rtsc(PlayerbotAI* botAI) { return new RTSCAction(botAI); }
+    static Action* naxx_chat_shortcut(PlayerbotAI* ai) { return new NaxxChatShortcutAction(ai); }
     static Action* bwl_chat_shortcut(PlayerbotAI* ai) { return new BwlChatShortcutAction(ai); }
     static Action* tell_estimated_dps(PlayerbotAI* ai) { return new TellEstimatedDpsAction(ai); }
     static Action* join(PlayerbotAI* ai) { return new JoinGroupAction(ai); }

src/Ai/Base/ChatTriggerContext.h

@@ -127,7 +127,6 @@ class ChatTriggerContext : public NamedObjectContext<Trigger>
         creators["guild leave"] = &ChatTriggerContext::guild_leave;
         creators["rtsc"] = &ChatTriggerContext::rtsc;
         creators["drink"] = &ChatTriggerContext::drink;
-        // creators["bwl"] = &ChatTriggerContext::bwl;
         creators["dps"] = &ChatTriggerContext::dps;
         creators["disperse"] = &ChatTriggerContext::disperse;
         creators["calc"] = &ChatTriggerContext::calc;
@@ -245,7 +244,6 @@ class ChatTriggerContext : public NamedObjectContext<Trigger>
     static Trigger* guild_leave(PlayerbotAI* botAI) { return new ChatCommandTrigger(botAI, "guild leave"); }
     static Trigger* rtsc(PlayerbotAI* botAI) { return new ChatCommandTrigger(botAI, "rtsc"); }
     static Trigger* drink(PlayerbotAI* ai) { return new ChatCommandTrigger(ai, "drink"); }
-    // static Trigger* bwl(PlayerbotAI* ai) { return new ChatCommandTrigger(ai, "bwl"); }
     static Trigger* dps(PlayerbotAI* ai) { return new ChatCommandTrigger(ai, "dps"); }
     static Trigger* disperse(PlayerbotAI* ai) { return new ChatCommandTrigger(ai, "disperse"); }
     static Trigger* calc(PlayerbotAI* ai) { return new ChatCommandTrigger(ai, "calc"); }

src/Ai/Base/Strategy/ChatCommandHandlerStrategy.cpp

@@ -83,6 +83,8 @@ void ChatCommandHandlerStrategy::InitTriggers(std::vector<TriggerNode*>& trigger
         new TriggerNode("target", { NextAction("tell target", relevance) }));
     triggers.push_back(
         new TriggerNode("ready", { NextAction("ready check", relevance) }));
+    triggers.push_back(
+        new TriggerNode("naxx", {NextAction("naxx chat shortcut", relevance)}));
     triggers.push_back(
         new TriggerNode("bwl", { NextAction("bwl chat shortcut", relevance) }));
     triggers.push_back(