Skip to content

Commit ca3b62c

Browse files
Remove VCF identifier input to PlotSVCountsPerSample for Terra (#224)
1 parent 4c0d89f commit ca3b62c

File tree

6 files changed

+9
-16
lines changed

6 files changed

+9
-16
lines changed

input_templates/terra_workspaces/cohort_mode/workflow_configurations/PlotSVCountsPerSample.json.tmpl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,5 @@
44
"PlotSVCountsPerSample.N_IQR_cutoff": "6",
55

66
"PlotSVCountsPerSample.prefix": "${this.sample_set_id}",
7-
"PlotSVCountsPerSample.vcfs" : "${[this.sites_filtered_manta_vcf, this.sites_filtered_delly_vcf, this.sites_filtered_wham_vcf, this.sites_filtered_melt_vcf, this.sites_filtered_depth_vcf]}",
8-
"PlotSVCountsPerSample.vcf_identifiers" : "${this.algorithms_filtersites}"
7+
"PlotSVCountsPerSample.vcfs" : "${[this.sites_filtered_manta_vcf, this.sites_filtered_delly_vcf, this.sites_filtered_wham_vcf, this.sites_filtered_melt_vcf, this.sites_filtered_depth_vcf]}"
98
}

test_input_templates/FilterBatch/PlotSVCountsPerSample.json.tmpl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,5 @@
99
{{ test_batch.sites_filtered_wham_vcf | tojson }},
1010
{{ test_batch.sites_filtered_melt_vcf | tojson }},
1111
{{ test_batch.sites_filtered_depth_vcf | tojson }}
12-
],
13-
"PlotSVCountsPerSample.vcf_identifiers" : ["manta", "wham", "melt", "depth"]
12+
]
1413
}

test_input_templates/FilterOutlierSamples/PlotSVCountsPerSample.json.tmpl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,5 @@
66
"PlotSVCountsPerSample.prefix": {{ test_batch.batch_name | tojson }},
77
"PlotSVCountsPerSample.vcfs" : [
88
{{ test_batch.baseline_final_vcf | tojson }}
9-
],
10-
"PlotSVCountsPerSample.vcf_identifiers" : ["cohort_outlier_filtered"]
9+
]
1110
}

wdl/FilterBatch.wdl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ workflow FilterBatch {
6969
input:
7070
prefix = batch,
7171
vcfs = [FilterBatchSites.sites_filtered_manta_vcf, FilterBatchSites.sites_filtered_delly_vcf, FilterBatchSites.sites_filtered_wham_vcf, FilterBatchSites.sites_filtered_melt_vcf, FilterBatchSites.sites_filtered_depth_vcf],
72-
vcf_identifiers = FilterBatchSites.algorithms_filtersites,
7372
N_IQR_cutoff = outlier_cutoff_nIQR,
7473
sv_pipeline_docker = sv_pipeline_docker,
7574
runtime_attr_count_svs = runtime_attr_count_svs,

wdl/FilterBatchSites.wdl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ workflow FilterBatchSites {
6767
File cutoffs = AdjudicateSV.cutoffs
6868
File scores = RewriteScores.updated_scores
6969
File RF_intermediate_files = AdjudicateSV.RF_intermediate_files
70-
Array[String] algorithms_filtersites = algorithms
7170
}
7271
}
7372

wdl/PlotSVCountsPerSample.wdl

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,22 +7,20 @@ workflow PlotSVCountsPerSample {
77
input {
88
String prefix
99
Array[File?] vcfs # in order of vcf_identifiers array. To skip one, use null keyword
10-
Array[String] vcf_identifiers # VCF identifiers - could be algorithms like manta, wham, etc or pesr, depth or just cohort VCF
1110
Int N_IQR_cutoff
1211
String sv_pipeline_docker
1312
RuntimeAttr? runtime_attr_count_svs
1413
RuntimeAttr? runtime_attr_plot_svcounts
1514
RuntimeAttr? runtime_attr_cat_outliers_preview
1615
}
1716

18-
Int num_identifiers = length(vcf_identifiers)
19-
20-
scatter (i in range(num_identifiers)) {
21-
if (defined(vcfs[i])) {
17+
scatter (vcf in vcfs) {
18+
if (defined(vcf)) {
19+
String vcf_name = basename(select_first([vcf]), ".vcf.gz")
2220
call CountSVsPerSamplePerType {
2321
input:
24-
vcf = select_first([vcfs[i]]),
25-
prefix = "~{prefix}.~{vcf_identifiers[i]}",
22+
vcf = select_first([vcf]),
23+
prefix = vcf_name,
2624
sv_pipeline_docker = sv_pipeline_docker,
2725
runtime_attr_override = runtime_attr_count_svs
2826
}
@@ -31,7 +29,7 @@ workflow PlotSVCountsPerSample {
3129
input:
3230
svcounts = CountSVsPerSamplePerType.sv_counts,
3331
n_iqr_cutoff = N_IQR_cutoff,
34-
prefix = "~{prefix}.~{vcf_identifiers[i]}",
32+
prefix = vcf_name,
3533
sv_pipeline_docker = sv_pipeline_docker,
3634
runtime_attr_override = runtime_attr_plot_svcounts
3735
}

0 commit comments

Comments
 (0)