Merge pull request #2281 from broadinstitute/jb-feature-announcement-slug

Use latest published date for feature announcement slug (SCP-5759)

Author: bistline

app/models/feature_announcement.rb

@@ -70,9 +70,19 @@ def record_latest_event
   private
 
   def set_slug
-    if new_record? || title_changed? && !published
-      today = created_at.nil? ? Time.zone.today : created_at
-      self.slug = "#{today.strftime('%F')}-#{title.downcase.gsub(/[^a-zA-Z0-9]+/, '-').chomp('-')}"
+    if published
+      published_date = history[:published] || Date.today
+      # determine if we have an existing title slug we need to preserve
+      # this prevents published links from breaking when the title changes
+      # NOTE: unpublishing a feature will always break any published links
+      if new_record? || slug&.starts_with?('unpublished-')
+        title_entry = title.downcase.gsub(/[^a-zA-Z0-9]+/, '-')
+      else
+        title_entry = slug.split('-')[3..].join('-')
+      end
+      self.slug = "#{published_date.strftime('%F')}-#{title_entry.chomp('-')}"
+    else
+      self.slug = "unpublished-#{id}"
     end
   end
 end

test/models/feature_announcement_test.rb

@@ -21,18 +21,19 @@ class FeatureAnnouncementTest< ActiveSupport::TestCase
     FeatureAnnouncement.update_all(published: true, archived: false)
   end
 
-  test 'should set slug on save until published' do
+  test 'should set slug on save when published' do
     feature = FeatureAnnouncement.create(
       title: 'Unpublished Feature',
       content: '<p>This is the content.</p>',
       doc_link: 'https://singlecell.zendesk.com/hc/en-us',
+      created_at: Date.today.in_time_zone - 1.day,
       published: false,
       archived: false
     )
-    assert_equal "#{@today}-unpublished-feature", feature.slug
+    assert_equal "unpublished-#{feature.id}", feature.slug
     feature.update(title: 'Announcing a New Feature!!')
     feature.reload
-    assert_equal "#{@today}-announcing-a-new-feature", feature.slug
+    assert_equal "unpublished-#{feature.id}", feature.slug
     feature.update(published: true)
     feature.reload
     assert_equal "#{@today}-announcing-a-new-feature", feature.slug