Merge pull request #2230 from broadinstitute/jb-pairwise-de-bugfix

Stop forcing isAuthorDe on pairwise results (SCP-5967)

Author: bistline

app/javascript/components/explore/DifferentialExpressionPanel.jsx

@@ -762,6 +762,7 @@ export default function DifferentialExpressionPanel({
           countsByLabelForDe={countsByLabelForDe}
           deObjects={deObjects}
           setDeFilePath={setDeFilePath}
+          isAuthorDe={isAuthorDe}
           deGroupB={deGroupB}
           setDeGroupB={setDeGroupB}
           hasOneVsRestDe={hasOneVsRestDe}
@@ -851,7 +852,7 @@ export default function DifferentialExpressionPanel({
           bucketId={bucketId}
           deFilePath={deFilePath}
           handleClear={handleClear}
-          isAuthorDe={hasPairwiseDe}
+          isAuthorDe={isAuthorDe}
           sizeMetric={sizeMetric}
           significanceMetric={significanceMetric}
           deFacets={deFacets}

app/javascript/components/visualization/controls/DifferentialExpressionGroupPicker.jsx

@@ -320,7 +320,7 @@ export function PairwiseDifferentialExpressionGroupLists({
 export function PairwiseDifferentialExpressionGroupPicker({
   bucketId, clusterName, annotation, deGenes, deGroup, setDeGroup,
   setDeGenes, countsByLabelForDe, deObjects, setDeFilePath,
-  deGroupB, setDeGroupB, hasOneVsRestDe, significanceMetric
+  deGroupB, setDeGroupB, hasOneVsRestDe, significanceMetric, isAuthorDe
 }) {
   const groups = getLegendSortedLabels(countsByLabelForDe)
 
@@ -343,7 +343,6 @@ export function PairwiseDifferentialExpressionGroupPicker({
 
     setDeFilePath(deFilePath)
 
-    const isAuthorDe = true // SCP doesn't currently automatically compute pairwise DE
     const deGenes = await fetchDeGenes(bucketId, deFilePath, isAuthorDe)
     setDeGenes(deGenes)
   }
@@ -441,7 +440,6 @@ export function OneVsRestDifferentialExpressionGroupPicker({
     const deFilePath = basePath + deFileName
 
     setDeFilePath(deFilePath)
-
     const deGenes = await fetchDeGenes(bucketId, deFilePath, isAuthorDe)
 
     setDeGroup(newGroup)