Skip to content

Commit 7358c66

Browse files
authored
Merge branch 'main' into add-google-cloud-sdk
2 parents 309b0fb + 97e111f commit 7358c66

17 files changed

+24
-857
lines changed

AGENTS.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -428,6 +428,8 @@ The `docs.yml` workflow builds Sphinx documentation. Key points:
428428

429429
**Explicit requests**: Include agent attribution in commits or elsewhere when explicitly requested by a human reviewer or contributor.
430430

431+
**Avoid amending pushed commits**: Do not use `git commit --amend` after a commit has been pushed to the remote. Amending pushed commits causes problems for collaboration. Instead, create a new commit with the fix. Amending is fine for local commits that haven't been pushed yet.
432+
431433
### Test-Driven Development
432434

433435
1. Write tests first

docker/Dockerfile.assemble

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,10 @@ LABEL org.opencontainers.image.source="https://github.com/broadinstitute/viral-n
1818
# Enable conda environment activation for RUN commands
1919
ARG MAMBA_DOCKERFILE_ACTIVATE=1
2020

21+
# Workaround: add sequip lib directory to PERL5LIB
22+
# NOTE: sequip version here must match the version in requirements/assemble.txt
23+
ENV PERL5LIB=$PERL5LIB:/opt/conda/share/sequip-0.11/lib
24+
2125
# Copy requirements and dependency installation script
2226
COPY docker/requirements/baseimage.txt docker/requirements/core.txt docker/requirements/assemble.txt /tmp/requirements/
2327
COPY docker/install-conda-deps.sh /tmp/
@@ -28,7 +32,6 @@ RUN /tmp/install-conda-deps.sh /tmp/requirements/baseimage.txt /tmp/requirements
2832

2933
# Copy source code (includes assembly module)
3034
COPY src/ /opt/viral-ngs/source/src/
31-
COPY scripts/ /opt/viral-ngs/source/scripts/
3235
COPY pyproject.toml README.md LICENSE /opt/viral-ngs/source/
3336

3437
# Install viral-ngs package

docker/Dockerfile.classify

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ RUN /tmp/install-conda-deps.sh /tmp/requirements/baseimage.txt /tmp/requirements
3030

3131
# Copy source code (includes classify module)
3232
COPY src/ /opt/viral-ngs/source/src/
33-
COPY scripts/ /opt/viral-ngs/source/scripts/
3433
COPY pyproject.toml README.md LICENSE /opt/viral-ngs/source/
3534

3635
# Install viral-ngs package

docker/Dockerfile.core

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ RUN /tmp/install-conda-deps.sh /tmp/requirements/baseimage.txt /tmp/requirements
3030
COPY src/ /opt/viral-ngs/source/src/
3131
COPY pyproject.toml README.md LICENSE /opt/viral-ngs/source/
3232

33+
# Copy utility scripts
34+
COPY docker/scripts/ /opt/viral-ngs/scripts/
35+
3336
# Install viral-ngs package
3437
# VERSION is passed from GitHub Actions via git describe
3538
WORKDIR /opt/viral-ngs/source

docker/Dockerfile.mega

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ RUN /tmp/install-conda-deps.sh /tmp/requirements/baseimage.txt /tmp/requirements
3131

3232
# Copy source code (includes all modules)
3333
COPY src/ /opt/viral-ngs/source/src/
34-
COPY scripts/ /opt/viral-ngs/source/scripts/
3534
COPY pyproject.toml README.md LICENSE /opt/viral-ngs/source/
3635

3736
# Install viral-ngs package

docker/Dockerfile.phylo

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ RUN /tmp/install-conda-deps.sh /tmp/requirements/baseimage.txt /tmp/requirements
3030

3131
# Copy source code (includes phylo module)
3232
COPY src/ /opt/viral-ngs/source/src/
33-
COPY scripts/ /opt/viral-ngs/source/scripts/
3433
COPY pyproject.toml README.md LICENSE /opt/viral-ngs/source/
3534

3635
# Install viral-ngs package
File renamed without changes.

scripts/add_base_class_imports.py

Lines changed: 0 additions & 83 deletions
This file was deleted.

scripts/fix_module_usages.py

Lines changed: 0 additions & 65 deletions
This file was deleted.

scripts/fix_test_usages.py

Lines changed: 0 additions & 70 deletions
This file was deleted.

0 commit comments

Comments
 (0)