Skip to content

Commit dbb268f

Browse files
committed
Remove unnecessary GHCR auth from test jobs
GHCR public images can be pulled without authentication, so the docker/login-action steps in test jobs are unnecessary and can cause transient failures due to network timeouts. Removed from: test-core, test-core-arm64, test-assemble, test-assemble-arm64, test-classify, test-classify-arm64, test-phylo, test-phylo-arm64
1 parent 2f15ff2 commit dbb268f

File tree

1 file changed

+16
-56
lines changed

1 file changed

+16
-56
lines changed

.github/workflows/docker.yml

Lines changed: 16 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -1075,18 +1075,13 @@ jobs:
10751075
runs-on: ubuntu-latest
10761076
permissions:
10771077
contents: read
1078-
packages: read
1078+
# packages: read not needed - GHCR public images can be pulled without auth
10791079

10801080
steps:
10811081
- name: Checkout repository
10821082
uses: actions/checkout@v4
10831083

1084-
- name: Log in to GitHub Container Registry
1085-
uses: docker/login-action@v3
1086-
with:
1087-
registry: ghcr.io
1088-
username: ${{ github.actor }}
1089-
password: ${{ secrets.GITHUB_TOKEN }}
1084+
# No GHCR login needed - public images can be pulled without authentication
10901085

10911086
- name: Run core tests
10921087
run: |
@@ -1118,18 +1113,13 @@ jobs:
11181113
runs-on: ubuntu-24.04-arm
11191114
permissions:
11201115
contents: read
1121-
packages: read
1116+
# packages: read not needed - GHCR public images can be pulled without auth
11221117

11231118
steps:
11241119
- name: Checkout repository
11251120
uses: actions/checkout@v4
11261121

1127-
- name: Log in to GitHub Container Registry
1128-
uses: docker/login-action@v3
1129-
with:
1130-
registry: ghcr.io
1131-
username: ${{ github.actor }}
1132-
password: ${{ secrets.GITHUB_TOKEN }}
1122+
# No GHCR login needed - public images can be pulled without authentication
11331123

11341124
- name: Run core tests (ARM64)
11351125
run: |
@@ -1148,18 +1138,13 @@ jobs:
11481138
runs-on: ubuntu-latest
11491139
permissions:
11501140
contents: read
1151-
packages: read
1141+
# packages: read not needed - GHCR public images can be pulled without auth
11521142

11531143
steps:
11541144
- name: Checkout repository
11551145
uses: actions/checkout@v4
11561146

1157-
- name: Log in to GitHub Container Registry
1158-
uses: docker/login-action@v3
1159-
with:
1160-
registry: ghcr.io
1161-
username: ${{ github.actor }}
1162-
password: ${{ secrets.GITHUB_TOKEN }}
1147+
# No GHCR login needed - public images can be pulled without authentication
11631148

11641149
- name: Run assemble tests
11651150
run: |
@@ -1191,18 +1176,13 @@ jobs:
11911176
runs-on: ubuntu-24.04-arm
11921177
permissions:
11931178
contents: read
1194-
packages: read
1179+
# packages: read not needed - GHCR public images can be pulled without auth
11951180

11961181
steps:
11971182
- name: Checkout repository
11981183
uses: actions/checkout@v4
11991184

1200-
- name: Log in to GitHub Container Registry
1201-
uses: docker/login-action@v3
1202-
with:
1203-
registry: ghcr.io
1204-
username: ${{ github.actor }}
1205-
password: ${{ secrets.GITHUB_TOKEN }}
1185+
# No GHCR login needed - public images can be pulled without authentication
12061186

12071187
- name: Run assemble tests (ARM64)
12081188
run: |
@@ -1221,18 +1201,13 @@ jobs:
12211201
runs-on: ubuntu-latest
12221202
permissions:
12231203
contents: read
1224-
packages: read
1204+
# packages: read not needed - GHCR public images can be pulled without auth
12251205

12261206
steps:
12271207
- name: Checkout repository
12281208
uses: actions/checkout@v4
12291209

1230-
- name: Log in to GitHub Container Registry
1231-
uses: docker/login-action@v3
1232-
with:
1233-
registry: ghcr.io
1234-
username: ${{ github.actor }}
1235-
password: ${{ secrets.GITHUB_TOKEN }}
1210+
# No GHCR login needed - public images can be pulled without authentication
12361211

12371212
- name: Run classify tests
12381213
run: |
@@ -1264,18 +1239,13 @@ jobs:
12641239
runs-on: ubuntu-24.04-arm
12651240
permissions:
12661241
contents: read
1267-
packages: read
1242+
# packages: read not needed - GHCR public images can be pulled without auth
12681243

12691244
steps:
12701245
- name: Checkout repository
12711246
uses: actions/checkout@v4
12721247

1273-
- name: Log in to GitHub Container Registry
1274-
uses: docker/login-action@v3
1275-
with:
1276-
registry: ghcr.io
1277-
username: ${{ github.actor }}
1278-
password: ${{ secrets.GITHUB_TOKEN }}
1248+
# No GHCR login needed - public images can be pulled without authentication
12791249

12801250
- name: Run classify tests (ARM64)
12811251
run: |
@@ -1294,18 +1264,13 @@ jobs:
12941264
runs-on: ubuntu-latest
12951265
permissions:
12961266
contents: read
1297-
packages: read
1267+
# packages: read not needed - GHCR public images can be pulled without auth
12981268

12991269
steps:
13001270
- name: Checkout repository
13011271
uses: actions/checkout@v4
13021272

1303-
- name: Log in to GitHub Container Registry
1304-
uses: docker/login-action@v3
1305-
with:
1306-
registry: ghcr.io
1307-
username: ${{ github.actor }}
1308-
password: ${{ secrets.GITHUB_TOKEN }}
1273+
# No GHCR login needed - public images can be pulled without authentication
13091274

13101275
- name: Run phylo tests
13111276
run: |
@@ -1337,18 +1302,13 @@ jobs:
13371302
runs-on: ubuntu-24.04-arm
13381303
permissions:
13391304
contents: read
1340-
packages: read
1305+
# packages: read not needed - GHCR public images can be pulled without auth
13411306

13421307
steps:
13431308
- name: Checkout repository
13441309
uses: actions/checkout@v4
13451310

1346-
- name: Log in to GitHub Container Registry
1347-
uses: docker/login-action@v3
1348-
with:
1349-
registry: ghcr.io
1350-
username: ${{ github.actor }}
1351-
password: ${{ secrets.GITHUB_TOKEN }}
1311+
# No GHCR login needed - public images can be pulled without authentication
13521312

13531313
- name: Run phylo tests (ARM64)
13541314
run: |

0 commit comments

Comments
 (0)