Skip to content

Commit 7cd669f

Browse files
committed
just run krona merge at the end of the krakenuniq task, also specify --sample_name
1 parent 9446b1d commit 7cd669f

File tree

5 files changed

+9
-21
lines changed

5 files changed

+9
-21
lines changed

pipes/WDL/tasks/tasks_metagenomics.wdl

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ task krakenuniq {
4040
OUT_BASENAME=basenames_reports.txt
4141
for bam in ${sep=' ' reads_unmapped_bam}; do
4242
echo "$(basename $bam .bam).krakenuniq-reads.txt.gz" >> $OUT_READS
43-
echo "$(basename $bam .bam).krakenuniq" >> $OUT_BASENAME
43+
echo "$(basename $bam .bam)" >> $OUT_BASENAME
4444
echo "$(basename $bam .bam).krakenuniq-summary_report.txt" >> $OUT_REPORTS
4545
done
4646
@@ -62,18 +62,23 @@ task krakenuniq {
6262
# run single-threaded krona on up to nproc samples at once
6363
parallel -I ,, \
6464
"metagenomics.py krona \
65-
,,-summary_report.txt \
65+
,,.krakenuniq-summary_report.txt \
6666
$DB_DIR/krona \
67-
,,-krona.html \
67+
,,.krakenuniq-krona.html \
68+
--sample_name ,, \
6869
--noRank --noHits --inputType krakenuniq \
6970
--loglevel=DEBUG" \
7071
::: `cat $OUT_BASENAME`
72+
73+
# merge all krona reports
74+
ktImportKrona -o krakenuniq.krona.combined.html *.krakenuniq-krona.html
7175
}
7276

7377
output {
7478
Array[File] krakenuniq_classified_reads = glob("*.krakenuniq-reads.txt.gz")
7579
Array[File] krakenuniq_summary_reports = glob("*.krakenuniq-summary_report.txt")
7680
Array[File] krona_report_html = glob("*.krakenuniq-krona.html")
81+
File krona_report_merged_html = "krakenuniq.krona.combined.html"
7782
String viralngs_version = read_string("VERSION")
7883
}
7984

pipes/WDL/workflows/classify_krakenuniq.wdl

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,6 @@ import "../tasks/tasks_reports.wdl" as reports
44
workflow classify_krakenuniq {
55
call metagenomics.krakenuniq
66

7-
call metagenomics.krona_merge {
8-
input:
9-
krona_reports = krakenuniq.krona_report_html,
10-
out_basename = "krakenuniq.krona.combined"
11-
}
12-
137
call reports.aggregate_metagenomics_reports as metag_summary_report {
148
input:
159
kraken_summary_reports = krakenuniq.krakenuniq_summary_reports

pipes/WDL/workflows/demux_metag.wdl

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,6 @@ workflow demux_metag {
3838
input:
3939
reads_unmapped_bam = illumina_demux.raw_reads_unaligned_bams
4040
}
41-
call metagenomics.krona_merge {
42-
input:
43-
krona_reports = kraken.krona_report_html,
44-
out_basename = "krakenuniq.krona.combined"
45-
}
4641
call reports.aggregate_metagenomics_reports as metag_summary_report {
4742
input:
4843
kraken_summary_reports = kraken.krakenuniq_summary_reports

pipes/WDL/workflows/demux_plus.wdl

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,6 @@ workflow demux_plus {
5151
reads_unmapped_bam = illumina_demux.raw_reads_unaligned_bams
5252
}
5353
54-
call metagenomics.krona_merge {
55-
input:
56-
krona_reports = krakenuniq.krona_report_html,
57-
out_basename = "krakenuniq.krona.combined"
58-
}
59-
6054
call reports.spikein_summary as spike_summary {
6155
input:
6256
spikein_count_txt = spikein.report

requirements-modules.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
broadinstitute/viral-core=v2.0.20.1
22
broadinstitute/viral-assemble=v2.0.17.0
3-
broadinstitute/viral-classify=v2.0.20.1
3+
broadinstitute/viral-classify=v2.0.20.2
44
broadinstitute/viral-phylo=v2.0.16.0

0 commit comments

Comments
 (0)