Skip to content

Commit 396c253

Browse files
committed
fix api
1 parent 2cc7689 commit 396c253

File tree

4 files changed

+46
-14
lines changed

4 files changed

+46
-14
lines changed

Dockerfile

+1-2
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,7 @@ COPY --from=ghcr.io/astral-sh/uv:0.5.18 /uv /uvx /bin/
4343

4444
WORKDIR $APP_HOME
4545

46-
RUN uv sync --frozen --dev && \
47-
rm -rf $APP_HOME
46+
RUN uv sync --frozen --dev
4847

4948
EXPOSE 8000
5049

compose.yml

+33
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
services:
2+
teufa:
3+
build:
4+
context: .
5+
develop:
6+
watch:
7+
- action: sync+restart
8+
path: .
9+
target: /opt/app
10+
ignore:
11+
- .venv/
12+
- action: rebuild
13+
path: ./pyproject.toml
14+
ports:
15+
- "8000:8000"
16+
environment:
17+
DATABASE_URL: postgresql+psycopg://postgres:changeme@db:5432/postgres
18+
depends_on:
19+
- db
20+
db:
21+
image: postgres:16
22+
environment:
23+
POSTGRES_PASSWORD: changeme
24+
POSTGRES_DB: teufa
25+
ports:
26+
- "5432:5432"
27+
migrate:
28+
image: teufa:latest
29+
depends_on:
30+
- db
31+
environment:
32+
DATABASE_URL: postgresql+psycopg://postgres:changeme@db:5432/postgres
33+
command: alembic upgrade head

tests/test_flight.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def test_create_flight(client: FlaskClient):
3030
)
3131

3232
assert response.status_code == 201
33-
assert json.loads(response.json) == {
33+
assert response.json == {
3434
"flight": {
3535
"id": 1,
3636
"departure_icao": "KDEN",
@@ -63,7 +63,7 @@ def test_get_flight(client: FlaskClient):
6363
response = client.get("/api/v1/flights/1")
6464

6565
assert response.status_code == 200
66-
assert json.loads(response.json) == {
66+
assert response.json == {
6767
"flight": {
6868
"id": 1,
6969
"departure_icao": "KDEN",
@@ -77,7 +77,7 @@ def test_get_flight_not_found(client: FlaskClient):
7777
response = client.get("/api/v1/flights/1")
7878

7979
assert response.status_code == 404
80-
assert json.loads(response.json) == {"message": "Flight not found"}
80+
assert response.json == {"message": "Flight not found"}
8181

8282

8383
def test_update_flight(client: FlaskClient):
@@ -112,7 +112,7 @@ def test_update_flight(client: FlaskClient):
112112
)
113113

114114
assert response.status_code == 200
115-
assert json.loads(response.json) == {
115+
assert response.json == {
116116
"flight": {
117117
"id": 1,
118118
"departure_icao": "KJFK",
@@ -134,7 +134,7 @@ def test_update_flight_not_found(client: FlaskClient):
134134
)
135135

136136
assert response.status_code == 404
137-
assert json.loads(response.json) == {"message": "Flight not found"}
137+
assert response.json == {"message": "Flight not found"}
138138

139139

140140
def test_delete_flight(client: FlaskClient):
@@ -170,4 +170,4 @@ def test_delete_flight_not_found(client: FlaskClient):
170170
response = client.delete("/api/v1/flights/1")
171171

172172
assert response.status_code == 404
173-
assert json.loads(response.json) == {"message": "Flight not found"}
173+
assert response.json == {"message": "Flight not found"}

teufa/v1_api/flights.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -33,15 +33,15 @@ def post(self):
3333
}
3434
)
3535

36-
return res.model_dump_json(), 201
36+
return res.model_dump(), 201
3737

3838

3939
class FlightResource(Resource):
4040
def get(self, flight_id):
4141
flight = db.session.get(dbm.Flight, flight_id)
4242

4343
if not flight:
44-
return dao.Error(message="Flight not found").model_dump_json(), 404
44+
return dao.Error(message="Flight not found").model_dump(), 404
4545

4646
res = dao.GetFlightResponse(
4747
**{
@@ -54,13 +54,13 @@ def get(self, flight_id):
5454
}
5555
)
5656

57-
return res.model_dump_json()
57+
return res.model_dump()
5858

5959
def put(self, flight_id):
6060
flight = db.session.get(dbm.Flight, flight_id)
6161

6262
if not flight:
63-
return dao.Error(message="Flight not found").model_dump_json(), 404
63+
return dao.Error(message="Flight not found").model_dump(), 404
6464

6565
data = request.get_json()
6666

@@ -88,13 +88,13 @@ def put(self, flight_id):
8888
}
8989
)
9090

91-
return res.model_dump_json()
91+
return res.model_dump()
9292

9393
def delete(self, flight_id):
9494
flight = db.session.get(dbm.Flight, flight_id)
9595

9696
if not flight:
97-
return dao.Error(message="Flight not found").model_dump_json(), 404
97+
return dao.Error(message="Flight not found").model_dump(), 404
9898

9999
db.session.delete(flight)
100100
db.session.commit()

0 commit comments

Comments
 (0)