lint

Author: kamath

examples/e2e/test_playwright.py

@@ -26,19 +26,19 @@ def playwright():
         yield p
 
 
-def test_playwright_basic(playwright: Playwright):
+def test_playwright_basic(playwright: Playwright) -> None:
     playwright_basic.run(playwright)
 
 
-def test_playwright_captcha(playwright: Playwright):
+def test_playwright_captcha(playwright: Playwright) -> None:
     if SKIP_CAPTCHA_SOLVING:
         pytest.skip("Skipping captcha solving")
     playwright_captcha.run(playwright)
 
 
-def test_playwright_contexts(playwright: Playwright):
+def test_playwright_contexts(playwright: Playwright) -> None:
     playwright_contexts.run(playwright)
 
 
-def test_playwright_downloads(playwright: Playwright):
+def test_playwright_downloads(playwright: Playwright) -> None:
     playwright_downloads.run(playwright)

examples/playwright_basic.py

@@ -8,7 +8,7 @@
 )
 
 
-def run(playwright: Playwright):
+def run(playwright: Playwright) -> None:
     # Create a session on Browserbase
     session = bb.sessions.create(project_id=BROWSERBASE_PROJECT_ID)
     assert session.id is not None

examples/playwright_captcha.py

@@ -11,7 +11,7 @@
 OVERRIDE_TIMEOUT = 60000  # 60 seconds, adjust as needed
 
 
-def run(playwright: Playwright):
+def run(playwright: Playwright) -> None:
     # Create a session on Browserbase
     session = bb.sessions.create(project_id=BROWSERBASE_PROJECT_ID)
     assert session.id is not None

examples/playwright_contexts.py

@@ -28,7 +28,7 @@ def find_cookie(browser: Browser, name: str) -> Optional[Cookie]:
     return next((cookie for cookie in cookies if cookie.get("name") == name), None)
 
 
-def run(playwright: Playwright):
+def run(playwright: Playwright) -> None:
     context_id = None
     session_id = None
     test_cookie_name = None

examples/playwright_downloads.py

@@ -19,7 +19,7 @@ def get_download(session_id: str) -> bytes:
     return response.read()
 
 
-def run(playwright: Playwright):
+def run(playwright: Playwright) -> None:
     # Create a session on Browserbase
     session = bb.sessions.create(project_id=BROWSERBASE_PROJECT_ID)
     assert session.id is not None

examples/playwright_extensions.py

@@ -4,7 +4,7 @@
 from io import BytesIO
 from pathlib import Path
 
-from playwright.sync_api import Playwright, sync_playwright
+from playwright.sync_api import Page, Playwright, sync_playwright
 
 from examples import (
     BROWSERBASE_API_KEY,
@@ -52,7 +52,7 @@ def zip_extension(path: Path = PATH_TO_EXTENSION, save_local: bool = False) -> B
     return memory_zip
 
 
-def create_extension():
+def create_extension() -> str:
     zip_data = zip_extension(save_local=True)
     extension: Extension = bb.extensions.create(
         file=("extension.zip", zip_data.getvalue())
@@ -64,11 +64,27 @@ def get_extension(id: str) -> Extension:
     return bb.extensions.retrieve(id)
 
 
-def delete_extension(id: str):
+def delete_extension(id: str) -> None:
     bb.extensions.delete(id)
 
 
-def run(playwright: Playwright):
+def check_for_message(page: Page, message: str) -> None:
+    # Wait for the extension to load and log a message
+    console_messages: list[str] = []
+    page.on("console", lambda msg: console_messages.append(msg.text))
+    page.goto("https://www.browserbase.com/")
+
+    start = time.time()
+    while time.time() - start < 10:
+        if message in console_messages:
+            break
+    assert (
+        message in console_messages
+    ), f"Expected message not found in console logs. Messages: {console_messages}"
+
+
+def run(playwright: Playwright) -> None:
+    expected_message = "browserbase test extension image loaded"
     extension_id = None
 
     # Create extension
@@ -90,21 +106,7 @@ def run(playwright: Playwright):
     )
     context = browser.contexts[0]
     page = context.pages[0]
-
-    console_messages: list[str] = []
-    page.on("console", lambda msg: console_messages.append(msg.text))
-
-    page.goto("https://www.browserbase.com/")
-
-    # Wait for the extension to load and log a message
-    start = time.time()
-    while time.time() - start < 10:
-        if "browserbase test extension image loaded" in console_messages:
-            break
-    assert (
-        "browserbase test extension image loaded" in console_messages
-    ), f"Expected message not found in console logs. Messages: {console_messages}"
-
+    check_for_message(page, expected_message)
     page.close()
     browser.close()
 
@@ -126,15 +128,7 @@ def run(playwright: Playwright):
 
     page.goto("https://www.browserbase.com/")
 
-    # Wait for the extension to load and log a message (longer timeout for proxies)
-    start = time.time()
-    while time.time() - start < 10:
-        if "browserbase test extension image loaded" in console_messages:
-            break
-    assert (
-        "browserbase test extension image loaded" in console_messages
-    ), f"Expected message not found in console logs. Messages: {console_messages}"
-
+    check_for_message(page, expected_message)
     page.close()
     browser.close()