Skip to content

Commit 29e411c

Browse files
fix(client): handle path params correctly in FromRawUnchecked
1 parent 5b6b3fc commit 29e411c

8 files changed

Lines changed: 57 additions & 25 deletions

File tree

src/Stagehand/Models/Sessions/SessionActParams.cs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,26 +125,30 @@ IReadOnlyDictionary<string, JsonElement> rawBodyData
125125
SessionActParams(
126126
FrozenDictionary<string, JsonElement> rawHeaderData,
127127
FrozenDictionary<string, JsonElement> rawQueryData,
128-
FrozenDictionary<string, JsonElement> rawBodyData
128+
FrozenDictionary<string, JsonElement> rawBodyData,
129+
string id
129130
)
130131
{
131132
this._rawHeaderData = new(rawHeaderData);
132133
this._rawQueryData = new(rawQueryData);
133134
this._rawBodyData = new(rawBodyData);
135+
this.ID = id;
134136
}
135137
#pragma warning restore CS8618
136138

137139
/// <inheritdoc cref="IFromRawJson{T}.FromRawUnchecked"/>
138140
public static SessionActParams FromRawUnchecked(
139141
IReadOnlyDictionary<string, JsonElement> rawHeaderData,
140142
IReadOnlyDictionary<string, JsonElement> rawQueryData,
141-
IReadOnlyDictionary<string, JsonElement> rawBodyData
143+
IReadOnlyDictionary<string, JsonElement> rawBodyData,
144+
string id
142145
)
143146
{
144147
return new(
145148
FrozenDictionary.ToFrozenDictionary(rawHeaderData),
146149
FrozenDictionary.ToFrozenDictionary(rawQueryData),
147-
FrozenDictionary.ToFrozenDictionary(rawBodyData)
150+
FrozenDictionary.ToFrozenDictionary(rawBodyData),
151+
id
148152
);
149153
}
150154

src/Stagehand/Models/Sessions/SessionEndParams.cs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,23 +68,27 @@ IReadOnlyDictionary<string, JsonElement> rawQueryData
6868
[SetsRequiredMembers]
6969
SessionEndParams(
7070
FrozenDictionary<string, JsonElement> rawHeaderData,
71-
FrozenDictionary<string, JsonElement> rawQueryData
71+
FrozenDictionary<string, JsonElement> rawQueryData,
72+
string id
7273
)
7374
{
7475
this._rawHeaderData = new(rawHeaderData);
7576
this._rawQueryData = new(rawQueryData);
77+
this.ID = id;
7678
}
7779
#pragma warning restore CS8618
7880

7981
/// <inheritdoc cref="IFromRawJson{T}.FromRawUnchecked"/>
8082
public static SessionEndParams FromRawUnchecked(
8183
IReadOnlyDictionary<string, JsonElement> rawHeaderData,
82-
IReadOnlyDictionary<string, JsonElement> rawQueryData
84+
IReadOnlyDictionary<string, JsonElement> rawQueryData,
85+
string id
8386
)
8487
{
8588
return new(
8689
FrozenDictionary.ToFrozenDictionary(rawHeaderData),
87-
FrozenDictionary.ToFrozenDictionary(rawQueryData)
90+
FrozenDictionary.ToFrozenDictionary(rawQueryData),
91+
id
8892
);
8993
}
9094

src/Stagehand/Models/Sessions/SessionExecuteParams.cs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,26 +134,30 @@ IReadOnlyDictionary<string, JsonElement> rawBodyData
134134
SessionExecuteParams(
135135
FrozenDictionary<string, JsonElement> rawHeaderData,
136136
FrozenDictionary<string, JsonElement> rawQueryData,
137-
FrozenDictionary<string, JsonElement> rawBodyData
137+
FrozenDictionary<string, JsonElement> rawBodyData,
138+
string id
138139
)
139140
{
140141
this._rawHeaderData = new(rawHeaderData);
141142
this._rawQueryData = new(rawQueryData);
142143
this._rawBodyData = new(rawBodyData);
144+
this.ID = id;
143145
}
144146
#pragma warning restore CS8618
145147

146148
/// <inheritdoc cref="IFromRawJson{T}.FromRawUnchecked"/>
147149
public static SessionExecuteParams FromRawUnchecked(
148150
IReadOnlyDictionary<string, JsonElement> rawHeaderData,
149151
IReadOnlyDictionary<string, JsonElement> rawQueryData,
150-
IReadOnlyDictionary<string, JsonElement> rawBodyData
152+
IReadOnlyDictionary<string, JsonElement> rawBodyData,
153+
string id
151154
)
152155
{
153156
return new(
154157
FrozenDictionary.ToFrozenDictionary(rawHeaderData),
155158
FrozenDictionary.ToFrozenDictionary(rawQueryData),
156-
FrozenDictionary.ToFrozenDictionary(rawBodyData)
159+
FrozenDictionary.ToFrozenDictionary(rawBodyData),
160+
id
157161
);
158162
}
159163

src/Stagehand/Models/Sessions/SessionExtractParams.cs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -158,26 +158,30 @@ IReadOnlyDictionary<string, JsonElement> rawBodyData
158158
SessionExtractParams(
159159
FrozenDictionary<string, JsonElement> rawHeaderData,
160160
FrozenDictionary<string, JsonElement> rawQueryData,
161-
FrozenDictionary<string, JsonElement> rawBodyData
161+
FrozenDictionary<string, JsonElement> rawBodyData,
162+
string id
162163
)
163164
{
164165
this._rawHeaderData = new(rawHeaderData);
165166
this._rawQueryData = new(rawQueryData);
166167
this._rawBodyData = new(rawBodyData);
168+
this.ID = id;
167169
}
168170
#pragma warning restore CS8618
169171

170172
/// <inheritdoc cref="IFromRawJson{T}.FromRawUnchecked"/>
171173
public static SessionExtractParams FromRawUnchecked(
172174
IReadOnlyDictionary<string, JsonElement> rawHeaderData,
173175
IReadOnlyDictionary<string, JsonElement> rawQueryData,
174-
IReadOnlyDictionary<string, JsonElement> rawBodyData
176+
IReadOnlyDictionary<string, JsonElement> rawBodyData,
177+
string id
175178
)
176179
{
177180
return new(
178181
FrozenDictionary.ToFrozenDictionary(rawHeaderData),
179182
FrozenDictionary.ToFrozenDictionary(rawQueryData),
180-
FrozenDictionary.ToFrozenDictionary(rawBodyData)
183+
FrozenDictionary.ToFrozenDictionary(rawBodyData),
184+
id
181185
);
182186
}
183187

src/Stagehand/Models/Sessions/SessionNavigateParams.cs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,26 +145,30 @@ IReadOnlyDictionary<string, JsonElement> rawBodyData
145145
SessionNavigateParams(
146146
FrozenDictionary<string, JsonElement> rawHeaderData,
147147
FrozenDictionary<string, JsonElement> rawQueryData,
148-
FrozenDictionary<string, JsonElement> rawBodyData
148+
FrozenDictionary<string, JsonElement> rawBodyData,
149+
string id
149150
)
150151
{
151152
this._rawHeaderData = new(rawHeaderData);
152153
this._rawQueryData = new(rawQueryData);
153154
this._rawBodyData = new(rawBodyData);
155+
this.ID = id;
154156
}
155157
#pragma warning restore CS8618
156158

157159
/// <inheritdoc cref="IFromRawJson{T}.FromRawUnchecked"/>
158160
public static SessionNavigateParams FromRawUnchecked(
159161
IReadOnlyDictionary<string, JsonElement> rawHeaderData,
160162
IReadOnlyDictionary<string, JsonElement> rawQueryData,
161-
IReadOnlyDictionary<string, JsonElement> rawBodyData
163+
IReadOnlyDictionary<string, JsonElement> rawBodyData,
164+
string id
162165
)
163166
{
164167
return new(
165168
FrozenDictionary.ToFrozenDictionary(rawHeaderData),
166169
FrozenDictionary.ToFrozenDictionary(rawQueryData),
167-
FrozenDictionary.ToFrozenDictionary(rawBodyData)
170+
FrozenDictionary.ToFrozenDictionary(rawBodyData),
171+
id
168172
);
169173
}
170174

src/Stagehand/Models/Sessions/SessionObserveParams.cs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,26 +132,30 @@ IReadOnlyDictionary<string, JsonElement> rawBodyData
132132
SessionObserveParams(
133133
FrozenDictionary<string, JsonElement> rawHeaderData,
134134
FrozenDictionary<string, JsonElement> rawQueryData,
135-
FrozenDictionary<string, JsonElement> rawBodyData
135+
FrozenDictionary<string, JsonElement> rawBodyData,
136+
string id
136137
)
137138
{
138139
this._rawHeaderData = new(rawHeaderData);
139140
this._rawQueryData = new(rawQueryData);
140141
this._rawBodyData = new(rawBodyData);
142+
this.ID = id;
141143
}
142144
#pragma warning restore CS8618
143145

144146
/// <inheritdoc cref="IFromRawJson{T}.FromRawUnchecked"/>
145147
public static SessionObserveParams FromRawUnchecked(
146148
IReadOnlyDictionary<string, JsonElement> rawHeaderData,
147149
IReadOnlyDictionary<string, JsonElement> rawQueryData,
148-
IReadOnlyDictionary<string, JsonElement> rawBodyData
150+
IReadOnlyDictionary<string, JsonElement> rawBodyData,
151+
string id
149152
)
150153
{
151154
return new(
152155
FrozenDictionary.ToFrozenDictionary(rawHeaderData),
153156
FrozenDictionary.ToFrozenDictionary(rawQueryData),
154-
FrozenDictionary.ToFrozenDictionary(rawBodyData)
157+
FrozenDictionary.ToFrozenDictionary(rawBodyData),
158+
id
155159
);
156160
}
157161

src/Stagehand/Models/Sessions/SessionReplayParams.cs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,23 +68,27 @@ IReadOnlyDictionary<string, JsonElement> rawQueryData
6868
[SetsRequiredMembers]
6969
SessionReplayParams(
7070
FrozenDictionary<string, JsonElement> rawHeaderData,
71-
FrozenDictionary<string, JsonElement> rawQueryData
71+
FrozenDictionary<string, JsonElement> rawQueryData,
72+
string id
7273
)
7374
{
7475
this._rawHeaderData = new(rawHeaderData);
7576
this._rawQueryData = new(rawQueryData);
77+
this.ID = id;
7678
}
7779
#pragma warning restore CS8618
7880

7981
/// <inheritdoc cref="IFromRawJson{T}.FromRawUnchecked"/>
8082
public static SessionReplayParams FromRawUnchecked(
8183
IReadOnlyDictionary<string, JsonElement> rawHeaderData,
82-
IReadOnlyDictionary<string, JsonElement> rawQueryData
84+
IReadOnlyDictionary<string, JsonElement> rawQueryData,
85+
string id
8386
)
8487
{
8588
return new(
8689
FrozenDictionary.ToFrozenDictionary(rawHeaderData),
87-
FrozenDictionary.ToFrozenDictionary(rawQueryData)
90+
FrozenDictionary.ToFrozenDictionary(rawQueryData),
91+
id
8892
);
8993
}
9094

src/Stagehand/Services/SessionService.cs

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,8 @@ public async Task<StreamingHttpResponse<StreamEvent>> ActStreaming(
417417
parameters = SessionActParams.FromRawUnchecked(
418418
parameters.RawHeaderData,
419419
parameters.RawQueryData,
420-
rawBodyData
420+
rawBodyData,
421+
parameters.ID
421422
);
422423
parameters = parameters with { ID = id };
423424

@@ -565,7 +566,8 @@ public async Task<StreamingHttpResponse<StreamEvent>> ExecuteStreaming(
565566
parameters = SessionExecuteParams.FromRawUnchecked(
566567
parameters.RawHeaderData,
567568
parameters.RawQueryData,
568-
rawBodyData
569+
rawBodyData,
570+
parameters.ID
569571
);
570572
parameters = parameters with { ID = id };
571573

@@ -670,7 +672,8 @@ public async Task<StreamingHttpResponse<StreamEvent>> ExtractStreaming(
670672
parameters = SessionExtractParams.FromRawUnchecked(
671673
parameters.RawHeaderData,
672674
parameters.RawQueryData,
673-
rawBodyData
675+
rawBodyData,
676+
parameters.ID
674677
);
675678
parameters = parameters with { ID = id };
676679

@@ -820,7 +823,8 @@ public async Task<StreamingHttpResponse<StreamEvent>> ObserveStreaming(
820823
parameters = SessionObserveParams.FromRawUnchecked(
821824
parameters.RawHeaderData,
822825
parameters.RawQueryData,
823-
rawBodyData
826+
rawBodyData,
827+
parameters.ID
824828
);
825829
parameters = parameters with { ID = id };
826830

0 commit comments

Comments
 (0)