Skip to content

Find a way to prefix 3rd-party includes indicating source library #60

Open
@jerinphilip

Description

@jerinphilip

There's a translator folder in bergamot-translator and also 3rd-party/marian-dev. When files are included, it's not obvious which folder the sources came from, and leaving it thus can potentially lead to issues. For example, below file which includes translator from both marian and bergamot-translator with no way to distinguish on first look.

#include "translator/output_collector.h"
#include "translator/output_printer.h"
#include "translator/parser.h"
#include "translator/response.h"
#include "translator/service.h"

While this file is not strictly necessary here, this should ideally be configured so that the source-library is known, in this case 'marian' or 'bergamot-translator'. Unsure of the solution, but filing an issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    cleanupSomething that can be refactored or better organized

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions