Skip to content

Commit fc0cf34

Browse files
authored
Merge pull request #15 from sinstein/master
Username suffix for tracking sessions run via TeamCity
2 parents fa7e21d + aeb92ac commit fc0cf34

File tree

7 files changed

+15
-9
lines changed

7 files changed

+15
-9
lines changed

browserstack-teamcity-agent/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<parent>
66
<artifactId>browserstack-teamcity</artifactId>
77
<groupId>com.browserstack</groupId>
8-
<version>1.0.1</version>
8+
<version>1.0.2</version>
99
</parent>
1010

1111
<artifactId>browserstack-teamcity-agent</artifactId>

browserstack-teamcity-agent/src/main/java/com/browserstack/automate/ci/teamcity/BrowserStackLocalAgent.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,12 +141,16 @@ private void loadBuildFeature(final AgentRunningBuild build) {
141141
* @param config
142142
*/
143143
private void exportEnvVars(final BuildRunnerContext runner, final Map<String, String> config) {
144-
if (!config.containsKey(EnvVars.BROWSERSTACK_USERNAME) || !config.containsKey(EnvVars.BROWSERSTACK_ACCESS_KEY)) {
145-
return;
144+
if(!((config.containsKey(EnvVars.BROWSERSTACK_USERNAME) || config.containsKey(EnvVars.BROWSERSTACK_USER)) && (config.containsKey(EnvVars.BROWSERSTACK_ACCESS_KEY) || config.containsKey(EnvVars.BROWSERSTACK_ACCESSKEY)))) {
145+
return;
146146
}
147147

148-
runner.addEnvironmentVariable(EnvVars.BROWSERSTACK_USERNAME, config.get(EnvVars.BROWSERSTACK_USERNAME));
149-
runner.addEnvironmentVariable(EnvVars.BROWSERSTACK_ACCESS_KEY, config.get(EnvVars.BROWSERSTACK_ACCESS_KEY));
148+
String username = config.get(EnvVars.BROWSERSTACK_USERNAME) == null ? config.get(EnvVars.BROWSERSTACK_USER) : config.get(EnvVars.BROWSERSTACK_USERNAME);
149+
String accesskey = config.get(EnvVars.BROWSERSTACK_ACCESS_KEY) == null ? config.get(EnvVars.BROWSERSTACK_ACCESSKEY) : config.get(EnvVars.BROWSERSTACK_ACCESS_KEY);
150+
runner.addEnvironmentVariable(EnvVars.BROWSERSTACK_USERNAME, username + "-teamcity");
151+
runner.addEnvironmentVariable(EnvVars.BROWSERSTACK_USER, username + "-teamcity");
152+
runner.addEnvironmentVariable(EnvVars.BROWSERSTACK_ACCESS_KEY, accesskey);
153+
runner.addEnvironmentVariable(EnvVars.BROWSERSTACK_ACCESSKEY, accesskey);
150154
runner.addEnvironmentVariable(EnvVars.BROWSERSTACK_LOCAL, config.get(EnvVars.BROWSERSTACK_LOCAL));
151155

152156
BuildProgressLogger buildLogger = runner.getBuild().getBuildLogger();

browserstack-teamcity-common/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<parent>
66
<artifactId>browserstack-teamcity</artifactId>
77
<groupId>com.browserstack</groupId>
8-
<version>1.0.1</version>
8+
<version>1.0.2</version>
99
</parent>
1010
<artifactId>browserstack-teamcity-common</artifactId>
1111
<packaging>jar</packaging>

browserstack-teamcity-common/src/main/java/com/browserstack/automate/ci/teamcity/BrowserStackParameters.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@ public class BrowserStackParameters {
66

77
public interface EnvVars {
88
String BROWSERSTACK_USERNAME = "BROWSERSTACK_USERNAME";
9+
String BROWSERSTACK_USER = "BROWSERSTACK_USER";
910
String BROWSERSTACK_ACCESS_KEY = "BROWSERSTACK_ACCESS_KEY";
11+
String BROWSERSTACK_ACCESSKEY = "BROWSERSTACK_ACCESSKEY";
1012
String BROWSERSTACK_LOCAL = "BROWSERSTACK_LOCAL";
1113
String BROWSERSTACK_LOCAL_IDENTIFIER = "BROWSERSTACK_LOCAL_IDENTIFIER";
1214
String BROWSERSTACK_BUILD = "BROWSERSTACK_BUILD";

browserstack-teamcity-server/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<parent>
55
<artifactId>browserstack-teamcity</artifactId>
66
<groupId>com.browserstack</groupId>
7-
<version>1.0.1</version>
7+
<version>1.0.2</version>
88
</parent>
99
<artifactId>browserstack-teamcity-server</artifactId>
1010
<packaging>jar</packaging>

build/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<parent>
66
<artifactId>browserstack-teamcity</artifactId>
77
<groupId>com.browserstack</groupId>
8-
<version>1.0.1</version>
8+
<version>1.0.2</version>
99
</parent>
1010

1111
<artifactId>build</artifactId>

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
<groupId>com.browserstack</groupId>
77
<artifactId>browserstack-teamcity</artifactId>
8-
<version>1.0.1</version>
8+
<version>1.0.2</version>
99
<packaging>pom</packaging>
1010

1111
<properties>

0 commit comments

Comments
 (0)