Merge pull request #992 from broxus/release/EWM-TECH_1.15.2

chore(EWM-TECH): release `1.15.2`

Author: Odrin

analysis_options.yaml

@@ -3,3 +3,6 @@ analyzer:
   exclude:
     - lib/di/di.config.dart
     - "**.reflectable.dart"
+  # TODO: Enable when dependency conflict with reflectable (used in bridge) is resolved
+  # plugins:
+  #   - custom_lint

docs/architecture.md

@@ -281,19 +281,27 @@ We use the [Elementary](https://pub.dev/packages/elementary) package as our impl
   - Management of stream subscriptions
   - Automatic disposal of all managed resources
 
+  **Important Naming Convention for Reactive Fields:**
+  
+  All reactive fields in WidgetModel must follow strict naming conventions:
+  - **All Notifier/Listenable types** must end with `State` suffix (ValueNotifier, ValueListenable, StateNotifier, ListenableState, EntityStateNotifier)
+  - **Stream types** must end with `Stream` suffix (Stream, StreamController, BehaviorSubject)
+  - **Private fields must match public getter names** (e.g., `_isLoadingState` for getter `isLoadingState`)
+  
   ```dart
-  // Creating notifiers with automatic disposal
-  final _dataState = createNotifier<MyData>();
-  final _loadingState = createEntityNotifier<MyData>();
-  final _textController = createTextEditingController();
+  // CORRECT - Following naming conventions
+  late final _dataState = createNotifier<MyData>();
+  StateNotifier<MyData> get dataState => _dataState;
   
-  // Creating a notifier from a stream
-  final _streamData = createNotifierFromStream<MyData>(model.dataStream);
+  late final _isLoadingState = createValueNotifier(false);
+  ValueListenable<bool> get isLoadingState => _isLoadingState;
   
-  // Listening to a stream with automatic disposal
-  disposableListen(model.events, (event) {
-    // Handle event
-  });
+  late final _eventsStream = StreamController<Event>.broadcast();
+  Stream<Event> get eventsStream => _eventsStream.stream;
+  
+  // WRONG - Missing proper suffixes
+  late final _data = createNotifier<MyData>();  // Should be _dataState
+  late final _isLoading = createValueNotifier(false);  // Should be _isLoadingState
   ```
 
 - `EntityStateNotifier` - A specialized StateNotifier that encapsulates a three-state model for UI data: loading, error, and content. It's designed for handling async operations and their UI states:

docs/llm/architecture_and_code_standards.instructions.md

@@ -36,6 +36,29 @@ For each feature screen, create exactly these 3 files:
 - **Model**: Data handling, state management, extends `ElementaryModel`, MUST be `@injectable`
 - **WidgetModel**: Business logic, user interactions, MUST be `@injectable`
 
+### Reactive Field Naming Convention
+
+In WidgetModel files, ALL reactive fields must use proper suffixes:
+
+- **All Notifier/Listenable types**: Must end with `State` suffix
+  - Includes: `ValueNotifier`, `ValueListenable`, `StateNotifier`, `ListenableState`, `EntityStateNotifier`
+  - Example: `isLoadingState`, `selectedTabState`, `userDataState`
+- **Stream types**: Must end with `Stream` suffix
+  - Includes: `Stream`, `StreamController`, `BehaviorSubject`
+  - Example: `eventsStream`, `dataStream`
+
+**Private fields must match public getters:**
+
+```dart
+// CORRECT
+late final _isLoadingState = createValueNotifier(false);
+ValueListenable<bool> get isLoadingState => _isLoadingState;
+
+// WRONG - Private field name doesn't match getter
+late final _isLoading = createValueNotifier(false);
+ValueListenable<bool> get isLoadingState => _isLoading;
+```
+
 ### Base Class Patterns
 
 The project uses two patterns for Elementary MVVM implementation:

lib/app/router/router.dart

@@ -110,6 +110,7 @@ class CompassRouter {
   /// Returns the stream with current active routes in the navigation stack.
   late final _currentRoutesSubject = _router.routerDelegate.asBehaviourSubject(
     () => _locationByUri(currentUri),
+    sync: true, // prevent inconsistencies in RestoreSubroutesGuard
   );
 
   Stream<Iterable<CompassBaseGoRoute>> get currentRoutesStream =>

lib/app/service/bootstrap/bootstrap_service.dart

@@ -75,8 +75,9 @@ class BootstrapService {
       _bootstrapStepSubject.add(BootstrapSteps.completed);
 
       return true;
-    } catch (e, t) {
-      _log.severe('init', e, t);
+    } catch (e, st) {
+      _log.severe('init', e, st);
+      SentryWorker.instance.captureException(e, stackTrace: st);
       return false;
     }
   }

lib/app/service/connection/connection_service.dart

@@ -1,5 +1,4 @@
 import 'package:app/app/service/service.dart';
-import 'package:app/di/di.dart';
 import 'package:app/feature/messenger/domain/service/messenger_service.dart';
 import 'package:dio/dio.dart';
 import 'package:injectable/injectable.dart';
@@ -18,6 +17,7 @@ class ConnectionService {
     this._storageService,
     this._nekotonRepository,
     this._presetsConnectionService,
+    this._messengerService,
     this._dio,
   );
 
@@ -26,6 +26,7 @@ class ConnectionService {
   final ConnectionsStorageService _storageService;
   final NekotonRepository _nekotonRepository;
   final PresetsConnectionService _presetsConnectionService;
+  final MessengerService _messengerService;
   final Dio _dio;
 
   /// Set up selected connection.
@@ -107,7 +108,7 @@ class ConnectionService {
 
       _log.finest('updateTransportByConnection completed!');
     } catch (e, t) {
-      inject<MessengerService>().showConnectionError(null);
+      _messengerService.showConnectionError(null);
       _log.severe('updateTransportByConnection', e, t);
 
       final base = _storageService.baseConnection;

lib/app/service/localization/localization.dart

@@ -12,7 +12,6 @@ export 'current_accounts_service.dart';
 export 'current_seed_service.dart';
 export 'http_clients.dart';
 export 'identify/identify.dart';
-export 'localization/localization.dart';
 export 'nekoton_related/nekoton_related.dart';
 export 'network_connection/network_connection.dart';
 export 'ntp_service.dart';

lib/app/service/localization/widget/widget.dart

@@ -1,9 +1,8 @@
 import 'package:app/app/router/router.dart';
 import 'package:app/app/service/crash_detector/widget/crash_detector_widget.dart';
-import 'package:app/app/service/localization/service/supported_locale_codes.dart';
-import 'package:app/app/service/localization/widget/localization_service_widget.dart';
 import 'package:app/app/view/app_wm.dart';
 import 'package:app/core/wm/custom_wm.dart';
+import 'package:app/feature/localization/localization.dart';
 import 'package:easy_localization/easy_localization.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_screenutil/flutter_screenutil.dart';