Skip to content

Commit 2559f92

Browse files
authored
Merge pull request #144 from bryanmylee/optional-col-filter-render
Optional `render` column option for addColumnFilters
2 parents 1142c88 + 2f87265 commit 2559f92

File tree

6 files changed

+8
-7
lines changed

6 files changed

+8
-7
lines changed

.github/workflows/coverage.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ jobs:
1717
- uses: actions/setup-node@v1
1818
with:
1919
node-version: 16
20+
- run: npm install svelte
2021
- run: npm ci
2122
- run: npm test
2223
- uses: coverallsapp/github-action@master

docs/src/routes/docs/[...3]plugins/[...3]add-column-filters/+page.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ Defines the filter behavior for the column.
5151

5252
Receives `filterValue` and the column cell `value`, and returns `true` if the cell should be visible.
5353

54-
### `render: (renderProps) => RenderConfig`
54+
### `render?: (renderProps) => RenderConfig`
5555

5656
Defines the component to render on `HeaderCell->props.[pluginName].render`.
5757

src/lib/plugins/addColumnFilters.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export interface ColumnFiltersState<Item> {
1919
export interface ColumnFiltersColumnOptions<Item, FilterValue = any> {
2020
fn: ColumnFilterFn<FilterValue>;
2121
initialFilterValue?: FilterValue;
22-
render: (props: ColumnRenderConfigPropArgs<Item, FilterValue>) => RenderConfig;
22+
render?: (props: ColumnRenderConfigPropArgs<Item, FilterValue>) => RenderConfig;
2323
}
2424

2525
// eslint-disable-next-line @typescript-eslint/no-explicit-any
@@ -46,7 +46,7 @@ export type ColumnFilterFnProps<FilterValue = any, Value = any> = {
4646
export type ColumnFiltersPropSet = NewTablePropSet<{
4747
'thead.tr.th':
4848
| {
49-
render: RenderConfig;
49+
render?: RenderConfig;
5050
}
5151
| undefined;
5252
}>;
@@ -151,7 +151,7 @@ export const addColumnFilters =
151151
}
152152
return [];
153153
});
154-
const render = columnOption.render({
154+
const render = columnOption.render?.({
155155
id: headerCell.id,
156156
filterValue,
157157
...tableState,

src/lib/plugins/addFlatten.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { createTable } from '../createTable';
2-
import type { Sample } from 'src/routes/_createSamples';
2+
import type { Sample } from '../../routes/_createSamples';
33
import { get, readable } from 'svelte/store';
44
import { addFlatten } from './addFlatten';
55
import { addSubRows } from './addSubRows';

src/lib/plugins/addGroupBy.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { createTable } from '../createTable';
2-
import type { Sample } from 'src/routes/_createSamples';
2+
import type { Sample } from '../../routes/_createSamples';
33
import { get, readable } from 'svelte/store';
44
import { addGroupBy } from './addGroupBy';
55
import { addSubRows } from './addSubRows';

src/lib/plugins/addSelectedRows.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/* eslint-disable @typescript-eslint/no-non-null-assertion */
22
import { createTable } from '../createTable';
3-
import type { Sample } from 'src/routes/_createSamples';
3+
import type { Sample } from '../../routes/_createSamples';
44
import { derived, get, readable } from 'svelte/store';
55
import { addSelectedRows } from './addSelectedRows';
66
import { addSubRows } from './addSubRows';

0 commit comments

Comments
 (0)