Snow effect isn't working when runahead is enabled

[bsnesFan]

Not sure how to fix this, so I post this here. The snow effect isn't working when runahead is enabled.

[Screwtapello]

What do you mean by "isn't working"? Can you post a screenshot?

[bsnesFan]

Hi Screwtapello. Here is a video:

2021-02-26-13-01-02.mp4

[Kawa-oneechan]

Can confirm. I've been wondering for the longest time why there was no snow up until a stock settings.bml was added, which disabled my runahead settings. I guess this is why.

[setthh]

Same for dim video when idle. The best way to do this is probabley to disable runahead when bsnes pauses and enable it again when it's active again. I'm not sure how to do this, but these are the lines we have to change:

bsnes/bsnes/target-bsnes/program/utility.cpp

Lines 118 to 124 in f57657f

	auto Program::inactive() -> bool {
	if(locked()) return true;
	if(!emulator->loaded()) return true;
	if(presentation.pauseEmulation.checked()) return true;
	if(presentation.frameAdvance.checked() && frameAdvanceLock) return true;
	if(!focused() && inputSettings.pauseEmulation.checked()) return true;
	return false;

Or here:

bsnes/bsnes/target-bsnes/presentation/presentation.cpp

Lines 160 to 163 in 063e645

	pauseEmulation.setText("Pause Emulation").onActivate([&] {
	audio.clear();
	});
	frameAdvance.setText("Frame Advance").onActivate([&] {

This could be handy when we wan't to do this:

bsnes/bsnes/target-bsnes/program/program.cpp

Lines 106 to 119 in f57657f

	if(!settings.emulator.runAhead.frames || fastForwarding || rewinding) {
	emulator->run();
	} else {
	emulator->setRunAhead(true);
	emulator->run();
	auto state = emulator->serialize(0);
	if(settings.emulator.runAhead.frames >= 2) emulator->run();
	if(settings.emulator.runAhead.frames >= 3) emulator->run();
	if(settings.emulator.runAhead.frames >= 4) emulator->run();
	emulator->setRunAhead(false);
	emulator->run();
	state.setMode(serializer::Mode::Load);
	emulator->unserialize(state);
	}