bub/tests/test_tools_builtin.py at 76aefeeef79fad51a376252550e20b1e02351e6e · bubbuild/bub · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
import asyncio
import inspect
import json
import re
from collections.abc import Iterator
from dataclasses import dataclass
from pathlib import Path
from typing import Any

import pytest
from apscheduler.schedulers.background import BackgroundScheduler
from republic import ToolContext

from bub.config.settings import Settings
from bub.tools.builtin import register_builtin_tools
from bub.tools.registry import ToolRegistry


@dataclass
class _TapeInfo:
    name: str = "bub"
    entries: int = 0
    anchors: int = 0
    last_anchor: str | None = None


class _DummyTape:
    def handoff(self, _name: str, *, state: dict[str, object] | None = None) -> list[object]:
        _ = state
        return []

    def anchors(self, *, limit: int = 20) -> list[object]:
        _ = limit
        return []

    def info(self) -> _TapeInfo:
        return _TapeInfo()

    def search(self, _query: str, *, limit: int = 20) -> list[object]:
        _ = limit
        return []

    def reset(self, *, archive: bool = False) -> str:
        _ = archive
        return "reset"


class _DummyRuntime:
    def __init__(self, settings: Settings, scheduler: BackgroundScheduler) -> None:
        self.settings = settings
        self.scheduler = scheduler
        self._discovered_skills: list[object] = []
        self.reset_calls: list[str] = []
        self.workspace = Path.cwd()

    def discover_skills(self) -> list[object]:
        return list(self._discovered_skills)

    def reset_session_context(self, session_id: str) -> None:
        self.reset_calls.append(session_id)


def _build_registry(workspace: Path, settings: Settings, scheduler: BackgroundScheduler) -> ToolRegistry:
    registry = ToolRegistry()
    runtime = _DummyRuntime(settings, scheduler)
    register_builtin_tools(
        registry,
        workspace=workspace,
        tape=_DummyTape(),  # type: ignore[arg-type]
        runtime=runtime,  # type: ignore[arg-type]
    )
    return registry


def _execute_tool(
    registry: ToolRegistry,
    name: str,
    *,
    kwargs: dict[str, Any],
    session_id: str = "cli:test",
) -> Any:
    descriptor = registry.get(name)
    context = ToolContext(tape="test", run_id="test-run", state={"session_id": session_id})
    if descriptor is not None and descriptor.tool.context:
        result = descriptor.tool.run(context=context, **kwargs)
    else:
        result = registry.execute(name, kwargs=kwargs)
    if inspect.isawaitable(result):
        return asyncio.run(result)
    return result


@pytest.fixture
def scheduler() -> Iterator[BackgroundScheduler]:
    scheduler = BackgroundScheduler(daemon=True)
    scheduler.start()
    yield scheduler
    scheduler.shutdown(wait=False)


def test_web_search_default_returns_duckduckgo_url(tmp_path: Path, scheduler: BackgroundScheduler) -> None:
    settings = Settings(_env_file=None, model="openrouter:test")
    registry = _build_registry(tmp_path, settings, scheduler)
    result = _execute_tool(registry, "web.search", kwargs={"query": "psiace bub"})
    assert result == "https://duckduckgo.com/?q=psiace+bub"


def test_web_fetch_default_normalizes_url_and_extracts_text(
    tmp_path: Path, monkeypatch: Any, scheduler: BackgroundScheduler
) -> None:
    observed_urls: list[str] = []

    class _Response:
        class _Content:
            @staticmethod
            async def read(_size: int | None = None) -> bytes:
                return b"<html><body><h1>Title</h1><p>Hello world.</p></body></html>"

        content = _Content()

    class _RequestCtx:
        def __init__(self, response: _Response) -> None:
            self._response = response

        async def __aenter__(self) -> _Response:
            return self._response

        async def __aexit__(self, exc_type: object, exc: object, tb: object) -> bool:
            _ = (exc_type, exc, tb)
            return False

    class _Session:
        async def __aenter__(self) -> "_Session":
            return self

        async def __aexit__(self, exc_type: object, exc: object, tb: object) -> bool:
            _ = (exc_type, exc, tb)
            return False

        def get(self, url: str, *, headers: dict[str, str]) -> _RequestCtx:
            _ = headers
            observed_urls.append(url)
            return _RequestCtx(_Response())

    monkeypatch.setattr("aiohttp.ClientSession", lambda *args, **kwargs: _Session())

    settings = Settings(_env_file=None, model="openrouter:test")
    registry = _build_registry(tmp_path, settings, scheduler)
    result = _execute_tool(registry, "web.fetch", kwargs={"url": "example.com"})

    assert observed_urls == ["https://example.com"]
    assert "Title" in result
    assert "Hello world." in result


def test_web_search_ollama_mode_calls_api(tmp_path: Path, monkeypatch: Any, scheduler: BackgroundScheduler) -> None:
    observed_request: dict[str, str] = {}

    class _Response:
        @staticmethod
        async def text() -> str:
            payload = {
                "results": [
                    {
                        "title": "Example",
                        "url": "https://example.com",
                        "content": "Example snippet",
                    }
                ]
            }
            return json.dumps(payload)

    class _RequestCtx:
        def __init__(self, response: _Response) -> None:
            self._response = response

        async def __aenter__(self) -> _Response:
            return self._response

        async def __aexit__(self, exc_type: object, exc: object, tb: object) -> bool:
            _ = (exc_type, exc, tb)
            return False

    class _Session:
        async def __aenter__(self) -> "_Session":
            return self

        async def __aexit__(self, exc_type: object, exc: object, tb: object) -> bool:
            _ = (exc_type, exc, tb)
            return False

        def post(self, url: str, *, json: dict[str, object], headers: dict[str, str]) -> _RequestCtx:
            import json as json_lib

            observed_request["url"] = url
            observed_request["auth"] = headers.get("Authorization", "")
            observed_request["payload"] = json_lib.dumps(json)
            return _RequestCtx(_Response())

    monkeypatch.setattr("aiohttp.ClientSession", lambda *args, **kwargs: _Session())

    settings = Settings(
        _env_file=None,
        model="openrouter:test",
        ollama_api_key="ollama-test-key",
        ollama_api_base="https://search.ollama.test/api",
    )
    registry = _build_registry(tmp_path, settings, scheduler)
    result = _execute_tool(registry, "web.search", kwargs={"query": "test query", "max_results": 3})

    assert observed_request["url"] == "https://search.ollama.test/api/web_search"
    assert observed_request["auth"] == "Bearer ollama-test-key"
    assert json.loads(observed_request["payload"]) == {"query": "test query", "max_results": 3}
    assert "Example" in result
    assert "https://example.com" in result
    assert "Example snippet" in result


def test_web_fetch_ollama_mode_normalizes_url_and_extracts_text(
    tmp_path: Path, monkeypatch: Any, scheduler: BackgroundScheduler
) -> None:
    observed_urls: list[str] = []

    class _Response:
        class _Content:
            @staticmethod
            async def read(_size: int | None = None) -> bytes:
                return b"<html><body><h1>Title</h1><p>Hello world.</p></body></html>"

        content = _Content()

    class _RequestCtx:
        def __init__(self, response: _Response) -> None:
            self._response = response

        async def __aenter__(self) -> _Response:
            return self._response

        async def __aexit__(self, exc_type: object, exc: object, tb: object) -> bool:
            _ = (exc_type, exc, tb)
            return False

    class _Session:
        async def __aenter__(self) -> "_Session":
            return self

        async def __aexit__(self, exc_type: object, exc: object, tb: object) -> bool:
            _ = (exc_type, exc, tb)
            return False

        def get(self, url: str, *, headers: dict[str, str]) -> _RequestCtx:
            _ = headers
            observed_urls.append(url)
            return _RequestCtx(_Response())

    monkeypatch.setattr("aiohttp.ClientSession", lambda *args, **kwargs: _Session())

    settings = Settings(
        _env_file=None,
        model="openrouter:test",
        ollama_api_key="ollama-test-key",
    )
    registry = _build_registry(tmp_path, settings, scheduler)
    result = _execute_tool(registry, "web.fetch", kwargs={"url": "example.com"})

    assert observed_urls == ["https://example.com"]
    assert "Title" in result
    assert "Hello world." in result


def test_schedule_add_list_remove_roundtrip(tmp_path: Path, scheduler: BackgroundScheduler) -> None:
    settings = Settings(_env_file=None, model="openrouter:test")
    registry = _build_registry(tmp_path, settings, scheduler)

    add_result = _execute_tool(
        registry,
        "schedule.add",
        kwargs={
            "cron": "*/5 * * * *",
            "message": "hello",
        },
    )
    assert add_result.startswith("scheduled: ")
    matched = re.match(r"^scheduled: (?P<job_id>[a-z0-9-]+) next=.*$", add_result)
    assert matched is not None
    job_id = matched.group("job_id")

    list_result = _execute_tool(registry, "schedule.list", kwargs={})
    assert job_id in list_result
    assert "msg=hello" in list_result

    remove_result = _execute_tool(registry, "schedule.remove", kwargs={"job_id": job_id})
    assert remove_result == f"removed: {job_id}"

    assert _execute_tool(registry, "schedule.list", kwargs={}) == "(no scheduled jobs)"


def test_schedule_add_rejects_invalid_cron(tmp_path: Path, scheduler: BackgroundScheduler) -> None:
    settings = Settings(_env_file=None, model="openrouter:test")
    registry = _build_registry(tmp_path, settings, scheduler)

    try:
        _execute_tool(
            registry,
            "schedule.add",
            kwargs={"cron": "* * *", "message": "bad"},
        )
        raise AssertionError("expected RuntimeError")
    except RuntimeError as exc:
        assert "invalid cron expression" in str(exc)


def test_schedule_remove_missing_job_returns_error(tmp_path: Path, scheduler: BackgroundScheduler) -> None:
    settings = Settings(_env_file=None, model="openrouter:test")
    registry = _build_registry(tmp_path, settings, scheduler)

    try:
        _execute_tool(registry, "schedule.remove", kwargs={"job_id": "missing"})
        raise AssertionError("expected RuntimeError")
    except RuntimeError as exc:
        assert "job not found: missing" in str(exc)


def test_schedule_shared_scheduler_across_registries(tmp_path: Path, scheduler: BackgroundScheduler) -> None:
    workspace = tmp_path / "workspace"
    workspace.mkdir()

    settings = Settings(_env_file=None, model="openrouter:test")
    registry_a = _build_registry(workspace, settings, scheduler)
    registry_b = _build_registry(workspace, settings, scheduler)

    add_result = _execute_tool(
        registry_a,
        "schedule.add",
        kwargs={"cron": "*/5 * * * *", "message": "from-a"},
    )
    matched = re.match(r"^scheduled: (?P<job_id>[a-z0-9-]+) next=.*$", add_result)
    assert matched is not None

    assert matched.group("job_id") in _execute_tool(registry_b, "schedule.list", kwargs={})


def test_skills_list_uses_latest_runtime_skills(tmp_path: Path, scheduler: BackgroundScheduler) -> None:
    @dataclass(frozen=True)
    class _Skill:
        name: str
        description: str

    class _Runtime:
        def __init__(self, settings: Settings, scheduler: BackgroundScheduler) -> None:
            self.settings = settings
            self.scheduler = scheduler
            self._discovered_skills: list[_Skill] = [_Skill(name="alpha", description="first")]

        def discover_skills(self) -> list[_Skill]:
            return list(self._discovered_skills)

    settings = Settings(_env_file=None, model="openrouter:test")
    runtime = _Runtime(settings, scheduler)
    registry = ToolRegistry()
    register_builtin_tools(
        registry,
        workspace=tmp_path,
        tape=_DummyTape(),  # type: ignore[arg-type]
        runtime=runtime,  # type: ignore[arg-type]
    )

    assert _execute_tool(registry, "skills.list", kwargs={}) == "alpha: first"

    runtime._discovered_skills.append(_Skill(name="beta", description="second"))
    second = _execute_tool(registry, "skills.list", kwargs={})
    assert "alpha: first" in second
    assert "beta: second" in second


def test_bash_tool_inherits_runtime_session_id(
    tmp_path: Path, monkeypatch: Any, scheduler: BackgroundScheduler
) -> None:
    observed: dict[str, object] = {}

    class _Completed:
        returncode = 0

        @staticmethod
        async def communicate() -> tuple[bytes, bytes]:
            return b"ok", b""

    async def _fake_create_subprocess_exec(*args: Any, **kwargs: Any) -> _Completed:
        observed["args"] = args
        observed["kwargs"] = kwargs
        return _Completed()

    monkeypatch.setattr("bub.tools.builtin.asyncio.create_subprocess_exec", _fake_create_subprocess_exec)

    settings = Settings(_env_file=None, model="openrouter:test")
    registry = _build_registry(tmp_path, settings, scheduler)
    result = _execute_tool(registry, "bash", kwargs={"cmd": "echo hi"})

    assert result == "ok"
    kwargs = observed["kwargs"]
    assert isinstance(kwargs, dict)
    assert kwargs["env"]["BUB_SESSION_ID"] == "cli:test"


def test_bash_handles_non_utf8_output(tmp_path: Path, monkeypatch: Any, scheduler: BackgroundScheduler) -> None:
    class _Completed:
        returncode = 0

        @staticmethod
        async def communicate() -> tuple[bytes, bytes]:
            # GBK-encoded bytes that cannot be decoded as UTF-8
            return "微软".encode("gbk"), b""

    async def _fake_create_subprocess_exec(*args: Any, **kwargs: Any) -> _Completed:
        _ = (args, kwargs)
        return _Completed()

    monkeypatch.setattr("bub.tools.builtin.asyncio.create_subprocess_exec", _fake_create_subprocess_exec)

    settings = Settings(_env_file=None, model="openrouter:test")
    registry = _build_registry(tmp_path, settings, scheduler)
    result = _execute_tool(registry, "bash", kwargs={"cmd": "echo hello"})

    # Should contain replacement character instead of raising UnicodeDecodeError
    assert "�" in result


def test_tape_reset_also_clears_session_runtime_context(tmp_path: Path, scheduler: BackgroundScheduler) -> None:
    settings = Settings(_env_file=None, model="openrouter:test")
    runtime = _DummyRuntime(settings, scheduler)
    registry = ToolRegistry()
    register_builtin_tools(
        registry,
        workspace=tmp_path,
        tape=_DummyTape(),  # type: ignore[arg-type]
        runtime=runtime,  # type: ignore[arg-type]
    )

    result = _execute_tool(registry, "tape.reset", kwargs={"archive": True}, session_id="telegram:123")
    assert result == "reset"
    assert runtime.reset_calls == ["telegram:123"]