test(#89): failing tests for review-found follow-up bugs

Adversarial review of the deferred follow-ups confirmed two defects:

- promote_diff reports the wrong checkpoint_step: it self-checkpoints AND is non-exempt, so the decorator appends a trailing empty commit and the backfill names THAT step (observed step_before+2, not the cascade's +1).

- Stage C navigation yanks a focused/mid-edit user, discarding unsaved code — recalcTarget ignores focus, unlike the #27 NewEntryPill policy.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: paddymul

packages/app/src/recalcRefresh.test.ts

@@ -8,19 +8,26 @@ import { recalcTarget } from "./recalcRefresh";
 // hash to refresh — but only that view; an unrelated or older hash stays put.
 describe("recalcTarget", () => {
   it("returns null when no hash is being viewed (catalog index)", () => {
-    expect(recalcTarget(undefined, { old: "new" })).toBeNull();
+    expect(recalcTarget(undefined, { old: "new" }, false)).toBeNull();
   });
 
   it("returns null when there is no remap", () => {
-    expect(recalcTarget("abc", undefined)).toBeNull();
-    expect(recalcTarget("abc", {})).toBeNull();
+    expect(recalcTarget("abc", undefined, false)).toBeNull();
+    expect(recalcTarget("abc", {}, false)).toBeNull();
   });
 
   it("returns null when the viewed hash was not remapped", () => {
-    expect(recalcTarget("abc", { other: "new" })).toBeNull();
+    expect(recalcTarget("abc", { other: "new" }, false)).toBeNull();
   });
 
-  it("returns the recomputed hash when the viewed entry was remapped", () => {
-    expect(recalcTarget("old", { old: "new", x: "y" })).toBe("new");
+  it("returns the recomputed hash for a backgrounded view that was remapped", () => {
+    expect(recalcTarget("old", { old: "new", x: "y" }, false)).toBe("new");
+  });
+
+  // Don't yank a user actively looking at the page (mirrors NewEntryPill / #27):
+  // a focused view — which includes a mid-edit code editor whose unsaved text the
+  // hash-keyed remount would discard — stays put even when its head was remapped.
+  it("returns null when the page is focused, even if the viewed entry was remapped", () => {
+    expect(recalcTarget("old", { old: "new" }, true)).toBeNull();
   });
 });

tests/test_promote_diff.py

@@ -271,6 +271,13 @@ def test_catalog_promote_diff_repoint_cascades_to_follower_atomically(project: s
     assert foll2 != foll  # the follower was recomputed
     assert out["recalc"]["remap"].get(foll) == foll2
 
+    # The reported checkpoint_step names the revision the promote + cascade landed
+    # in, AND it is exactly one revision — promote_diff self-checkpoints, so it
+    # must be checkpoint-exempt; a redundant dispatch-decorator checkpoint would
+    # both append a trailing empty commit and make the report name THAT step.
+    assert out["recalc"]["checkpoint_step"] == step_before + 1
+    assert current_step(project) == step_before + 1
+
     # Atomic: reset_to before the re-promote restores BOTH the diff alias and the follower.
     reset_to(project, step_before)
     assert get_alias(project, "mydiff") == d1