feat(errors): document not found error when parsing non-existent results (#14)

* feat(errors): document not found error when parsing non-existent results

* chore: version bump

Author: gjuchault

lib/model/model.js

@@ -185,7 +185,7 @@ function createModel (requelize) {
        * @param {string} ModelA Model name
        * @param {string} ModelB Model name
        */
-      static customJoinTable(ModelA, ModelB) {
+      static customJoinTable (ModelA, ModelB) {
         Model.index(ModelA)
         Model.index(ModelB)
       }

lib/model/query/query.js

@@ -31,7 +31,13 @@ class Query {
 
     // enable model parsing for query result
     if (this._parse) {
-      q = q.then((res) => this._Model._parse(res))
+      q = q.then((res) => {
+        if (res) {
+          return this._Model._parse(res)
+        } else {
+          return Promise.reject(new RequelizeError('DocumentNotFound'))
+        }
+      })
     }
 
     return q

package.json

@@ -1,6 +1,6 @@
 {
   "name": "requelize",
-  "version": "0.6.0",
+  "version": "0.6.1",
   "description": "RethinkDB ORM",
   "main": "index.js",
   "repository": "https://github.com/buckless/requelize.git",

test/test.errors.js

@@ -0,0 +1,22 @@
+const { test, requelize, dropDb } = require('./utils')
+
+test('document not found error', (t) => {
+  t.plan(2)
+
+  let Foo
+
+  dropDb()
+    .then(() => {
+      Foo = requelize.model('foo')
+
+      return requelize.sync()
+    })
+    .then(() => {
+      return Foo.get('foo').run()
+    })
+    .catch((err) => {
+      t.equal('RequelizeError', err.name)
+      t.equal('DocumentNotFound', err.message)
+      t.end()
+    })
+})