fix(core): premature wallets detection (#743)

Author: tien

.changeset/forty-wombats-look.md

@@ -0,0 +1,5 @@
+---
+"@reactive-dot/core": patch
+---
+
+Fixed an issue where wallets could be detected prematurely before the document finished loading.

packages/core/src/wallets/injected/provider.test.ts

@@ -1,3 +1,4 @@
+// @vitest-environment jsdom
 import { InjectedWalletProvider } from "./provider.js";
 import { InjectedWallet } from "./wallet.js";
 import { getInjectedExtensions } from "polkadot-api/pjs-signer";
@@ -39,3 +40,29 @@ it("should pass options to created wallets", async () => {
   // @ts-expect-error for testing purposes
   expect(wallets[0]?.options).toEqual(options);
 });
+
+it("should wait for load event when document is not complete", async () => {
+  const mockExtensions = ["ext1", "ext2"];
+  vi.mocked(getInjectedExtensions).mockReturnValue(mockExtensions);
+
+  Object.defineProperty(document, "readyState", {
+    value: "loading",
+    configurable: true,
+  });
+
+  const provider = new InjectedWalletProvider();
+  const getWalletsPromise = provider.getWallets();
+
+  await new Promise((resolve) => setImmediate(resolve));
+
+  globalThis.dispatchEvent(new Event("load"));
+
+  const wallets = await getWalletsPromise;
+  expect(getInjectedExtensions).toHaveBeenCalled();
+  expect(wallets).toHaveLength(mockExtensions.length);
+
+  Object.defineProperty(document, "readyState", {
+    value: "complete",
+    configurable: true,
+  });
+});

packages/core/src/wallets/injected/provider.ts

@@ -9,6 +9,12 @@ export class InjectedWalletProvider extends WalletProvider {
   async getWallets() {
     const { getInjectedExtensions } = await import("polkadot-api/pjs-signer");
 
+    if (globalThis.document.readyState !== "complete") {
+      await new Promise<void>((resolve) =>
+        globalThis.addEventListener("load", () => resolve()),
+      );
+    }
+
     return getInjectedExtensions().map(
       (name) => new InjectedWallet(name, this.options),
     );