perf: prefer interface over type alias

Author: tien

.changeset/young-ends-grow.md

@@ -0,0 +1,11 @@
+---
+"@reactive-dot/wallet-polkadot-vault": patch
+"@reactive-dot/wallet-readonly": patch
+"@reactive-dot/wallet-ledger": patch
+"@reactive-dot/wallet-mimir": patch
+"@reactive-dot/react": patch
+"@reactive-dot/core": patch
+"@reactive-dot/vue": patch
+---
+
+Prefer `interface` over `type` alias for object types and use `extends` instead of intersection types (`&`), yielding better TypeScript type-checking performance and more consistent error messages.

examples/react/.papi/descriptors/package.json

@@ -1,15 +1,10 @@
 {
-  "name": "@polkadot-api/descriptors",
   "version": "0.1.0-autogenerated.12798067100670306101",
+  "name": "@polkadot-api/descriptors",
   "files": [
     "dist"
   ],
   "type": "module",
-  "sideEffects": false,
-  "main": "./dist/index.js",
-  "module": "./dist/index.js",
-  "browser": "./dist/index.js",
-  "types": "./dist/index.d.ts",
   "exports": {
     ".": {
       "types": "./dist/index.d.ts",
@@ -19,7 +14,12 @@
     },
     "./package.json": "./package.json"
   },
+  "main": "./dist/index.js",
+  "module": "./dist/index.js",
+  "browser": "./dist/index.js",
+  "types": "./dist/index.d.ts",
+  "sideEffects": false,
   "peerDependencies": {
-    "polkadot-api": ">=2.0.1"
+    "polkadot-api": ">=2.0.0"
   }
 }

examples/react/src/account-select.tsx

@@ -2,9 +2,9 @@ import type { WalletAccount } from "@reactive-dot/core/wallets.js";
 import { useConnectedWallets, useAccounts } from "@reactive-dot/react";
 import { type ReactNode, useState } from "react";
 
-type AccountSelectProps = {
+interface AccountSelectProps {
   children: (account: WalletAccount) => ReactNode;
-};
+}
 
 export function AccountSelect({ children }: AccountSelectProps) {
   const connectedWallets = useConnectedWallets();

examples/react/src/app.tsx

@@ -50,7 +50,9 @@ export function App() {
   );
 }
 
-type ExampleProps = { chainName: string };
+interface ExampleProps {
+  chainName: string;
+}
 
 function Example({ chainName }: ExampleProps) {
   const resetQueryError = useQueryErrorResetter();

examples/react/src/ink-contract.tsx

@@ -17,9 +17,9 @@ export function InkContracts() {
   );
 }
 
-type ContractProps = {
+interface ContractProps {
   address: string;
-};
+}
 
 function Psp22TokenInfo({ address }: ContractProps) {
   const [timestamp, [tokenName, tokenDecimals, tokenSymbol, totalSupply]] = useLazyLoadQuery(

examples/react/src/query.tsx

@@ -121,9 +121,9 @@ function SpendableBalances() {
   );
 }
 
-type SpendableBalanceProps = {
+interface SpendableBalanceProps {
   account: PolkadotAccount;
-};
+}
 
 function SpendableBalance({ account }: SpendableBalanceProps) {
   return (
@@ -180,10 +180,10 @@ function PendingPoolRewards() {
   );
 }
 
-type PendingRewardsProps = {
+interface PendingRewardsProps {
   account: PolkadotAccount;
   rewards: bigint;
-};
+}
 
 function PendingRewards({ account, rewards }: PendingRewardsProps) {
   return (

examples/react/src/wallet-connection.tsx

@@ -27,9 +27,9 @@ export function WalletConnection() {
   );
 }
 
-type WalletItemProps = {
+interface WalletItemProps {
   wallet: Wallet;
-};
+}
 
 function WalletItem({ wallet }: WalletItemProps) {
   const connectedWallets = useConnectedWallets();

examples/vue/.papi/descriptors/package.json

@@ -1,15 +1,10 @@
 {
-  "name": "@polkadot-api/descriptors",
   "version": "0.1.0-autogenerated.12798067100670306101",
+  "name": "@polkadot-api/descriptors",
   "files": [
     "dist"
   ],
   "type": "module",
-  "sideEffects": false,
-  "main": "./dist/index.js",
-  "module": "./dist/index.js",
-  "browser": "./dist/index.js",
-  "types": "./dist/index.d.ts",
   "exports": {
     ".": {
       "types": "./dist/index.d.ts",
@@ -19,7 +14,12 @@
     },
     "./package.json": "./package.json"
   },
+  "main": "./dist/index.js",
+  "module": "./dist/index.js",
+  "browser": "./dist/index.js",
+  "types": "./dist/index.d.ts",
+  "sideEffects": false,
   "peerDependencies": {
-    "polkadot-api": ">=2.0.1"
+    "polkadot-api": ">=2.0.0"
   }
 }

packages/core/src/actions/get-block-extrinsics.ts

@@ -46,11 +46,11 @@ type Extra = Partial<{
   [key: string]: unknown;
 }>;
 
-type Call = {
+interface Call {
   module: string;
   func: string;
   args: unknown;
-};
+}
 
 type Extrinsic = { version: number; call: Call } & (
   | { signed: false }

packages/core/src/actions/get-block.test.ts

@@ -3,7 +3,9 @@ import type { PolkadotClient } from "polkadot-api";
 import { of } from "rxjs";
 import { expect, it } from "vitest";
 
-type DummyBlock = { id: string };
+interface DummyBlock {
+  id: string;
+}
 
 it("should return the best block when options.tag is 'best'", () =>
   new Promise<void>((resolve) => {