fix(core): missing chain spec option (#1180)

Author: tien

.changeset/tasty-rats-show.md

@@ -0,0 +1,5 @@
+---
+"@reactive-dot/core": patch
+---
+
+Added missing `chainSpec` option to `whenAccountsChanged`, bringing parity with `useAccounts` hook/composable.

packages/core/src/apis/when-accounts-changed.test.ts

@@ -5,6 +5,7 @@ import type { PolkadotSignerAccount } from "../wallets/account.js";
 import { Wallet } from "../wallets/wallet.js";
 import { getClient } from "./get-client.js";
 import { whenAccountsChanged } from "./when-accounts-changed.js";
+import type { ChainSpecData } from "@polkadot-api/substrate-client";
 import type { PolkadotClient } from "polkadot-api";
 import { lastValueFrom, Observable } from "rxjs";
 import { afterEach, expect, it, vi } from "vitest";
@@ -65,6 +66,26 @@ it("fetches wallets with chain-spec", () => {
   });
 });
 
+it("uses the provided chainSpec when supplied", async () => {
+  const wallet = new MockWallet();
+  const chainSpec = {
+    name: "Custom",
+    genesisHash: "0x123",
+    properties: { ss58Format: 42 },
+  } as ChainSpecData;
+
+  whenAccountsChanged(defineConfig({ chains: {}, wallets: [wallet] }), {
+    chainSpec,
+  });
+
+  expect(getAccounts).toHaveBeenCalledWith(
+    expect.any(Observable),
+    chainSpec,
+    undefined,
+    undefined,
+  );
+});
+
 it("fetches wallets with EVM accounts", () => {
   const wallet = new MockWallet();
 

packages/core/src/apis/when-accounts-changed.ts

@@ -1,8 +1,10 @@
 import { getAccounts } from "../actions/get-accounts.js";
 import type { InferChainId } from "../chains.js";
 import type { Config } from "../config.js";
+import type { MaybeAsync } from "../types.js";
 import { getClient } from "./get-client.js";
 import { whenWalletsChanged } from "./when-wallets-changed.js";
+import type { ChainSpecData } from "@polkadot-api/substrate-client";
 import { defer } from "rxjs";
 
 /**
@@ -14,19 +16,23 @@ import { defer } from "rxjs";
  */
 export function whenAccountsChanged<TConfig extends Config>(
   config: TConfig,
-  options?: { chainId?: InferChainId<TConfig> },
+  options?: {
+    chainId?: InferChainId<TConfig>;
+    chainSpec?: MaybeAsync<ChainSpecData>;
+  },
 ) {
   const chainId = options?.chainId;
 
   return getAccounts(
     whenWalletsChanged(config),
-    chainId === undefined
-      ? undefined
-      : defer(() =>
-          getClient(config, { chainId }).then((client) =>
-            client.getChainSpecData(),
-          ),
-        ),
+    options?.chainSpec ??
+      (chainId === undefined
+        ? undefined
+        : defer(() =>
+            getClient(config, { chainId }).then((client) =>
+              client.getChainSpecData(),
+            ),
+          )),
     undefined,
     config.includeEvmAccounts === undefined
       ? undefined