perf: prefer interface over type alias

Author: tien

.changeset/young-ends-grow.md

@@ -0,0 +1,11 @@
+---
+"@reactive-dot/wallet-polkadot-vault": patch
+"@reactive-dot/wallet-readonly": patch
+"@reactive-dot/wallet-ledger": patch
+"@reactive-dot/wallet-mimir": patch
+"@reactive-dot/react": patch
+"@reactive-dot/core": patch
+"@reactive-dot/vue": patch
+---
+
+Prefer `interface` over `type` alias for object types and use `extends` instead of intersection types (`&`), yielding better TypeScript type-checking performance and more consistent error messages.

examples/react/src/account-select.tsx

@@ -2,9 +2,9 @@ import type { WalletAccount } from "@reactive-dot/core/wallets.js";
 import { useConnectedWallets, useAccounts } from "@reactive-dot/react";
 import { type ReactNode, useState } from "react";
 
-type AccountSelectProps = {
+interface AccountSelectProps {
   children: (account: WalletAccount) => ReactNode;
-};
+}
 
 export function AccountSelect({ children }: AccountSelectProps) {
   const connectedWallets = useConnectedWallets();

examples/react/src/app.tsx

@@ -50,7 +50,7 @@ export function App() {
   );
 }
 
-type ExampleProps = { chainName: string };
+interface ExampleProps { chainName: string }
 
 function Example({ chainName }: ExampleProps) {
   const resetQueryError = useQueryErrorResetter();

examples/react/src/ink-contract.tsx

@@ -17,9 +17,9 @@ export function InkContracts() {
   );
 }
 
-type ContractProps = {
+interface ContractProps {
   address: string;
-};
+}
 
 function Psp22TokenInfo({ address }: ContractProps) {
   const [timestamp, [tokenName, tokenDecimals, tokenSymbol, totalSupply]] =

examples/react/src/query.tsx

@@ -138,9 +138,9 @@ function SpendableBalances() {
   );
 }
 
-type SpendableBalanceProps = {
+interface SpendableBalanceProps {
   account: PolkadotAccount;
-};
+}
 
 function SpendableBalance({ account }: SpendableBalanceProps) {
   return (
@@ -199,10 +199,10 @@ function PendingPoolRewards() {
   );
 }
 
-type PendingRewardsProps = {
+interface PendingRewardsProps {
   account: PolkadotAccount;
   rewards: bigint;
-};
+}
 
 function PendingRewards({ account, rewards }: PendingRewardsProps) {
   return (

examples/react/src/wallet-connection.tsx

@@ -27,9 +27,9 @@ export function WalletConnection() {
   );
 }
 
-type WalletItemProps = {
+interface WalletItemProps {
   wallet: Wallet;
-};
+}
 
 function WalletItem({ wallet }: WalletItemProps) {
   const connectedWallets = useConnectedWallets();

packages/core/src/actions/get-block-extrinsics.ts

@@ -49,11 +49,11 @@ type Extra = Partial<{
   [key: string]: unknown;
 }>;
 
-type Call = {
+interface Call {
   module: string;
   func: string;
   args: unknown;
-};
+}
 
 type Extrinsic = { version: number; call: Call } & (
   | { signed: false }

packages/core/src/actions/get-block.test.ts

@@ -3,7 +3,7 @@ import type { PolkadotClient } from "polkadot-api";
 import { of } from "rxjs";
 import { expect, it } from "vitest";
 
-type DummyBlock = { id: string };
+interface DummyBlock { id: string }
 
 it("should return the best block when options.tag is 'best'", () =>
   new Promise<void>((resolve) => {

packages/core/src/actions/get-block.ts

@@ -1,9 +1,9 @@
 import type { PolkadotClient } from "polkadot-api";
 import { map } from "rxjs";
 
-export type GetBlockOptions = {
+export interface GetBlockOptions {
   tag?: "best" | "finalized";
-};
+}
 
 export function getBlock<TOptions extends GetBlockOptions>(
   client: PolkadotClient,

packages/core/src/config.ts

@@ -5,20 +5,15 @@ import type { Wallet, WalletProvider } from "./wallets/index.js";
 import type { JsonRpcProvider } from "polkadot-api";
 import type { ChainDefinition } from "polkadot-api";
 
-export type ChainConfig = {
+export interface ChainConfig {
   readonly descriptor: ChainDefinition | UnsafeDescriptor;
   readonly provider: Gettable<JsonRpcProvider | LightClientProvider>;
-};
+}
 
-export type Config<
-  TChains extends Readonly<Record<string, ChainConfig>> = Readonly<
-    Record<string, ChainConfig>
-  >,
-  TTargetChainIds extends Extract<keyof TChains, string>[] = Extract<
-    keyof TChains,
-    string
-  >[],
-> = {
+export interface Config<
+  TChains extends Readonly<Record<string, ChainConfig>> = Readonly<Record<string, ChainConfig>>,
+  TTargetChainIds extends Extract<keyof TChains, string>[] = Extract<keyof TChains, string>[],
+> {
   readonly chains: TChains;
   readonly targetChains?: TTargetChainIds;
   readonly wallets?: Array<WalletProvider | Wallet>;
@@ -36,7 +31,7 @@ export type Config<
    * @defaultValue false
    */
   readonly ssr?: boolean;
-};
+}
 
 export function defineConfig<
   const TChains extends Readonly<Record<string, ChainConfig>>,