#108: params for MS SQL Server

Author: SingingBush

.github/workflows/dub.yml

@@ -223,4 +223,4 @@ jobs:
         env:
           PORT: ${{ job.services.mssql.ports[1433] }}
         run: |
-          ./ddbctest --connection=odbc://127.0.0.1:$PORT --user=SA --password=MSbbk4k77JKH88g54 --driver="ODBC Driver 18 for SQL Server" --trusted_connection=yes
+          ./ddbctest --connection=odbc://127.0.0.1:$PORT --user=SA --password=MSbbk4k77JKH88g54 --driver="ODBC Driver 18 for SQL Server" --trust_server_certificate=yes

example/source/testddbc.d

@@ -82,7 +82,7 @@ struct ConnectionParams
 	string host;
 	ushort port;
 	string database;
-	string trusted_connection; // for MS-SQL can be setto 'yes'
+	string trust_server_certificate; // for MS-SQL can be set to 'yes'
 }
 int main(string[] args)
 {
@@ -102,7 +102,7 @@ int main(string[] args)
 	{
 		getopt(args, "user",&par.user, "password",&par.password, "ssl",&par.ssl, 
 				"connection",&URI, "database",&par.database, "driver",&par.odbcdriver,
-				"trusted_connection",&par.trusted_connection);
+				"trust_server_certificate",&par.trust_server_certificate);
 	}
 	catch (GetOptException)
 	{
@@ -207,7 +207,7 @@ int main(string[] args)
 						// ./ddbctest --connection=ddbc:odbc://localhost --user=SA --password=bbk4k77JKH88g54 --driver=FreeTDS
 						params = ODBCDriver.setUserAndPassword(par.user, par.password);
 						params["driver"] = par.odbcdriver;
-						params["trusted_connection"] = par.trusted_connection;
+						params["trust_server_certificate"] = par.trust_server_certificate;
 						url = ODBCDriver.generateUrl(par.host, par.port, params);
 					}
 				}

source/ddbc/drivers/odbcddbc.d

@@ -424,7 +424,23 @@ version (USE_ODBC)
             addToConnectionString("username", "Uid");
             addToConnectionString("password", "Pwd");
             addToConnectionString("database", "Database");
-            addToConnectionString("trusted_connection", "TrustServerCertificate");
+            addToConnectionString("encrypt", "Encrypt"); // defaults to no
+            addToConnectionString("trusted_connection", "Trusted_Connection");
+            addToConnectionString("trust_server_certificate", "TrustServerCertificate"); // Yes|No
+
+            // other potential params:
+            // addToConnectionString("", "Provider"); // SQLNCLI10 or SQLNCLI11
+            // addToConnectionString("", "Data Source");
+            // addToConnectionString("", "Network Library"); // DBMSSOCN
+            // addToConnectionString("", "Initial Catalog");
+            // addToConnectionString("", "Integrated Security"); // true|false|SSPI
+            // addToConnectionString("", "Asynchronous Processing"); // True|False
+            // addToConnectionString("", "AttachDbFilename");
+            // addToConnectionString("", "Failover Partner");
+            // addToConnectionString("", "Column Encryption Setting"); // enabled;
+            // addToConnectionString("", "Enclave Attestation Url");
+            // addToConnectionString("", "MultipleActiveResultSets"); // true;
+            // addToConnectionString("", "Packet Size"); // 4096; (default is 8192)
             string connectionString = connectionProps.join(';');
 
             info(connectionString);

test/ddbctest/odbctest.d

@@ -26,7 +26,7 @@ version(USE_ODBC) {
             // "ODBC Driver 18 for SQL Server"
             // "FreeTDS"
             super(
-                "odbc://localhost,%s?user=SA,password=MSbbk4k77JKH88g54,trusted_connection=yes,driver=ODBC Driver 18 for SQL Server".format(environment.get("MSSQL_PORT", "1433")), // don't specify database!
+                "odbc://localhost,%s?user=SA,password=MSbbk4k77JKH88g54,trust_server_certificate=yes,driver=ODBC Driver 18 for SQL Server".format(environment.get("MSSQL_PORT", "1433")), // don't specify database!
                 "DROP TABLE IF EXISTS [my_first_test];CREATE TABLE [my_first_test] ([id] INT NOT NULL IDENTITY(1,1) PRIMARY KEY, [name] VARCHAR(255) NOT NULL)",
                 "DROP TABLE IF EXISTS [my_first_test]"
             );
@@ -64,7 +64,7 @@ version(USE_ODBC) {
 
         this() {
             super(
-                "odbc://localhost,%s?user=SA,password=MSbbk4k77JKH88g54,trusted_connection=yes,driver=ODBC Driver 18 for SQL Server".format(environment.get("MSSQL_PORT", "1433")), // don't specify database!
+                "odbc://localhost,%s?user=SA,password=MSbbk4k77JKH88g54,trust_server_certificate=yes,driver=ODBC Driver 18 for SQL Server".format(environment.get("MSSQL_PORT", "1433")), // don't specify database!
                 "CREATE TABLE records (id INT IDENTITY(1, 1) PRIMARY KEY, name VARCHAR(255) NOT NULL)",
                 "DROP TABLE IF EXISTS records"
                 );