move cli functions to its own class

Author: joshedney

…ugin/bugsnag/actions/bundled_cli_path.rb …ne/plugin/bugsnag/actions/bugsnag_cli.rbtools/fastlane-plugin/lib/fastlane/plugin/bugsnag/actions/bundled_cli_path.rb renamed to tools/fastlane-plugin/lib/fastlane/plugin/bugsnag/actions/bugsnag_cli.rb tools/fastlane-plugin/lib/fastlane/plugin/bugsnag/actions/bundled_cli_path.rb renamed to tools/fastlane-plugin/lib/fastlane/plugin/bugsnag/actions/bugsnag_cli.rb

@@ -1,8 +1,26 @@
 require 'os'
 require 'rbconfig'
 
-class BundledCli
-  def self.get_path
+class BugsnagCli
+  def self.get_bugsnag_cli_path(params)
+    bundled_bugsnag_cli_path = self.get_bundled_path
+    bundled_bugsnag_cli_version = Gem::Version.new(`#{bundled_bugsnag_cli_path} --version`.scan(/(?:\d+\.?){3}/).first)
+
+    if params[:bugsnag_cli_path]
+      bugsnag_cli_path = params[:bugsnag_cli_path] || bundled_bugsnag_cli_path
+
+      bugsnag_cli_version = Gem::Version.new(`#{bugsnag_cli_path} --version`.scan(/(?:\d+\.?){3}/).first)
+
+      if bugsnag_cli_version < bundled_bugsnag_cli_version
+        UI.warning("Your bugsnag-cli is outdated. The current bugsnag-cli version is: #{bundled_bugsnag_cli_version}")
+      end
+      bugsnag_cli_path
+    else
+      bundled_bugsnag_cli_path
+    end
+  end
+
+  def self.get_bundled_path
     host_cpu = RbConfig::CONFIG['host_cpu']
     if OS.mac?
       if host_cpu =~ /arm|aarch64/

tools/fastlane-plugin/lib/fastlane/plugin/bugsnag/actions/send_build_to_bugsnag.rb

@@ -1,31 +1,13 @@
 require "xmlsimple"
 require "json"
 require_relative "find_info_plist_path"
-require_relative "bundled_cli_path"
+require_relative "bugsnag_cli"
 
 module Fastlane
   module Actions
     class SendBuildToBugsnagAction < Action
-      def self.get_bugsnag_cli_path(params)
-        bundled_bugsnag_cli_path = BundledCli.get_path
-        bundled_bugsnag_cli_version = Gem::Version.new(`#{bundled_bugsnag_cli_path} --version`.scan(/(?:\d+\.?){3}/).first)
-
-        if params[:bugsnag_cli_path]
-          bugsnag_cli_path = params[:bugsnag_cli_path] || bundled_bugsnag_cli_path
-
-          bugsnag_cli_version = Gem::Version.new(`#{bugsnag_cli_path} --version`.scan(/(?:\d+\.?){3}/).first)
-
-          if bugsnag_cli_version < bundled_bugsnag_cli_version
-            UI.warning("Your bugsnag-cli is outdated. The current bugsnag-cli version is: #{bundled_bugsnag_cli_version}")
-          end
-          bugsnag_cli_path
-        else
-          bundled_bugsnag_cli_path
-        end
-      end
-
       def self.run(params)
-        bugsnag_cli_path = get_bugsnag_cli_path(params)
+        bugsnag_cli_path = BugsnagCli.get_bugsnag_cli_path(params)
         UI.verbose("Using bugsnag-cli from path: #{bugsnag_cli_path}")
 
         payload = {}

tools/fastlane-plugin/lib/fastlane/plugin/bugsnag/actions/upload_symbols_to_bugsnag.rb

@@ -1,30 +1,12 @@
 require_relative "find_info_plist_path"
-require_relative "bundled_cli_path"
+require_relative "bugsnag_cli"
 
 
 module Fastlane
   module Actions
     class UploadSymbolsToBugsnagAction < Action
-      def self.get_bugsnag_cli_path(params)
-        bundled_bugsnag_cli_path = BundledCli.get_path
-        bundled_bugsnag_cli_version = Gem::Version.new(`#{bundled_bugsnag_cli_path} --version`.scan(/(?:\d+\.?){3}/).first)
-
-        if params[:bugsnag_cli_path]
-          bugsnag_cli_path = params[:bugsnag_cli_path] || bundled_bugsnag_cli_path
-
-          bugsnag_cli_version = Gem::Version.new(`#{bugsnag_cli_path} --version`.scan(/(?:\d+\.?){3}/).first)
-
-          if bugsnag_cli_version < bundled_bugsnag_cli_version
-            UI.warning("Your bugsnag-cli is outdated. The current bugsnag-cli version is: #{bundled_bugsnag_cli_version}")
-          end
-          bugsnag_cli_path
-        else
-          bundled_bugsnag_cli_path
-        end
-      end
-
       def self.run(params)
-        bugsnag_cli_path = get_bugsnag_cli_path(params)
+        bugsnag_cli_path = BugsnagCli.get_bugsnag_cli_path(params)
         UI.verbose("Using bugsnag-cli from path: #{bugsnag_cli_path}")
 
         # If we have not explicitly set an API key through env, or parameter

tools/fastlane-plugin/spec/bugsnag_upload_dsym_action_spec.rb

@@ -1,8 +1,8 @@
 require 'spec_helper'
-require_relative '../lib/fastlane/plugin/bugsnag/actions/bundled_cli_path'
+require_relative '../lib/fastlane/plugin/bugsnag/actions/bugsnag_cli'
 
 Action = Fastlane::Actions::UploadSymbolsToBugsnagAction
-BUGSNAG_CLI_PATH = BundledCli.get_path
+BUGSNAG_CLI_PATH = BugsnagCli.get_bundled_path
 
 describe Action do
   def run_with args

tools/fastlane-plugin/spec/send_build_to_bugsnag_spec.rb

@@ -1,11 +1,11 @@
 require 'spec_helper'
 require 'json'
 require 'fastlane/actions/get_info_plist_value'
-require_relative '../lib/fastlane/plugin/bugsnag/actions/bundled_cli_path'
+require_relative '../lib/fastlane/plugin/bugsnag/actions/bugsnag_cli'
 
 
 BuildAction = Fastlane::Actions::SendBuildToBugsnagAction
-BUGSNAG_CLI_PATH = BundledCli.get_path
+BUGSNAG_CLI_PATH = BugsnagCli.get_bundled_path
 
 
 describe BuildAction do