add tests for checking the version of the CLI we are using

Author: joshedney

tools/fastlane-plugin/lib/fastlane/plugin/bugsnag/actions/upload_symbols_to_bugsnag.rb

@@ -16,7 +16,7 @@ def self.get_bugsnag_cli_path(params)
           bugsnag_cli_version = Gem::Version.new(`#{bugsnag_cli_path} --version`.scan(/(?:\d+\.?){3}/).first)
 
           if bugsnag_cli_version < bundled_bugsnag_cli_version
-            UI.user_error!("Your bugsnag-cli is outdated, please upgrade to at least version #{bundled_bugsnag_cli_version} and start your lane again!")
+            UI.warning("Your bugsnag-cli is outdated. The current bugsnag-cli version is: #{bundled_bugsnag_cli_version}")
           end
           bugsnag_cli_path
         else

tools/fastlane-plugin/spec/bugsnag_upload_dsym_action_spec.rb

@@ -159,5 +159,30 @@ def run_with args
       expect(Kernel).to receive(:system).with("#{custom_cli_path} upload dsym --api-key #{api_key} --project-root #{Dir::pwd} \"#{FIXTURE_PATH}\"").and_return(true)
       run_with({dsym_path: FIXTURE_PATH, api_key: api_key, bugsnag_cli_path: custom_cli_path})
     end
+
+    it 'logs a warning when using an outdated CLI version' do
+      cli_path = File.join(FIXTURE_PATH, 'dummy_bugsnag_cli.sh')
+      bundled_bugsnag_cli_version = `#{BUGSNAG_CLI_PATH} --version`.strip
+      allow(Fastlane::Actions::UploadSymbolsToBugsnagAction).to receive(:version_from_cli).and_return("1.0.0")
+      allow(Fastlane::Actions::UploadSymbolsToBugsnagAction).to receive(:bundled_bugsnag_cli_version).and_return(bundled_bugsnag_cli_version)
+
+      expect(Fastlane::UI).to receive(:warning).with("Your bugsnag-cli is outdated. The current bugsnag-cli version is: #{bundled_bugsnag_cli_version}")
+      expect(Kernel).to receive(:system).with("#{cli_path} upload dsym --project-root #{Dir::pwd} \"#{FIXTURE_PATH}\"").and_return(true)
+
+      run_with({dsym_path: FIXTURE_PATH, bugsnag_cli_path: cli_path})
+    end
+
+    it 'logs doesnt log a  warning when using an newer CLI version' do
+      cli_version = "9.9.9"
+      cli_path = File.join(FIXTURE_PATH, 'dummy_bugsnag_cli.sh')
+      bundled_bugsnag_cli_version = `#{BUGSNAG_CLI_PATH} --version`.strip
+      allow(Fastlane::Actions::UploadSymbolsToBugsnagAction).to receive(:version_from_cli).and_return(cli_version)
+      allow(Fastlane::Actions::UploadSymbolsToBugsnagAction).to receive(:bundled_bugsnag_cli_version).and_return(bundled_bugsnag_cli_version)
+
+      expect(Fastlane::UI).not_to receive(:warning)
+
+      ENV['BUGSNAG_CLI_VERSION'] = cli_version
+      run_with({dsym_path: FIXTURE_PATH, bugsnag_cli_path: cli_path})
+    end
   end
 end

tools/fastlane-plugin/spec/fixtures/dummy_bugsnag_cli.sh

@@ -0,0 +1,13 @@
+#!/bin/bash
+
+VERSION="1.0.0"
+
+if [[ -n "$BUGSNAG_CLI_VERSION" ]]; then
+  VERSION="$BUGSNAG_CLI_VERSION"
+fi
+
+if [[ "$1" == "--version" ]]; then
+  echo "Version: $VERSION"
+else
+  echo "Usage: $0 [VERSION=x.y.z] --version"
+fi