fix http errors testing

Author: gingerbenw

bin/local-test-util

@@ -121,7 +121,7 @@ async function buildNotifiers (notifier) {
 async function packNotifiers (notifier) {
   const notifiers = notifier
     ? [ notifier ]
-    : [ 'js', 'browser', 'node', 'web-worker', 'plugin-angular', 'plugin-react', 'plugin-vue' ]
+    : [ 'js', 'browser', 'node', 'web-worker', 'plugin-angular', 'plugin-react', 'plugin-vue', 'plugin-http-errors' ]
   for (const n of notifiers) {
     let packageLocation = `packages/${n}/`
     if (n === 'plugin-angular') packageLocation += 'dist/'
@@ -131,7 +131,7 @@ async function packNotifiers (notifier) {
 
 async function installNotifiers (notifier) {
   trace('install notifiers')
-  if (notifier && ![ 'browser', 'plugin-vue', 'plugin-react', 'web-worker' ].includes(notifier)) return
+  if (notifier && ![ 'browser', 'plugin-vue', 'plugin-react', 'web-worker', 'plugin-http-errors' ].includes(notifier)) return
   await ex(`npm`, [
     `install`,
     `--no-package-lock`,
@@ -144,7 +144,8 @@ async function installNotifiers (notifier) {
       `../../../../bugsnag-browser-${require('../packages/browser/package.json').version}.tgz`,
       `../../../../bugsnag-web-worker-${require('../packages/web-worker/package.json').version}.tgz`,
       `../../../../bugsnag-plugin-react-${require('../packages/plugin-react/package.json').version}.tgz`,
-      `../../../../bugsnag-plugin-vue-${require('../packages/plugin-vue/package.json').version}.tgz`
+      `../../../../bugsnag-plugin-vue-${require('../packages/plugin-vue/package.json').version}.tgz`,
+      `../../../../bugsnag-plugin-http-errors-${require('../packages/plugin-http-errors/package.json').version}.tgz`
     ]
   ), {
     cwd: `${__dirname}/../test/browser/features/fixtures`

packages/plugin-http-errors/http-errors.js

@@ -178,28 +178,43 @@ module.exports = (config = {}, global = window) => {
         // Extract request body
         let requestBody = ''
         let requestBodyLength = 0
-        if (startContext && startContext.body) {
-          const bodyStr = typeof startContext.body === 'string' ? startContext.body : String(startContext.body)
-          requestBodyLength = bodyStr.length
+        const initialBody = startContext.init?.body || startContext.body
+        if (initialBody) {
+          const bodyStr = String(initialBody)
           requestBody = truncate(bodyStr, maxRequestSize)
+          requestBodyLength = bodyStr.length
+        }
+
+        // Extract response body
+        let responseBody
+        let responseBodyLength
+        if (endContext.xhr && endContext.xhr.responseText) {
+          responseBody = truncate(endContext.xhr.responseText, maxRequestSize)
+          responseBodyLength = endContext.xhr.responseText.length
+        }
+
+        // Extract response headers
+        let responseHeaders = {}
+        if (endContext.response && endContext.response.headers) {
+          responseHeaders = headersToObject(endContext.response.headers)
+        } else if (endContext.xhr && typeof endContext.xhr.getAllResponseHeaders === 'function') {
+          responseHeaders = responseHeadersToObject(endContext.xhr.getAllResponseHeaders())
         }
 
         // Create request and response objects for callback
         const requestObj = {
           url,
           httpMethod: method,
-          headers: headersToObject(startContext && startContext.xhr && startContext.xhr._requestHeaders),
+          headers: headersToObject(startContext.xhr?._requestHeaders || startContext.init?.headers),
           params: parseQueryParams(url),
           body: requestBody,
           bodyLength: requestBodyLength
         }
-
-        const responseHeaders = endContext.xhr.getAllResponseHeaders()
         const responseObj = {
           statusCode: endContext.status,
-          headers: responseHeadersToObject(responseHeaders),
-          body: endContext.xhr.responseText,
-          bodyLength: endContext.xhr.responseText ? endContext.xhr.responseText.length : 0
+          headers: responseHeaders,
+          body: responseBody,
+          bodyLength: responseBodyLength
         }
 
         // Call onHttpError callback if provided

packages/plugin-http-errors/test/http-errors-xhr.test.ts

@@ -165,12 +165,12 @@ describe('plugin-http-errors', () => {
       expect(event.response.bodyLength).toBe(xhr.responseText.length)
     })
 
-    it('should truncate XHR response body when it exceeds maxResponseSize', async () => {
+    it('should truncate XHR response body when it exceeds maxRequestSize', async () => {
       const notifyCallbacks: Event[] = []
 
       plugin = createPlugin({
         httpErrorCodes: { min: 400, max: 499 },
-        maxResponseSize: 20
+        maxRequestSize: 20
       })
 
       const client = new Client({ apiKey: 'api_key', plugins: [plugin] })
@@ -179,7 +179,7 @@ describe('plugin-http-errors', () => {
       // Create and configure XHR with large response body
       const xhr = new XMLHttpRequest() as any
       const largeResponseBody = 'A'.repeat(100)
-      xhr.status = 500
+      xhr.status = 404
       xhr.statusText = 'Internal Server Error'
       xhr.responseURL = 'https://api.example.com/error'
       xhr.response = largeResponseBody
@@ -188,6 +188,7 @@ describe('plugin-http-errors', () => {
       xhr.open('GET', 'https://api.example.com/error')
       xhr.send()
 
+      // Wait for async processing
       await new Promise(resolve => setTimeout(resolve, 20))
 
       expect(notifyCallbacks.length).toBe(1)

test/browser/features/fixtures/http_errors/index.html

@@ -2,7 +2,7 @@
 <html>
   <head>
     <meta charset="utf-8" />
-    <title>HTTP Errors - Fetch</title>
+    <title>HTTP Errors</title>
   </head>
   <body>
     <div id="root"></div>

test/browser/features/http_errors.feature

@@ -27,8 +27,10 @@ Feature: HTTP Errors
 
     And the event "response.statusCode" equals 404
     And the event "response.headers.content-length" equals "37"
-    # response.body is not reported for fetch requests
-    # response.bodyLength is not reported for fetch requests
+    
+    # Response body is not captured for fetch requests
+    And the event "response.body" is null
+    And the event "response.bodyLength" is null
 
   Scenario: XML HTTP Request
     When I navigate to the test URL "/http_errors?request=xhr"
@@ -54,6 +56,6 @@ Feature: HTTP Errors
 
     And the event "response.statusCode" equals 404
     And the event "response.headers.content-length" equals "37"
-    And the event "response.body" equals ""
+    And the event "response.body" equals "Returned status 404 after waiting  ms"
     And the event "response.bodyLength" equals 37