Release v3.23.1

Author: imjoehaines

.github/workflows/test-package.yml

@@ -0,0 +1,40 @@
+name: test
+
+on: [ push, pull_request ]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        php-version: [ 5.5, 5.6, 7.0, 7.1, 7.2, 7.3, 7.4 ]
+        guzzle-version: [ '^5.3', '^6.0' ]
+        include:
+        - php-version: 7.2
+          guzzle-version: '^7.0'
+        - php-version: 7.3
+          guzzle-version: '^7.0'
+        - php-version: 7.4
+          guzzle-version: '^7.0'
+        - php-version: 8.0
+          guzzle-version: '^7.0'
+          composer-flags: '--ignore-platform-reqs'
+
+    steps:
+    - uses: actions/checkout@v2
+
+    - name: install PHP
+      uses: shivammathur/setup-php@v2
+      with:
+        php-version: ${{ matrix.php-version }}
+
+    - run: composer validate
+
+    - name: require guzzle
+      run: composer require "guzzlehttp/guzzle:${{ matrix.guzzle-version }}" --no-update ${{ matrix.composer-flags }}
+
+    - name: install dependencies
+      run: composer update --prefer-dist --no-progress --no-suggest --no-interaction ${{ matrix.composer-flags }}
+
+    - run: composer run-script test

.gitignore

@@ -3,3 +3,4 @@ vendor
 /composer.lock
 /composer.phar
 /.idea
+.phpunit.result.cache

.travis.yml

@@ -1,6 +1,27 @@
 Changelog
 =========
 
+## 3.23.1 (2020-10-19)
+
+This release fixes several issues with Bugsnag's error handlers that caused it to affect the behaviour of shutdown functions ([#475](https://github.com/bugsnag/bugsnag-php/issues/475)) and CLI script exit codes ([#523](https://github.com/bugsnag/bugsnag-php/issues/523)). This does not apply if you are using the Laravel or Symfony integrations, as they use separate methods of error handling.
+
+These bugs have been fixed and so registering Bugsnag's error handlers should not cause any change to PHP's default behaviour. Make sure that [PHP's `display_errors` option](https://www.php.net/manual/en/errorfunc.configuration.php#ini.display-errors) is disabled in production environments, as exceptions and errors will now go through PHP's default handling.
+
+### Fixes
+
+* The previous error and exception handler will now always be called
+
+* Exceptions raised by the previous exception handler will now be reported
+
+* The default PHP exception handler will now be called, unless this is prevented by a previous exception handler
+
+* Avoid calling `method_exists` on non-objects
+  [#603](https://github.com/bugsnag/bugsnag-php/pull/603)
+
+### Deprecations
+
+* `Bugsnag\Handler::registerWithPrevious` has been deprecated as calling previous error/exception handlers is now the default behaviour. Calls to `registerWithPrevious` can be safely replaced with `Bugsnag\Handler::register`
+
 ## 3.23.0 (2020-09-14)
 
 ### Enhancements

CHANGELOG.md

@@ -16,11 +16,9 @@
         "guzzlehttp/guzzle": "^5.0|^6.0|^7.0"
     },
     "require-dev": {
-        "graham-campbell/testbench-core": "^1.1",
         "guzzlehttp/psr7": "^1.3",
-        "mockery/mockery": "^0.9.4|^1.3.1",
         "mtdowling/burgomaster": "dev-master#72151eddf5f0cf101502b94bf5031f9c53501a04",
-        "phpunit/phpunit": "^4.8.36|^7.5.15",
+        "phpunit/phpunit": "^4.8.36|^7.5.15|^9.3.10",
         "php-mock/php-mock-phpunit": "^1.1|^2.1",
         "sebastian/version": ">=1.0.3"
     },
@@ -39,6 +37,9 @@
             "dev-master": "3.20-dev"
         }
     },
+    "scripts": {
+        "test": "vendor/bin/phpunit"
+    },
     "minimum-stability": "dev",
     "prefer-stable": true
 }

composer.json

@@ -1,29 +1,32 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit backupGlobals="false"
-         backupStaticAttributes="false"
-         beStrictAboutTestsThatDoNotTestAnything="true"
-         beStrictAboutOutputDuringTests="true"
-         bootstrap="vendor/autoload.php"
-         colors="true"
-         convertErrorsToExceptions="true"
-         convertNoticesToExceptions="true"
-         convertWarningsToExceptions="true"
-         failOnRisky="true"
-         failOnWarning="true"
-         processIsolation="false"
-         stopOnError="false"
-         stopOnFailure="false"
-         verbose="true"
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"
+    backupGlobals="false"
+    backupStaticAttributes="false"
+    beStrictAboutTestsThatDoNotTestAnything="true"
+    beStrictAboutOutputDuringTests="true"
+    bootstrap="vendor/autoload.php"
+    colors="true"
+    convertErrorsToExceptions="true"
+    convertNoticesToExceptions="true"
+    convertWarningsToExceptions="true"
+    failOnRisky="true"
+    failOnWarning="true"
+    processIsolation="false"
+    stopOnError="false"
+    stopOnFailure="false"
+    verbose="true"
 >
+    <coverage processUncoveredFiles="true">
+        <include>
+            <directory suffix=".php">./src</directory>
+        </include>
+    </coverage>
+
     <testsuites>
         <testsuite name="Bugsnag PHP Test Suite">
             <directory suffix="Test.php">./tests</directory>
             <directory suffix=".phpt">./tests/phpt</directory>
         </testsuite>
     </testsuites>
-    <filter>
-        <whitelist processUncoveredFilesFromWhitelist="true">
-            <directory suffix=".php">./src</directory>
-        </whitelist>
-    </filter>
 </phpunit>

phpunit.xml.dist

@@ -201,7 +201,7 @@ private function syncNotifyEndpointWithGuzzleBaseUri(
 
         $base = $this->getGuzzleBaseUri($guzzle);
 
-        if (is_string($base) || method_exists($base, '__toString')) {
+        if (is_string($base) || (is_object($base) && method_exists($base, '__toString'))) {
             $configuration->setNotifyEndpoint((string) $base);
         }
     }

src/Client.php

@@ -82,7 +82,7 @@ class Configuration
      */
     protected $notifier = [
         'name' => 'Bugsnag PHP (Official)',
-        'version' => '3.23.0',
+        'version' => '3.23.1',
         'url' => 'https://bugsnag.com',
     ];