Allow all users to see the same script instances and history

[muxout]

Hi,

Would it be OK to add an option to the script configuration where all users share the same script instances?
This would be helpful in a case where we don't want an user to start a new script instance when another is already running the script. This also allows multiple users to monitor the script process for long running scripts.

Cheers

[bugy]

Hi @muxout, just to double check:

• do you want to allow any user to see active executions? Or only specific ones
• would it be applied to some specific scripts, or to all the scripts on a server?

But I also have to say, that I don't have too much time to work on new features now, so I won't be able to implement this in the nearest future.

[muxout]

Thanks for the fast response.

• Allow any user to see active executions
• I think an option in the script configuration would be more flexible, so it can be applied to specific scripts

Maybe I can have a go at this and submit a PR

[bugy]

Hi @muxout for sure, you can go with a PR. But it might be not an easy one.
How I see it: we would need to have a new script configuration section:

"access": {
  "shared_access": {
    "type": "ALL_USERS"
  }
}

In the future, we could extend this configuration, to allow only shared access for the users within the same group, or for predefined list of users, or anything else.

[muxout]

Makes sense. I'll have a go.
By the way, is there any instructions or tips on running the unit tests locally?

[bugy]

Hi @muxout, I run those on CI using the following command:
python3 -m unittest discover -s tests -p "*.py" -t .

On my local machine I just run them via pycharm

[muxout]

Cheers @bugy. Can you give me permissions to create a new branch so I can submit a PR?

[bugy]

Hi @muxout sorry for delay. I added you to collaborators, could you retry?