Command - refactor to use typed interfaces to implement commands for `policies`

[nazmulidris]

Following the refactoring of RPC calls, we can now implement all commands using typed interfaces and implemented with a specific RPC client.

For example the Projects trait provides an access to projects, to create/list/delete them. That trait is implemented by the Controller client by making requests to the controller.

The use of the Projects interface can be seen in the following command to create projects.

Desired behavior

Provide similar interfaces for all other commands and remove all the "api helpers" from the ockam_command crate for the following:

• policies

All the interfaces and implementations must be part of the ockam_api crate so that the purpose of the ockam_command is only to:

• get and validate arguments from the command line
• call the ockam_api crate
• display progress / reports / outputs / errors

Note

Related epic: #6310

---

We love helping new contributors! ❤️
If you have questions or need help as you explore, please join us on Discord. If you're looking for other issues to contribute to, please checkout our good first issues.

[rjtch]

@nazmulidris can i take this?

[nazmulidris]

@rjtch That's awesome, this is all yours. Please let us know if you have any questions as you explore. You can also ask questions on the contributors discord https://discord.gg/RAbjRr3kds

[rjtch]

@nazmulidris should I use the Policy and PolicyList (ockam_api/node/models/policy) objects for the policy controller in the Ockham_api/cloud? I would maybe move it there because I don't want to re-implement the trait for the Output interface again. Or what do u suggest?

[nazmulidris]

@rjtch Let's wait for @etorreborre to weigh in here. He will be back next week, so we should get some response from him then.

[rjtch]

Hey @etorreborre could you give me your opinion about my last proposition

[etorreborre]

Hi @rjtch, sorry for the delay, I was sick yesterday (and still not great today...).

I'm not sure I understand your question. What do you want to move, from where to where exactly?
One thing to consider, if that helps, is that you can always create a newtype wrapper around a given type if you need a specific Output instance. This is what we do here for example.

[rjtch]

Hi @rjtch, sorry for the delay, I was sick yesterday (and still not great today...).

I'm not sure I understand your question. What do you want to move, from where to where exactly? One thing to consider, if that helps, is that you can always create a newtype wrapper around a given type if you need a specific Output instance. This is what we do here for example.

Hi @etorreborre my question is the following: there is already a policy and a policyList struct located here Ockham_api/nodes/models/policy.rs and I wanted to know if it is a good idea to reuse it or to I should rather create a wrapper around it?

[etorreborre]

Yes the idea is to use those data structures directly