Skip to content

Commit 2e4077a

Browse files
committed
Upgrade to the latest version of bb-browser
While there, make Protobuf import prefixes consistent with the rest of the Buildbarn projects.
1 parent 823deb2 commit 2e4077a

File tree

14 files changed

+384
-343
lines changed

14 files changed

+384
-343
lines changed

.bazelversion

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
8.3.1
1+
8.4.1

BUILD.bazel

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,20 +3,13 @@ load("@gazelle//:def.bzl", "gazelle")
33

44
# gazelle:go_naming_convention_external import
55
# gazelle:prefix github.com/buildbarn/bb-browser
6+
# gazelle:proto_import_prefix github.com/buildbarn/bb-browser
67
# gazelle:resolve go github.com/bazelbuild/remote-apis/build/bazel/remote/execution/v2 @bazel_remote_apis//build/bazel/remote/execution/v2:remote_execution_go_proto
78
# gazelle:resolve go github.com/bazelbuild/remote-apis/build/bazel/semver @bazel_remote_apis//build/bazel/semver:semver_go_proto
89
# gazelle:resolve proto build/bazel/remote/execution/v2/remote_execution.proto @bazel_remote_apis//build/bazel/remote/execution/v2:remote_execution_proto
910
# gazelle:resolve proto go build/bazel/remote/execution/v2/remote_execution.proto @bazel_remote_apis//build/bazel/remote/execution/v2:remote_execution_go_proto
10-
# gazelle:resolve proto pkg/proto/configuration/auth/auth.proto @com_github_buildbarn_bb_storage//pkg/proto/configuration/auth:auth_proto
11-
# gazelle:resolve proto go pkg/proto/configuration/auth/auth.proto @com_github_buildbarn_bb_storage//pkg/proto/configuration/auth
12-
# gazelle:resolve proto pkg/proto/configuration/blobstore/blobstore.proto @com_github_buildbarn_bb_storage//pkg/proto/configuration/blobstore:blobstore_proto
13-
# gazelle:resolve proto go pkg/proto/configuration/blobstore/blobstore.proto @com_github_buildbarn_bb_storage//pkg/proto/configuration/blobstore
14-
# gazelle:resolve proto pkg/proto/configuration/global/global.proto @com_github_buildbarn_bb_storage//pkg/proto/configuration/global:global_proto
15-
# gazelle:resolve proto go pkg/proto/configuration/global/global.proto @com_github_buildbarn_bb_storage//pkg/proto/configuration/global
16-
# gazelle:resolve proto pkg/proto/configuration/http/http.proto @com_github_buildbarn_bb_storage//pkg/proto/configuration/http:http_proto
17-
# gazelle:resolve proto go pkg/proto/configuration/http/http.proto @com_github_buildbarn_bb_storage//pkg/proto/configuration/http
18-
# gazelle:resolve proto pkg/proto/configuration/jmespath/jmespath.proto @com_github_buildbarn_bb_storage//pkg/proto/configuration/jmespath:jmespath_proto
19-
# gazelle:resolve proto go pkg/proto/configuration/jmespath/jmespath.proto @com_github_buildbarn_bb_storage//pkg/proto/configuration/jmespath
11+
# gazelle:resolve_regexp proto github.com/buildbarn/bb-storage/(.*)/(.*)\.proto @com_github_buildbarn_bb_storage//$1:${2}_proto
12+
# gazelle:resolve_regexp proto go github.com/buildbarn/bb-storage/(.*)/(.*)\.proto @com_github_buildbarn_bb_storage//$1:$2
2013
gazelle(
2114
name = "gazelle",
2215
)

MODULE.bazel

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
module(name = "com_github_buildbarn_bb_browser")
22

3-
bazel_dep(name = "aspect_bazel_lib", version = "2.20.0")
4-
bazel_dep(name = "aspect_rules_js", version = "2.4.2")
3+
bazel_dep(name = "aspect_bazel_lib", version = "2.21.2")
4+
bazel_dep(name = "aspect_rules_js", version = "2.6.0")
55
bazel_dep(name = "bazel_remote_apis", version = "0.0.0")
66
bazel_dep(name = "com_github_buildbarn_bb_remote_execution")
77
bazel_dep(name = "com_github_buildbarn_bb_storage")
88
bazel_dep(name = "com_github_buildbarn_go_xdr")
99
bazel_dep(name = "gazelle", version = "0.45.0")
1010
bazel_dep(name = "platforms", version = "1.0.0")
11-
bazel_dep(name = "toolchains_protoc", version = "0.4.3") # must come BEFORE protobuf so the toolchain registration wins
11+
bazel_dep(name = "toolchains_protoc", version = "0.5.0") # must come BEFORE protobuf so the toolchain registration wins
1212
bazel_dep(name = "protobuf", version = "31.1")
13-
bazel_dep(name = "rules_go", version = "0.56.1")
13+
bazel_dep(name = "rules_go", version = "0.57.0")
1414
bazel_dep(name = "rules_jsonnet", version = "0.7.2")
1515
bazel_dep(name = "rules_proto", version = "7.1.0")
16-
bazel_dep(name = "toolchains_llvm", version = "1.4.0")
16+
bazel_dep(name = "toolchains_llvm", version = "1.5.0")
1717

1818
git_override(
1919
module_name = "bazel_remote_apis",
@@ -23,13 +23,13 @@ git_override(
2323

2424
git_override(
2525
module_name = "com_github_buildbarn_bb_remote_execution",
26-
commit = "efef252cdf4f97cc0154ea02976ed1322587e599",
26+
commit = "78a187fdbd351f57e3db9e31e3f59161eca26b17",
2727
remote = "https://github.com/buildbarn/bb-remote-execution.git",
2828
)
2929

3030
git_override(
3131
module_name = "com_github_buildbarn_bb_storage",
32-
commit = "5bae58446505a87d0f3249a5d97accb9b47f3c88",
32+
commit = "1170df56abab658861ba90c0e57b58ed14b721a2",
3333
remote = "https://github.com/buildbarn/bb-storage.git",
3434
)
3535

MODULE.bazel.lock

Lines changed: 92 additions & 40 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cmd/bb_browser/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ go_library(
4747
"@com_github_buildbarn_bb_storage//pkg/digest",
4848
"@com_github_buildbarn_bb_storage//pkg/filesystem/path",
4949
"@com_github_buildbarn_bb_storage//pkg/global",
50-
"@com_github_buildbarn_bb_storage//pkg/http",
50+
"@com_github_buildbarn_bb_storage//pkg/http/server",
5151
"@com_github_buildbarn_bb_storage//pkg/jmespath",
5252
"@com_github_buildbarn_bb_storage//pkg/program",
5353
"@com_github_buildbarn_bb_storage//pkg/proto/auth",

cmd/bb_browser/browser_service.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import (
2626
"github.com/buildbarn/bb-storage/pkg/blobstore"
2727
"github.com/buildbarn/bb-storage/pkg/digest"
2828
"github.com/buildbarn/bb-storage/pkg/filesystem/path"
29-
bb_http "github.com/buildbarn/bb-storage/pkg/http"
29+
http_server "github.com/buildbarn/bb-storage/pkg/http/server"
3030
"github.com/buildbarn/bb-storage/pkg/proto/fsac"
3131
"github.com/buildbarn/bb-storage/pkg/proto/iscc"
3232
"github.com/buildbarn/bb-storage/pkg/util"
@@ -136,7 +136,7 @@ var (
136136

137137
func (s *BrowserService) renderError(w http.ResponseWriter, err error) {
138138
st := status.Convert(err)
139-
w.WriteHeader(bb_http.StatusCodeFromGRPCCode(st.Code()))
139+
w.WriteHeader(http_server.StatusCodeFromGRPCCode(st.Code()))
140140
w.Header().Set("X-Content-Type-Options", "nosniff")
141141
if err := s.templates.ExecuteTemplate(w, "error.html", st); err != nil {
142142
log.Print(err)

cmd/bb_browser/main.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import (
2020
"github.com/buildbarn/bb-storage/pkg/clock"
2121
"github.com/buildbarn/bb-storage/pkg/digest"
2222
"github.com/buildbarn/bb-storage/pkg/global"
23-
"github.com/buildbarn/bb-storage/pkg/http"
23+
http_server "github.com/buildbarn/bb-storage/pkg/http/server"
2424
"github.com/buildbarn/bb-storage/pkg/jmespath"
2525
"github.com/buildbarn/bb-storage/pkg/program"
2626
auth_pb "github.com/buildbarn/bb-storage/pkg/proto/auth"
@@ -313,9 +313,9 @@ func main() {
313313
templates,
314314
bbClientdInstanceNamePatcher,
315315
subrouter)
316-
http.NewServersFromConfigurationAndServe(
316+
http_server.NewServersFromConfigurationAndServe(
317317
configuration.HttpServers,
318-
http.NewMetricsHandler(router, "BrowserUI"),
318+
http_server.NewMetricsHandler(router, "BrowserUI"),
319319
siblingsGroup,
320320
grpcClientFactory,
321321
)

go.mod

Lines changed: 65 additions & 68 deletions
Original file line numberDiff line numberDiff line change
@@ -1,63 +1,62 @@
11
module github.com/buildbarn/bb-browser
22

3-
go 1.24.5
3+
go 1.24.7
44

55
require (
6-
github.com/bazelbuild/buildtools v0.0.0-20250715102656-62b9413b08bb
7-
github.com/bazelbuild/remote-apis v0.0.0-20250728120203-e94a7ece2a1e
8-
github.com/buildbarn/bb-remote-execution v0.0.0-20250820081613-efef252cdf4f
9-
github.com/buildbarn/bb-storage v0.0.0-20250820101750-5bae58446505
6+
github.com/bazelbuild/buildtools v0.0.0-20250926132224-6c4b75d79427
7+
github.com/bazelbuild/remote-apis v0.0.0-20250915115802-824e1ba94b2d
8+
github.com/buildbarn/bb-remote-execution v0.0.0-20250929111506-78a187fdbd35
9+
github.com/buildbarn/bb-storage v0.0.0-20250929074734-1170df56abab
1010
github.com/buildkite/terminal-to-html v3.2.0+incompatible
1111
github.com/dustin/go-humanize v1.0.1
1212
github.com/gorilla/mux v1.8.1
1313
github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
1414
golang.org/x/lint v0.0.0-20241112194109-818c5a804067
1515
gonum.org/v1/plot v0.16.0
16-
google.golang.org/grpc v1.74.2
17-
google.golang.org/protobuf v1.36.7
18-
mvdan.cc/gofumpt v0.8.0
16+
google.golang.org/grpc v1.75.1
17+
google.golang.org/protobuf v1.36.9
18+
mvdan.cc/gofumpt v0.9.1
1919
)
2020

2121
require (
2222
cel.dev/expr v0.24.0 // indirect
23-
cloud.google.com/go v0.121.6 // indirect
23+
cloud.google.com/go v0.123.0 // indirect
2424
cloud.google.com/go/auth v0.16.5 // indirect
2525
cloud.google.com/go/auth/oauth2adapt v0.2.8 // indirect
26-
cloud.google.com/go/compute/metadata v0.8.0 // indirect
26+
cloud.google.com/go/compute/metadata v0.9.0 // indirect
2727
cloud.google.com/go/iam v1.5.2 // indirect
2828
cloud.google.com/go/longrunning v0.6.7 // indirect
2929
cloud.google.com/go/monitoring v1.24.2 // indirect
30-
cloud.google.com/go/storage v1.56.0 // indirect
30+
cloud.google.com/go/storage v1.57.0 // indirect
3131
codeberg.org/go-fonts/liberation v0.5.0 // indirect
32-
codeberg.org/go-latex/latex v0.1.0 // indirect
32+
codeberg.org/go-latex/latex v0.2.0 // indirect
3333
codeberg.org/go-pdf/fpdf v0.11.1 // indirect
34-
git.sr.ht/~sbinet/gg v0.6.0 // indirect
35-
github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp v1.29.0 // indirect
36-
github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric v0.53.0 // indirect
37-
github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping v0.53.0 // indirect
34+
git.sr.ht/~sbinet/gg v0.7.0 // indirect
35+
github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp v1.30.0 // indirect
36+
github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric v0.54.0 // indirect
37+
github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping v0.54.0 // indirect
3838
github.com/ajstarks/svgo v0.0.0-20211024235047-1546f124cd8b // indirect
3939
github.com/aohorodnyk/mimeheader v0.0.6 // indirect
40-
github.com/aws/aws-sdk-go-v2 v1.38.0 // indirect
41-
github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.7.0 // indirect
42-
github.com/aws/aws-sdk-go-v2/config v1.31.0 // indirect
43-
github.com/aws/aws-sdk-go-v2/credentials v1.18.4 // indirect
44-
github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.18.3 // indirect
45-
github.com/aws/aws-sdk-go-v2/internal/configsources v1.4.3 // indirect
46-
github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.7.3 // indirect
40+
github.com/aws/aws-sdk-go-v2 v1.39.2 // indirect
41+
github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.7.1 // indirect
42+
github.com/aws/aws-sdk-go-v2/config v1.31.11 // indirect
43+
github.com/aws/aws-sdk-go-v2/credentials v1.18.15 // indirect
44+
github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.18.9 // indirect
45+
github.com/aws/aws-sdk-go-v2/internal/configsources v1.4.9 // indirect
46+
github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.7.9 // indirect
4747
github.com/aws/aws-sdk-go-v2/internal/ini v1.8.3 // indirect
48-
github.com/aws/aws-sdk-go-v2/internal/v4a v1.4.3 // indirect
49-
github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.13.0 // indirect
50-
github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.8.3 // indirect
51-
github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.13.3 // indirect
52-
github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.19.3 // indirect
53-
github.com/aws/aws-sdk-go-v2/service/s3 v1.87.0 // indirect
54-
github.com/aws/aws-sdk-go-v2/service/sso v1.28.0 // indirect
55-
github.com/aws/aws-sdk-go-v2/service/ssooidc v1.33.0 // indirect
56-
github.com/aws/aws-sdk-go-v2/service/sts v1.37.0 // indirect
57-
github.com/aws/smithy-go v1.22.5 // indirect
48+
github.com/aws/aws-sdk-go-v2/internal/v4a v1.4.9 // indirect
49+
github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.13.1 // indirect
50+
github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.8.9 // indirect
51+
github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.13.9 // indirect
52+
github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.19.9 // indirect
53+
github.com/aws/aws-sdk-go-v2/service/s3 v1.88.3 // indirect
54+
github.com/aws/aws-sdk-go-v2/service/sso v1.29.5 // indirect
55+
github.com/aws/aws-sdk-go-v2/service/ssooidc v1.35.1 // indirect
56+
github.com/aws/aws-sdk-go-v2/service/sts v1.38.6 // indirect
57+
github.com/aws/smithy-go v1.23.0 // indirect
5858
github.com/beorn7/perks v1.0.1 // indirect
5959
github.com/buildbarn/go-sha256tree v0.0.0-20250310211320-0f70f20e855b // indirect
60-
github.com/campoy/embedmd v1.0.0 // indirect
6160
github.com/cespare/xxhash/v2 v2.3.0 // indirect
6261
github.com/cncf/xds/go v0.0.0-20250501225837-2ac532fd4443 // indirect
6362
github.com/envoyproxy/go-control-plane/envoy v1.32.4 // indirect
@@ -79,49 +78,47 @@ require (
7978
github.com/googleapis/gax-go/v2 v2.15.0 // indirect
8079
github.com/grpc-ecosystem/go-grpc-middleware v1.4.0 // indirect
8180
github.com/grpc-ecosystem/go-grpc-prometheus v1.2.0 // indirect
82-
github.com/grpc-ecosystem/grpc-gateway/v2 v2.27.1 // indirect
81+
github.com/grpc-ecosystem/grpc-gateway/v2 v2.27.2 // indirect
8382
github.com/jmespath/go-jmespath v0.4.0 // indirect
8483
github.com/klauspost/compress v1.18.0 // indirect
8584
github.com/lazybeaver/xorshift v0.0.0-20170702203709-ce511d4823dd // indirect
8685
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
8786
github.com/planetscale/vtprotobuf v0.6.1-0.20240319094008-0393e58bdf10 // indirect
88-
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
89-
github.com/prometheus/client_golang v1.23.0 // indirect
87+
github.com/prometheus/client_golang v1.23.2 // indirect
9088
github.com/prometheus/client_model v0.6.2 // indirect
91-
github.com/prometheus/common v0.65.0 // indirect
89+
github.com/prometheus/common v0.66.1 // indirect
9290
github.com/prometheus/procfs v0.17.0 // indirect
9391
github.com/sercand/kuberesolver/v5 v5.1.1 // indirect
94-
github.com/spiffe/go-spiffe/v2 v2.5.0 // indirect
95-
github.com/zeebo/errs v1.4.0 // indirect
96-
go.opentelemetry.io/auto/sdk v1.1.0 // indirect
97-
go.opentelemetry.io/contrib/detectors/gcp v1.37.0 // indirect
98-
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.62.0 // indirect
99-
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.62.0 // indirect
100-
go.opentelemetry.io/contrib/propagators/b3 v1.37.0 // indirect
101-
go.opentelemetry.io/otel v1.37.0 // indirect
92+
github.com/spiffe/go-spiffe/v2 v2.6.0 // indirect
93+
go.opentelemetry.io/auto/sdk v1.2.1 // indirect
94+
go.opentelemetry.io/contrib/detectors/gcp v1.38.0 // indirect
95+
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.63.0 // indirect
96+
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.63.0 // indirect
97+
go.opentelemetry.io/contrib/propagators/b3 v1.38.0 // indirect
98+
go.opentelemetry.io/otel v1.38.0 // indirect
10299
go.opentelemetry.io/otel/exporters/jaeger v1.17.0 // indirect
103-
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.37.0 // indirect
104-
go.opentelemetry.io/otel/metric v1.37.0 // indirect
105-
go.opentelemetry.io/otel/sdk v1.37.0 // indirect
106-
go.opentelemetry.io/otel/sdk/metric v1.37.0 // indirect
107-
go.opentelemetry.io/otel/trace v1.37.0 // indirect
108-
go.opentelemetry.io/proto/otlp v1.7.1 // indirect
109-
go.yaml.in/yaml/v2 v2.4.2 // indirect
110-
golang.org/x/crypto v0.41.0 // indirect
111-
golang.org/x/image v0.30.0 // indirect
112-
golang.org/x/mod v0.27.0 // indirect
113-
golang.org/x/net v0.43.0 // indirect
114-
golang.org/x/oauth2 v0.30.0 // indirect
115-
golang.org/x/sync v0.16.0 // indirect
116-
golang.org/x/sys v0.35.0 // indirect
117-
golang.org/x/text v0.28.0 // indirect
118-
golang.org/x/time v0.12.0 // indirect
119-
golang.org/x/tools v0.36.0 // indirect
120-
google.golang.org/api v0.247.0 // indirect
121-
google.golang.org/genproto v0.0.0-20250818200422-3122310a409c // indirect
122-
google.golang.org/genproto/googleapis/api v0.0.0-20250818200422-3122310a409c // indirect
123-
google.golang.org/genproto/googleapis/bytestream v0.0.0-20250818200422-3122310a409c // indirect
124-
google.golang.org/genproto/googleapis/rpc v0.0.0-20250818200422-3122310a409c // indirect
100+
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.38.0 // indirect
101+
go.opentelemetry.io/otel/metric v1.38.0 // indirect
102+
go.opentelemetry.io/otel/sdk v1.38.0 // indirect
103+
go.opentelemetry.io/otel/sdk/metric v1.38.0 // indirect
104+
go.opentelemetry.io/otel/trace v1.38.0 // indirect
105+
go.opentelemetry.io/proto/otlp v1.8.0 // indirect
106+
go.yaml.in/yaml/v2 v2.4.3 // indirect
107+
golang.org/x/crypto v0.42.0 // indirect
108+
golang.org/x/image v0.31.0 // indirect
109+
golang.org/x/mod v0.28.0 // indirect
110+
golang.org/x/net v0.44.0 // indirect
111+
golang.org/x/oauth2 v0.31.0 // indirect
112+
golang.org/x/sync v0.17.0 // indirect
113+
golang.org/x/sys v0.36.0 // indirect
114+
golang.org/x/text v0.29.0 // indirect
115+
golang.org/x/time v0.13.0 // indirect
116+
golang.org/x/tools v0.37.0 // indirect
117+
google.golang.org/api v0.250.0 // indirect
118+
google.golang.org/genproto v0.0.0-20250922171735-9219d122eba9 // indirect
119+
google.golang.org/genproto/googleapis/api v0.0.0-20250922171735-9219d122eba9 // indirect
120+
google.golang.org/genproto/googleapis/bytestream v0.0.0-20250922171735-9219d122eba9 // indirect
121+
google.golang.org/genproto/googleapis/rpc v0.0.0-20250922171735-9219d122eba9 // indirect
125122
google.golang.org/grpc/security/advancedtls v1.0.0 // indirect
126123
sigs.k8s.io/yaml v1.6.0 // indirect
127124
)

0 commit comments

Comments
 (0)