Fix the web site favicon

moroten · EdSchouten · commit daafd4f0e4e4 · 2023-09-17T06:20:39.000+02:00
It has been broken since 2021-09-09, commit c4d0a62. - The wrong base64 encoding was applied. - Use "icon" instead of deprecated "shurtcut icon", see https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel#icon
diff --git a/cmd/bb_browser/main.go b/cmd/bb_browser/main.go
@@ -130,7 +130,7 @@ func main() {
 			routePrefix += "/"
 		}
 
-		faviconURL := template.URL("data:image/png;base64," + base64.URLEncoding.EncodeToString(favicon))
+		faviconURL := template.URL("data:image/png;base64," + base64.StdEncoding.EncodeToString(favicon))
 		templates, err := template.New("templates").Funcs(template.FuncMap{
 			"basename":    path.Base,
 			"favicon_url": func() template.URL { return faviconURL },
diff --git a/cmd/bb_browser/templates/header.html b/cmd/bb_browser/templates/header.html
@@ -2,7 +2,7 @@
 <html>
 	<head>
 		<title>Buildbarn Browser</title>
-		<link href="{{favicon_url}}" rel="shortcut icon">
+		<link href="{{favicon_url}}" rel="icon">
 		<style>{{stylesheet}}</style>
 	</head>
 	<body>

Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ func main() {`
`130`	`130`	`routePrefix += "/"`
`131`	`131`	`}`
`132`	`132`
`133`		`- faviconURL := template.URL("data:image/png;base64," + base64.URLEncoding.EncodeToString(favicon))`
	`133`	`+ faviconURL := template.URL("data:image/png;base64," + base64.StdEncoding.EncodeToString(favicon))`
`134`	`134`	`templates, err := template.New("templates").Funcs(template.FuncMap{`
`135`	`135`	`"basename": path.Base,`
`136`	`136`	`"favicon_url": func() template.URL { return faviconURL },`