Don't error on some aborted events

Some BEP events, such as

- TargetConfigured
- TargetCompleted
- TestSummary
- TestResult

may be sent with an aborted payload instead of a normal payload,
indicating that the relevant event will never be sent. bb-portal handled
this for TargetCompleted events, but not for the others. This caused
errors during BEP processing when such aborted events were encountered
that were propagated up to the client.

This change updates the BEP processing code to ignore aborted events for
TargetConfigured, TestSummary, and TestResult events, since they have no
relevant data. For TargetCompleted events, the existing handling is
kept, to allow for relevant targets to be shown for bazel queries.

Author: isakstenstrom

ent/gen/ent/mutation.go

@@ -49,7 +49,7 @@ func (TestSummary) Fields() []ent.Field {
 		field.Time("last_stop_time").Optional(),
 
 		// The total runtime of the test.
-		field.Int64("total_run_duration_in_ms").Optional().
+		field.Int64("total_run_duration_in_ms").Optional().Nillable().
 			Annotations(entgql.OrderField("TOTAL_RUN_DURATION_IN_MS")),
 	}
 }

ent/gen/ent/testsummary.go

@@ -101,10 +101,13 @@ export const TestTab: React.FC<Props> = ({ invocationId }) => {
 
   const parsedData: TestTabRowType[] = useMemo(() => {
     return parseGraphqlEdgeList(data?.findTestSummaries).map((ts) => {
-      console.table(ts);
       var cachedLocally: boolean | null = null;
       var cachedRemotely: boolean | null = null;
-      if (ts.testResults !== null && ts.testResults !== undefined) {
+      if (
+        ts.testResults !== null &&
+        ts.testResults !== undefined &&
+        ts.testResults.length > 0
+      ) {
         if (ts.testResults.every((tr) => tr.cachedLocally === true)) {
           cachedLocally = true;
         } else if (ts.testResults.some((tr) => tr.cachedLocally === false)) {

ent/gen/ent/testsummary_create.go

@@ -59,12 +59,20 @@ func (r *BuildEventRecorder) saveTargetConfiguredBatch(ctx context.Context, batc
 		return status.Error(codes.InvalidArgument, "Attempted to configure targets for an invocation but the invocation was already completed.")
 	}
 
-	targetIds, err := getOrCreateTargets(ctx, r.InstanceNameDbID, tx, batch)
+	// Don't handle aborted events.
+	filteredBatch := make([]BuildEventWithInfo, 0, len(batch))
+	for _, x := range batch {
+		if x.Event.GetConfigured() != nil {
+			filteredBatch = append(filteredBatch, x)
+		}
+	}
+
+	targetIds, err := getOrCreateTargets(ctx, r.InstanceNameDbID, tx, filteredBatch)
 	if err != nil {
 		return util.StatusWrap(err, "Failed to get or create targets")
 	}
 
-	if err := createTargetKindMappingsBulk(ctx, r.IsRealTime, r.InvocationDbID, tx, batch, targetIds); err != nil {
+	if err := createTargetKindMappingsBulk(ctx, r.IsRealTime, r.InvocationDbID, tx, filteredBatch, targetIds); err != nil {
 		return util.StatusWrap(err, "Failed to bulk insert event metadata")
 	}
 

ent/schema/testsummary.go

@@ -59,7 +59,15 @@ func (r *BuildEventRecorder) saveTestResultBatch(ctx context.Context, batch []Bu
 		return status.Error(codes.InvalidArgument, "Attempted to configure targets for an invocation but the invocation was already completed.")
 	}
 
-	if err := createTestResultsBulk(ctx, r.InvocationDbID, r.InstanceNameDbID, tx, batch); err != nil {
+	// Don't handle aborted events.
+	filteredBatch := make([]BuildEventWithInfo, 0, len(batch))
+	for _, x := range batch {
+		if x.Event.GetTestResult() != nil {
+			filteredBatch = append(filteredBatch, x)
+		}
+	}
+
+	if err := createTestResultsBulk(ctx, r.InvocationDbID, r.InstanceNameDbID, tx, filteredBatch); err != nil {
 		return util.StatusWrap(err, "Failed to bulk insert test results")
 	}
 

frontend/src/components/TestTab/index.tsx

@@ -57,23 +57,31 @@ func (r *BuildEventRecorder) saveTestSummaryBatch(ctx context.Context, batch []B
 		return status.Error(codes.InvalidArgument, "Attempted to configure targets for an invocation but the invocation was already completed.")
 	}
 
+	// Don't handle aborted events.
+	filteredBatch := make([]BuildEventWithInfo, 0, len(batch))
+	for _, x := range batch {
+		if x.Event.GetTestSummary() != nil {
+			filteredBatch = append(filteredBatch, x)
+		}
+	}
+
 	params := sqlc.UpdateTestSummariesBulkParams{
 		BazelInvocationID: int64(r.InvocationDbID),
 		InstanceNameID:    int64(r.InstanceNameDbID),
-		Labels:            make([]string, len(batch)),
-		ConfigIds:         make([]string, len(batch)),
-		OverallStatuses:   make([]string, len(batch)),
-		TotalRunCounts:    make([]int32, len(batch)),
-		RunCounts:         make([]int32, len(batch)),
-		AttemptCounts:     make([]int32, len(batch)),
-		ShardCounts:       make([]int32, len(batch)),
-		TotalNumCacheds:   make([]int32, len(batch)),
-		StartTimes:        make([]time.Time, len(batch)),
-		StopTimes:         make([]time.Time, len(batch)),
-		Durations:         make([]int64, len(batch)),
+		Labels:            make([]string, len(filteredBatch)),
+		ConfigIds:         make([]string, len(filteredBatch)),
+		OverallStatuses:   make([]string, len(filteredBatch)),
+		TotalRunCounts:    make([]int32, len(filteredBatch)),
+		RunCounts:         make([]int32, len(filteredBatch)),
+		AttemptCounts:     make([]int32, len(filteredBatch)),
+		ShardCounts:       make([]int32, len(filteredBatch)),
+		TotalNumCacheds:   make([]int32, len(filteredBatch)),
+		StartTimes:        make([]time.Time, len(filteredBatch)),
+		StopTimes:         make([]time.Time, len(filteredBatch)),
+		Durations:         make([]int64, len(filteredBatch)),
 	}
 
-	for i, x := range batch {
+	for i, x := range filteredBatch {
 		be := x.Event
 		testSummaryID := be.GetId().GetTestSummary()
 		testSummary := be.GetTestSummary()
@@ -114,7 +122,7 @@ func (r *BuildEventRecorder) saveTestSummaryBatch(ctx context.Context, batch []B
 	if err != nil {
 		return util.StatusWrap(err, "Failed to bulk update test summaries")
 	}
-	if affectedRows != int64(len(batch)) {
+	if affectedRows != int64(len(filteredBatch)) {
 		return status.Errorf(codes.Internal, "Expected to update %d test summaries, but only updated %d", len(batch), affectedRows)
 	}
 

internal/database/buildeventrecorder/save_target_configured.go

@@ -60,6 +60,18 @@ var (
 		filename:     "nextjs_analysis_fail.bep.ndjson",
 		invocationID: "df7178e2-a815-4654-a409-d18e845d1e35",
 	}
+	abortedAnalysis = bepFile{
+		filename:     "bb_portal_no_analyze.bep.ndjson",
+		invocationID: "bb2b45d9-d695-4194-8fdc-01ba50477a92",
+	}
+	abortedBuild = bepFile{
+		filename:     "bb_portal_no_build.bep.ndjson",
+		invocationID: "76651929-40d8-4f79-a2de-6a4a5092b76c",
+	}
+	abortedTests = bepFile{
+		filename:     "bb_portal_aborted_tests.ndjson",
+		invocationID: "64719226-555e-494d-9918-0fd25d468b1e",
+	}
 	authenticatedUserUUID = "8bdb3187-e36c-487e-95b8-f8ca28a82068"
 
 	// An authenticated user UUID not present in any BEP file.
@@ -98,6 +110,9 @@ var (
 				{bepFile: successfulBazelTest},
 				{bepFile: failedBazelTest},
 				{bepFile: failedBazelAnalysis},
+				{bepFile: abortedAnalysis},
+				{bepFile: abortedBuild},
+				{bepFile: abortedTests},
 			},
 			graphqlTestCases: graphqlTestTable{
 				"LoadFullBazelInvocationDetails": {
@@ -132,6 +147,21 @@ var (
 						},
 						wantErr: errInvocationNotFound,
 					},
+					"get aborted analysis invocation": {
+						variables: testkit.Variables{
+							"invocationID": abortedAnalysis.invocationID,
+						},
+					},
+					"get aborted build invocation": {
+						variables: testkit.Variables{
+							"invocationID": abortedBuild.invocationID,
+						},
+					},
+					"get aborted tests invocation": {
+						variables: testkit.Variables{
+							"invocationID": abortedTests.invocationID,
+						},
+					},
 				},
 				"FindBuildByUUID": {
 					"found": {
@@ -168,6 +198,16 @@ var (
 							"invocationID": failedBazelAnalysis.invocationID,
 						},
 					},
+					"get targets for aborted analysis": {
+						variables: testkit.Variables{
+							"invocationID": abortedAnalysis.invocationID,
+						},
+					},
+					"get targets for aborted build": {
+						variables: testkit.Variables{
+							"invocationID": abortedBuild.invocationID,
+						},
+					},
 				},
 				"GetTargetDetails": {
 					"get details for a target": {
@@ -208,6 +248,13 @@ var (
 						},
 					},
 				},
+				"GetTestsForInvocation": {
+					"get tests for aborted tests": {
+						variables: testkit.Variables{
+							"invocationID": abortedTests.invocationID,
+						},
+					},
+				},
 			},
 		},
 		{