Skip to content

Commit bcf0c3c

Browse files
sdclarkeQinusty
authored andcommitted
Adjust buckets for blob sizes
The blob size buckets for prometheus metrics were set up in the same way as the time buckets, however this didn't make sense as it resulted in buckets for < 1 byte which is impossible They have been adjusted to match the buckets used in bb-storage/blobstore
1 parent 01882f9 commit bcf0c3c

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

pkg/fetch/metrics_fetcher.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ var (
2323
Subsystem: "remote_asset",
2424
Name: "http_fetcher_blob_size_bytes",
2525
Help: "Size of blobs fetched using the http fetcher, in bytes",
26-
Buckets: util.DecimalExponentialBuckets(1, 6, 2),
26+
Buckets: prometheus.ExponentialBuckets(1.0, 2.0, 33),
2727
},
2828
[]string{"name", "operation", "resource_type"})
2929
blobAccessOperationsDurationSeconds = prometheus.NewHistogramVec(

pkg/push/metrics_push_server.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ var (
2222
Subsystem: "push_server",
2323
Name: "push_server_blob_size_bytes",
2424
Help: "Size of blobs being pushed, in bytes.",
25-
Buckets: util.DecimalExponentialBuckets(1, 6, 2),
25+
Buckets: prometheus.ExponentialBuckets(1.0, 2.0, 33),
2626
},
2727
[]string{"name", "operation", "resource_type"})
2828
pushServerOperationsDurationSeconds = prometheus.NewHistogramVec(

0 commit comments

Comments
 (0)