-
Notifications
You must be signed in to change notification settings - Fork 21
Description
Currently we naïvely assume that the blobs referenced in requests/responses exist in CAS without checking. We should add something analogous to the CompletenessCheckingBlobAccess to ensure that blobs we reference actually exist.
One thing to be careful of while implementing this is that PushBlob and PushDirectory requests contain an additional pair of digest lists which we will also need to ensure exist. Given this, we'll need to add an extra field (or two, if we want to distinguish between Blob/Directory) to the Asset proto to store these digests so we can check at push and fetch time.
Implementing #3 will give us this for free. Note also that the lack of GetTree in bb-storage along with the RAAPI's Directory based definitions make this difficult to implement efficiently.