Skip to content

Commit 3b3e1be

Browse files
committed
Don't recycle the field number for admin_listen_address
Also document that this option has been replaced now.
1 parent d2eaadd commit 3b3e1be

File tree

2 files changed

+56
-52
lines changed

2 files changed

+56
-52
lines changed

pkg/proto/configuration/bb_scheduler/bb_scheduler.pb.go

Lines changed: 48 additions & 48 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/proto/configuration/bb_scheduler/bb_scheduler.proto

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,17 +14,21 @@ import "pkg/proto/configuration/scheduler/scheduler.proto";
1414
option go_package = "github.com/buildbarn/bb-remote-execution/pkg/proto/configuration/bb_scheduler";
1515

1616
message ApplicationConfiguration {
17+
// Was 'admin_http_listen_address'. The listen address of the HTTP
18+
// server can now be configured through 'admin_http_servers'.
19+
reserved 2;
20+
1721
// Configuration for the HTTP servers that expose the web UI.
1822
//
1923
// TODO: This web UI no longer needs to be integrated into
2024
// bb_scheduler, as the underlying information can be exposed over
2125
// gRPC using the 'build_queue_state_grpc_servers' option.
2226
repeated buildbarn.configuration.http.ServerConfiguration admin_http_servers =
23-
2;
27+
19;
2428

2529
// The path under which the administrative web UI needs to be exposed.
2630
// When left empty, the web UI will be exposed at "/".
27-
string admin_route_prefix = 21;
31+
string admin_route_prefix = 22;
2832

2933
// gRPC servers to spawn to listen for requests from clients
3034
// (bb_storage or Bazel).
@@ -87,7 +91,7 @@ message ApplicationConfiguration {
8791
// size class queue to which drains are added, or from which drains
8892
// are removed.
8993
buildbarn.configuration.auth.AuthorizerConfiguration
90-
modify_drains_authorizer = 19;
94+
modify_drains_authorizer = 20;
9195

9296
// Authorization requirements to be enforced for KillOperations
9397
// RemoveDrain requests issued through the BuildQueueState gRPC
@@ -97,7 +101,7 @@ message ApplicationConfiguration {
97101
// size class queue containing the operation. Not the instance name
98102
// used by the operation itself.
99103
buildbarn.configuration.auth.AuthorizerConfiguration
100-
kill_operations_authorizer = 20;
104+
kill_operations_authorizer = 21;
101105

102106
// The policy for routing actions.
103107
//

0 commit comments

Comments
 (0)