Skip to content

Commit be0ffe7

Browse files
authored
chore: remove -a from git tag to avoid launching editor (#324)
We don't need to annotate release tags, they speak for themselves. Therefore, remove the -a tag, in lieu of adding -m with a message.
1 parent b4cfa07 commit be0ffe7

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/main.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -679,7 +679,7 @@
679679
{
680680
"id": "create_tag",
681681
"name": "Generate tag",
682-
"run": "BUILD_SCM_REVISION=$(git rev-parse --short HEAD)\nBUILD_SCM_TIMESTAMP=$(TZ=UTC date --date \"@$(git show -s --format=%ct HEAD)\" +%Y%m%dT%H%M%SZ)\nRELEASE_TAG=\"${BUILD_SCM_TIMESTAMP}-${BUILD_SCM_REVISION}}\"\ngit tag -a $RELEASE_TAG\ngit push --follow-tags\necho \"release_tag=$RELEASE_TAG\" >> $GITHUB_OUTPUT\n"
682+
"run": "BUILD_SCM_REVISION=$(git rev-parse --short HEAD)\nBUILD_SCM_TIMESTAMP=$(TZ=UTC date --date \"@$(git show -s --format=%ct HEAD)\" +%Y%m%dT%H%M%SZ)\nRELEASE_TAG=\"${BUILD_SCM_TIMESTAMP}-${BUILD_SCM_REVISION}}\"\ngit tag $RELEASE_TAG\ngit push --follow-tags\necho \"release_tag=$RELEASE_TAG\" >> $GITHUB_OUTPUT\n"
683683
},
684684
{
685685
"name": "Create GitHub release and upload artifacts",

tools/github_workflows/workflows_template.libsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@
183183
BUILD_SCM_REVISION=$(git rev-parse --short HEAD)
184184
BUILD_SCM_TIMESTAMP=$(TZ=UTC date --date "@$(git show -s --format=%ct HEAD)" +%Y%m%dT%H%M%SZ)
185185
RELEASE_TAG="${BUILD_SCM_TIMESTAMP}-${BUILD_SCM_REVISION}}"
186-
git tag -a $RELEASE_TAG
186+
git tag $RELEASE_TAG
187187
git push --follow-tags
188188
echo "release_tag=$RELEASE_TAG" >> $GITHUB_OUTPUT
189189
|||,

0 commit comments

Comments
 (0)