Expand test coverage (#232)

* Expand test coverage

* Clean up test function name

Author: Bencodes

.github/workflows/main.yml

@@ -61,9 +61,12 @@ jobs:
       - name: "Configure Bazel"
         run: cp .github/workflows/ci.bazelrc .
       - name: "Unit tests"
-        run: bazel test //...
+        run: bazel test -- //... -//tests/integration/...
   integration-test:
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        detekt-strategy: [local, worker]
     steps:
       - name: "Checkout the sources"
         uses: actions/checkout@v7
@@ -83,5 +86,5 @@ jobs:
         uses: bazelbuild/setup-bazelisk@v3
       - name: "Configure Bazel"
         run: cp .github/workflows/ci.bazelrc .
-      - name: "Integration tests"
-        run: bash tests/integration/suite.sh
+      - name: "Integration tests (${{ matrix.detekt-strategy }})"
+        run: bazel test --strategy=Detekt=${{ matrix.detekt-strategy }} --disk_cache= --cache_test_results=no //tests/integration/...

tests/integration/BUILD

@@ -1,56 +1,104 @@
-load("//detekt:defs.bzl", "detekt")
+load("@bazel_skylib//rules:diff_test.bzl", "diff_test")
+load("@bazel_skylib//rules:write_file.bzl", "write_file")
+load("//detekt:defs.bzl", "detekt_test")
 
-filegroup(
-    name = "detekt_config_lenient",
-    srcs = ["detekt_config_lenient.yml"],
-    tags = ["manual"],
+detekt_test(
+    name = "jvm_static_analysis_test",
+    srcs = ["//tests/integration/testFixtures/basic-jvm:jvm_static_srcs"],
 )
 
-detekt(
-    name = "detekt_without_config",
-    srcs = glob(["src/main/kotlin/**/*.kt"]),
-    tags = ["manual"],
+detekt_test(
+    name = "jvm_classpath_analysis_test",
+    srcs = ["//tests/integration/testFixtures/basic-jvm:jvm_classpath_srcs"],
+    base_path = ".",
+    cfgs = ["detekt_type_resolution.yml"],
+    max_issues = 2,
+    xml_report = True,
+    deps = ["//tests/integration/testFixtures/basic-jvm:jvm_api"],
+)
+
+detekt_test(
+    name = "android_static_analysis_test",
+    srcs = ["//tests/integration/testFixtures/basic-android:android_static_srcs"],
 )
 
-detekt(
-    name = "detekt_without_config_with_report_html",
-    srcs = glob(["src/main/kotlin/**/*.kt"]),
-    html_report = True,
-    tags = ["manual"],
+detekt_test(
+    name = "android_classpath_analysis_test",
+    srcs = ["//tests/integration/testFixtures/basic-android:android_classpath_srcs"],
+    base_path = ".",
+    cfgs = ["detekt_type_resolution.yml"],
+    is_android = True,
+    max_issues = 2,
+    xml_report = True,
+    deps = ["//tests/integration/testFixtures/basic-android:android_api"],
 )
 
-detekt(
-    name = "detekt_without_config_with_report_xml",
-    srcs = glob(["src/main/kotlin/**/*.kt"]),
-    tags = ["manual"],
+detekt_test(
+    name = "custom_rule_analysis_test",
+    srcs = ["//tests/integration/testFixtures/custom-rule:custom_rule_violation_srcs"],
+    base_path = ".",
+    cfgs = ["//tests/integration/testFixtures/custom-rule:custom_rule_config"],
+    max_issues = 1,
+    plugins = ["//tests/integration/testFixtures/custom-rule:custom_rules"],
     xml_report = True,
 )
 
-detekt(
-    name = "detekt_without_config_with_baseline",
-    srcs = glob(["src/main/kotlin/**/*.kt"]),
-    baseline = "detekt_baseline.xml",
-    tags = ["manual"],
+JVM_CLASSPATH_REPORT_XML = """<?xml version="1.0" encoding="UTF-8"?>
+<checkstyle version="4.3">
+<file name="tests/integration/testFixtures/basic-jvm/src/jvm/tests/integration/jvm/JvmClasspath.kt">
+	<error line="4" column="24" severity="warning" message="JvmApi.name()?.length contains an unnecessary safe call operator" source="detekt.UnnecessarySafeCall" />
+</file>
+</checkstyle>"""
+
+write_file(
+    name = "jvm_classpath_report",
+    out = "jvm_classpath_report.xml",
+    content = JVM_CLASSPATH_REPORT_XML.split("\n"),
+    newline = "unix",
 )
 
-detekt(
-    name = "detekt_without_config_with_baseline_with_plugin",
-    srcs = glob(["src/main/kotlin/**/*.kt"]),
-    baseline = "detekt_baseline.xml",
-    plugins = ["@rules_detekt_dependencies//:io_gitlab_arturbosch_detekt_detekt_formatting"],
-    tags = ["manual"],
+diff_test(
+    name = "jvm_classpath_report_test",
+    file1 = ":jvm_classpath_report",
+    file2 = ":jvm_classpath_analysis_test",
 )
 
-detekt(
-    name = "detekt_with_config_file_lenient",
-    srcs = glob(["src/main/kotlin/**/*.kt"]),
-    cfgs = ["detekt_config_lenient.yml"],
-    tags = ["manual"],
+ANDROID_CLASSPATH_REPORT_XML = """<?xml version="1.0" encoding="UTF-8"?>
+<checkstyle version="4.3">
+<file name="tests/integration/testFixtures/basic-android/src/android/tests/integration/android/AndroidClasspath.kt">
+	<error line="6" column="24" severity="warning" message="AndroidApi.packageName(context)?.length contains an unnecessary safe call operator" source="detekt.UnnecessarySafeCall" />
+</file>
+</checkstyle>"""
+
+write_file(
+    name = "android_classpath_report",
+    out = "android_classpath_report.xml",
+    content = ANDROID_CLASSPATH_REPORT_XML.split("\n"),
+    newline = "unix",
+)
+
+diff_test(
+    name = "android_classpath_report_test",
+    file1 = ":android_classpath_report",
+    file2 = ":android_classpath_analysis_test",
+)
+
+CUSTOM_RULE_REPORT_XML = """<?xml version="1.0" encoding="UTF-8"?>
+<checkstyle version="4.3">
+<file name="tests/integration/testFixtures/custom-rule/src/custom/tests/integration/custom/CustomRuleViolation.kt">
+	<error line="1" column="1" severity="warning" message="customRuleViolation is forbidden." source="detekt.ForbiddenFunctionName" />
+</file>
+</checkstyle>"""
+
+write_file(
+    name = "custom_rule_report",
+    out = "custom_rule_report.xml",
+    content = CUSTOM_RULE_REPORT_XML.split("\n"),
+    newline = "unix",
 )
 
-detekt(
-    name = "detekt_with_config_filegroup_lenient",
-    srcs = glob(["src/main/kotlin/**/*.kt"]),
-    cfgs = ["//tests/integration:detekt_config_lenient"],
-    tags = ["manual"],
+diff_test(
+    name = "custom_rule_report_test",
+    file1 = ":custom_rule_report",
+    file2 = ":custom_rule_analysis_test",
 )

tests/integration/detekt_baseline.xml

@@ -0,0 +1,3 @@
+potential-bugs:
+  UnnecessarySafeCall:
+    active: true