Merge pull request #351 from buildkite/ming/remove-old-k8s-exec-envvar

Stop using old k8s exec envvar

Author: zhming0

internal/controller/scheduler/scheduler.go

@@ -272,11 +272,6 @@ func (w *jobWrapper) Build(skipCheckout bool) (*batchv1.Job, error) {
 
 	containerEnv := append([]corev1.EnvVar{}, env...)
 	containerEnv = append(containerEnv, []corev1.EnvVar{
-		{
-			// Deprecated: agents v3.74.0 and newer use BUILDKITE_KUBERNETES_EXEC instead
-			Name:  "BUILDKITE_AGENT_EXPERIMENT",
-			Value: "kubernetes-exec",
-		},
 		{
 			Name:  "BUILDKITE_KUBERNETES_EXEC",
 			Value: "true",
@@ -396,11 +391,6 @@ func (w *jobWrapper) Build(skipCheckout bool) (*batchv1.Job, error) {
 		VolumeMounts:    volumeMounts,
 		ImagePullPolicy: corev1.PullAlways,
 		Env: []corev1.EnvVar{
-			{
-				// Deprecated: agents v3.74.0 and newer use BUILDKITE_KUBERNETES_EXEC instead
-				Name:  "BUILDKITE_AGENT_EXPERIMENT",
-				Value: "kubernetes-exec",
-			},
 			{
 				Name:  "BUILDKITE_KUBERNETES_EXEC",
 				Value: "true",
@@ -541,11 +531,6 @@ func (w *jobWrapper) createCheckoutContainer(
 		VolumeMounts:    volumeMounts,
 		ImagePullPolicy: corev1.PullAlways,
 		Env: []corev1.EnvVar{
-			{
-				// Deprecated: agents v3.74.0 and newer use BUILDKITE_KUBERNETES_EXEC instead
-				Name:  "BUILDKITE_AGENT_EXPERIMENT",
-				Value: "kubernetes-exec",
-			},
 			{
 				Name:  "BUILDKITE_KUBERNETES_EXEC",
 				Value: "true",