agent/internal/artifact/metrics_test.go at 94a13b2dde5cb3832c62d3a09f976267412080cc · buildkite/agent · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
package artifact

import (
	"context"
	"errors"
	"testing"

	"github.com/buildkite/agent/v3/api"
	"github.com/buildkite/agent/v3/logger"
	"github.com/prometheus/client_golang/prometheus/testutil"
)

type artifactMetricsTestAPIClient struct{}

func (artifactMetricsTestAPIClient) CreateArtifacts(context.Context, string, *api.ArtifactBatch) (*api.ArtifactBatchCreateResponse, *api.Response, error) {
	return nil, nil, nil
}

func (artifactMetricsTestAPIClient) SearchArtifacts(context.Context, string, *api.ArtifactSearchOptions) ([]*api.Artifact, *api.Response, error) {
	return nil, nil, nil
}

func (artifactMetricsTestAPIClient) UpdateArtifacts(context.Context, string, []api.ArtifactState) (*api.Response, error) {
	return nil, nil
}

type artifactMetricsTestWorkUnit struct {
	artifact *api.Artifact
}

func (w artifactMetricsTestWorkUnit) Artifact() *api.Artifact { return w.artifact }
func (artifactMetricsTestWorkUnit) Description() string       { return "test work unit" }
func (artifactMetricsTestWorkUnit) DoWork(context.Context) (*api.ArtifactPartETag, error) {
	return nil, nil
}

func TestArtifactMetricsIncrementOnSuccessfulUpload(t *testing.T) {
	t.Parallel()
	ctx := t.Context()

	beforeUploaded := testutil.ToFloat64(artifactsUploaded)
	beforeBytes := testutil.ToFloat64(artifactBytesUploaded)
	beforeFailed := testutil.ToFloat64(artifactUploadFailures)

	artifact := &api.Artifact{ID: "a1", FileSize: 1234}
	worker := &artifactUploadWorker{
		Uploader: &Uploader{
			logger:    logger.Discard,
			apiClient: artifactMetricsTestAPIClient{},
			conf:      UploaderConfig{JobID: "job-1"},
		},
		trackers: map[*api.Artifact]*artifactTracker{
			artifact: {
				pendingWork: 1,
				ArtifactState: api.ArtifactState{
					ID: artifact.ID,
				},
			},
		},
	}

	resultsCh := make(chan workUnitResult, 1)
	errCh := make(chan error, 1)
	go worker.stateUpdater(ctx, resultsCh, errCh)

	resultsCh <- workUnitResult{workUnit: artifactMetricsTestWorkUnit{artifact: artifact}}
	close(resultsCh)

	if err := <-errCh; err != nil {
		t.Fatalf("stateUpdater() error = %v", err)
	}

	if got := testutil.ToFloat64(artifactsUploaded) - beforeUploaded; got != 1 {
		t.Fatalf("artifactsUploaded delta = %v, want 1", got)
	}
	if got := testutil.ToFloat64(artifactBytesUploaded) - beforeBytes; got != 1234 {
		t.Fatalf("artifactBytesUploaded delta = %v, want 1234", got)
	}
	if got := testutil.ToFloat64(artifactUploadFailures) - beforeFailed; got != 0 {
		t.Fatalf("artifactUploadFailures delta = %v, want 0", got)
	}
}

func TestArtifactMetricsIncrementOnFailedUpload(t *testing.T) {
	t.Parallel()
	ctx := t.Context()

	beforeUploaded := testutil.ToFloat64(artifactsUploaded)
	beforeBytes := testutil.ToFloat64(artifactBytesUploaded)
	beforeFailed := testutil.ToFloat64(artifactUploadFailures)

	artifact := &api.Artifact{ID: "a2", FileSize: 4321}
	worker := &artifactUploadWorker{
		Uploader: &Uploader{
			logger:    logger.Discard,
			apiClient: artifactMetricsTestAPIClient{},
			conf:      UploaderConfig{JobID: "job-2"},
		},
		trackers: map[*api.Artifact]*artifactTracker{
			artifact: {
				pendingWork: 2,
				ArtifactState: api.ArtifactState{
					ID: artifact.ID,
				},
			},
		},
	}

	resultsCh := make(chan workUnitResult, 2)
	errCh := make(chan error, 1)
	go worker.stateUpdater(ctx, resultsCh, errCh)

	u := artifactMetricsTestWorkUnit{artifact: artifact}
	resultsCh <- workUnitResult{workUnit: u, err: errors.New("first failure")}
	resultsCh <- workUnitResult{workUnit: u, err: errors.New("second failure")}
	close(resultsCh)

	if err := <-errCh; err == nil {
		t.Fatal("stateUpdater() error = nil, want error")
	}

	if got := testutil.ToFloat64(artifactUploadFailures) - beforeFailed; got != 1 {
		t.Fatalf("artifactUploadFailures delta = %v, want 1", got)
	}
	if got := testutil.ToFloat64(artifactsUploaded) - beforeUploaded; got != 0 {
		t.Fatalf("artifactsUploaded delta = %v, want 0", got)
	}
	if got := testutil.ToFloat64(artifactBytesUploaded) - beforeBytes; got != 0 {
		t.Fatalf("artifactBytesUploaded delta = %v, want 0", got)
	}
}