Merge pull request #3811 from buildkite/compile-regexp-once

DrJosh9000 · web-flow · commit fadbf20e56fb · 2026-04-13T13:59:14.000+10:00
fix: compile badChars regexp once
diff --git a/internal/job/executor.go b/internal/job/executor.go
@@ -807,14 +807,14 @@ func (e *Executor) executeLocalHook(ctx context.Context, name string) error {
 	})
 }
 
+var badCharsRE = regexp.MustCompile("[[:^alnum:]]")
+
 func dirForAgentName(agentName string) string {
-	badCharsPattern := regexp.MustCompile("[[:^alnum:]]")
-	return badCharsPattern.ReplaceAllString(agentName, "-")
+	return badCharsRE.ReplaceAllString(agentName, "-")
 }
 
 func dirForRepository(repository string) string {
-	badCharsPattern := regexp.MustCompile("[[:^alnum:]]")
-	return badCharsPattern.ReplaceAllString(repository, "-")
+	return badCharsRE.ReplaceAllString(repository, "-")
 }
 
 // Given a repository, it will add the host to the set of SSH known_hosts on the machine

Original file line number	Diff line number	Diff line change
`@@ -807,14 +807,14 @@ func (e *Executor) executeLocalHook(ctx context.Context, name string) error {`
`807`	`807`	`})`
`808`	`808`	`}`
`809`	`809`
	`810`	`+var badCharsRE = regexp.MustCompile("[[:^alnum:]]")`
	`811`	`+`
`810`	`812`	`func dirForAgentName(agentName string) string {`
`811`		`- badCharsPattern := regexp.MustCompile("[[:^alnum:]]")`
`812`		`- return badCharsPattern.ReplaceAllString(agentName, "-")`
	`813`	`+ return badCharsRE.ReplaceAllString(agentName, "-")`
`813`	`814`	`}`
`814`	`815`
`815`	`816`	`func dirForRepository(repository string) string {`
`816`		`- badCharsPattern := regexp.MustCompile("[[:^alnum:]]")`
`817`		`- return badCharsPattern.ReplaceAllString(repository, "-")`
	`817`	`+ return badCharsRE.ReplaceAllString(repository, "-")`
`818`	`818`	`}`
`819`	`819`
`820`	`820`	`// Given a repository, it will add the host to the set of SSH known_hosts on the machine`