Draft
Conversation
|
hey @markmssd just wanted to jump in to confirm that we've got the PR on our list. we've been very swamped this week but we'll have a close look soon for you. |
DrJosh9000
reviewed
Mar 25, 2026
Contributor
DrJosh9000
left a comment
DrJosh9000
left a comment
There was a problem hiding this comment.
Thanks @markmssd, this is pretty great!
If you want to add tests, I think it would be fine if you wanted to make some of them Windows-only via t.Skip (there's plenty of precedent), e.g.
func TestSomething_Windows(t *testing.T) {
if runtime.GOOS != "windows" {
t.Skip("assumes PowerShell 5 is powershell.exe")
}
}rather than trying to fake runtime.GOOS
|
|
||
| if commandOverride != "" { | ||
| // first element is the command, all others are args to which we append path | ||
| commandParts := strings.Fields(commandOverride) |
Contributor
There was a problem hiding this comment.
strings.Fields is close, but we should support the same OS-dependent quoting used for BUILDKITE_SHELL and various other flags, e.g.:
agent/internal/job/executor.go
Lines 1153 to 1157 in 9b50c93
Suggested change
| commandParts := strings.Fields(commandOverride) | |
| commandParts, err := shellwords.Split(commandOverride) | |
| if err != nil { | |
| return Command{}, fmt.Errorf("splitting hooks shell %q: %w", commandOverride, err) | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PowerShell 5.1 is the latest supported version, and does not receive any more updates. See https://learn.microsoft.com/en-us/powershell/scripting/install/powershell-support-lifecycle?view=powershell-7.5#windows-powershell-release-history. They now focus on the cross-platform version 7.
Difference between v5 and v7: https://learn.microsoft.com/en-us/powershell/scripting/whats-new/differences-from-windows-powershell?view=powershell-7.5#powershell-executable-changes
Buildkite Agent targets PowerShell 5.1 on Windows, which is convenient because it's always pre-installed on modern Windows. However, it'd be nice to configure it to use PowerShell 7 instead.
Context
Closes #3657
Changes
This PR does a few things to make it work:
.ps1hooks even on non-Windows OSBUILDKITE_HOOKS_SHELL/--hooks-shell, which works similar toBUILDKITE_SHELL/--shell, but for the Agent Hooks.Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits